Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 127025

Summary: system thread filter loses selection/collapses on first invocation
Product: [Eclipse Project] JDT Reporter: Darin Wright <darin.eclipse>
Component: DebugAssignee: Kevin Barnes <cocoakevin>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3    
Version: 3.2   
Target Milestone: 3.2 RC2   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
patch
none
patch
none
patch
none
Latest patch
none
Latest patch with debug flags/output
none
Latest patch none

Description Darin Wright CLA 2006-02-09 00:17:42 EST 
I20060208

* launch workspace (show system threads is persisted as "off")
* debug to a breakpoint in debug perspective
* thread suspends/selects
> filter kicks in and refreshes the view collapsing the thread and losing the selection
Comment 1 Darin Wright CLA 2006-02-10 12:44:11 EST 

*** This bug has been marked as a duplicate of 126379 ***
Comment 2 Darin Wright CLA 2006-04-20 18:24:26 EDT 
This one is not a dup. The problem with thread groups is slightly different as turning on thread groups changes tree paths making selection maintenance more difficult.
Comment 3 Darin Wright CLA 2006-04-20 18:25:37 EDT 
Created attachment 39118 [details]
patch

The patch simiplifies model/viewer interaction and maintains selection when refreshing/filtering.
Comment 4 Darin Wright CLA 2006-04-20 18:25:52 EDT 
Marking as RC2 candidate.
Comment 5 Darin Wright CLA 2006-04-21 10:40:43 EDT 
Applied to HEAD. Please verify changes are OK with table viewer/memory view.
Comment 6 Darin Wright CLA 2006-04-21 10:41:00 EDT 
Please verify, Samantha.
Comment 7 Darin Wright CLA 2006-04-21 13:29:12 EDT 
We have seen some worse behavior in the debug view - missing threads/frames.
Comment 8 Darin Wright CLA 2006-04-21 13:54:34 EDT 
Created attachment 39194 [details]
patch 

This patch undoes the model/viewer interaction changes but keeps other important fixes.
Comment 9 Samantha Chan CLA 2006-04-21 14:07:37 EDT 
After applying the undo patch, I am starting to see lots of threads being created again.  I am testing with a testcase with many variables.  The latest fix seems to have slowed down the debugger again.
Comment 10 Darin Wright CLA 2006-04-21 14:40:56 EDT 
Created attachment 39201 [details]
patch

I backed out the changes and created a patch for the changes that were backed out.
Comment 11 Darin Wright CLA 2006-04-21 18:44:18 EDT 
Created attachment 39227 [details]
Latest patch
Comment 12 Darin Wright CLA 2006-04-23 17:19:43 EDT 
Created attachment 39265 [details]
Latest patch with debug flags/output
Comment 13 Darin Wright CLA 2006-04-24 16:00:06 EDT 
Created attachment 39347 [details]
Latest patch
Comment 14 Darin Wright CLA 2006-04-24 16:07:35 EDT 
Fixed (changes are in the latest patch).

Changed view/model interaction to not dispose nodes in the model that have not been removed when children are set (so the frame of the suspended thread remains in the model in this case). Viewer now uses clears/setItemCount instead of disposing items.
Comment 15 Darin Wright CLA 2006-04-24 16:07:47 EDT 
Please verify, Kevin.
Comment 16 Kevin Barnes CLA 2006-04-27 12:07:24 EDT 
verified