Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 124276

Summary: [change method signature] message could be made more clear
Product: [Eclipse Project] JDT Reporter: Philipe Mulet <philippe_mulet>
Component: UIAssignee: Markus Keller <markus.kell.r>
Status: CLOSED WONTFIX QA Contact:
Severity: normal    
Priority: P3 CC: tobias_widmer
Version: 3.2   
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard: stalebug

Description Philipe Mulet CLA 2006-01-18 05:54:46 EST 
Build 3.2m4

When selecting a method which has a super-method and intending to change its signature; the user is prompted about the fact there is a definition of the same method higher in type hierarchy.

Then it asks whether it should modify "this" method.

It is unclear what "this" is denoting at this point in the message. Implicitly it feels like it would denote the super method (the latter in msg), but it really is denoting the selected method. I believe the message should be rephrased to avoid ambiguity (saying "the selected method" instead of "this method").
Comment 1 Philipe Mulet CLA 2006-01-18 06:16:04 EST 
Actually, considering other bugs like bug 124278, I believe "this" denotes the super method. Really confusing.

I believe refactoring should honour the selection, and perform the transformation described in bug 124278.

In real code, I came across a situation where I wanted a subset of the AST nodes to have a slightly different protocol with one extra argument, without touching the entire node tree.
Comment 2 Martin Aeschlimann CLA 2006-01-18 10:17:54 EST 
Agree, it makes sense to tell more in the dialog.
Comment 3 Tobias Widmer CLA 2006-01-19 11:39:53 EST 
If the method (which itself is in source) directly overrides a binary method, this dialog appears as well, just to tell the user that the operation "cannot be performed" afterwards when clicking on yes.
First, the dialog message is less than specific, and second, this should be checked before showing the dialog mentioned in comment 0.
Obvious things like binary supermethods should already be handled by the custom UserInterfaceStarter of the refactoring.
Comment 4 Eclipse Genie CLA 2020-04-08 20:21:52 EDT 
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.