Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 123787

Summary: [Patch] Apply Patch error handling for invalid formats
Product: [Eclipse Project] Platform Reporter: Navid Mehregani <nmehrega>
Component: CompareAssignee: Dani Megert <daniel_megert>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: daniel_megert, gheorghe
Version: 3.2   
Target Milestone: 4.3 M1   
Hardware: All   
OS: All   
Whiteboard:
Bug Depends on:    
Bug Blocks: 386909    
Attachments:
Description Flags
The patch that's used none

Description Navid Mehregani CLA 2006-01-13 11:55:22 EST 
I try applying the attached patch, but when I click on the next button nothing happens. No error messages, nothing.  I don't think the patch is in valid format, but shouldn't it generate some sort of error message?

I tried this on 3.0, 3.1, and 3.2 drivers.

Not sure if I got the component of this bug right...
Comment 1 Navid Mehregani CLA 2006-01-13 11:55:43 EST 
Created attachment 32993 [details]
The patch that's used
Comment 2 Olivier Thomann CLA 2006-01-13 11:57:55 EST 
Move to Platform/Team
Comment 3 Bogdan Gheorghe CLA 2006-01-13 13:25:42 EST 
You're correct in that the patch is not in a valid format for the Eclipse Apply Patch Wizard. Note that a patch must be created using the Unified format if it is to be applied by the Patch Wizard.

You're also right in that we should be notifying users of incorrect patch formats.
Comment 4 Bogdan Gheorghe CLA 2006-03-14 15:46:26 EST 
Upon further investigation, it would appear that the patch parser doesn't properly detect non-unified format patches. To properly fix this would involve a significant refactoring of the parser, which I don't want to attempt at this point in the release cycle. As such, I'm moving this off to the future.

Out of curiousity, Navid, how did you generate your patch? Did you use an external tool?
Comment 5 Navid Mehregani CLA 2006-03-14 16:26:12 EST 
Actually I didn't generate the patch.  It was provided to me.  Yes, they used an external tool to generate it.  I believe they used a patch utility in unix.
Comment 6 Dani Megert CLA 2012-06-14 09:20:36 EDT 
*** Bug 382619 has been marked as a duplicate of this bug. ***
Comment 7 Dani Megert CLA 2012-06-14 09:20:57 EDT 
*** Bug 373975 has been marked as a duplicate of this bug. ***
Comment 9 Malgorzata Janczarska CLA 2012-08-08 05:49:35 EDT 
(In reply to comment #8)
> Fixed in master:
> http://git.eclipse.org/c/platform/eclipse.platform.team.git/commit/?id=2632475c64c20d5354ade3e3772023573dc7a500
This commit seems to be making tests fail, see Bug 386809.
Comment 10 Dani Megert CLA 2012-08-08 05:53:09 EDT 
.
Comment 11 Dani Megert CLA 2012-08-08 08:45:11 EDT 
The fix did not handle the case of multiple projects / files.

Fixed with http://git.eclipse.org/c/platform/eclipse.platform.team.git/commit/?id=45591a0a8b4ec9665de02bc912049cfc8f04bf89

Also updated 'integration'.
Comment 12 Dani Megert CLA 2012-08-09 08:01:45 EDT 
Verified in I20120808-2000.