Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 122743

Summary:	ToggleBreakpointAction must implement IUpdate
Product:	[Eclipse Project] Platform	Reporter:	Dani Megert <daniel_megert>
Component:	Debug	Assignee:	Kevin Barnes <cocoakevin>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	P3
Version:	3.2
Target Milestone:	3.2 M5
Hardware:	PC
OS:	Windows XP
Whiteboard:

Description Dani Megert

2006-01-05 06:40:19 EST

I20060103-0800

In order to correctly update the enablement state of action delegates the ToggleBreakpointAction must implement IUpdate and correctly update the enablement state. This is similar to JavaBreakpointPropertiesRulerAction.

NOTE: It looks as if the ToggleBreakPointAction is not capable of adding the breakpoints to external files / files not on the build path. Correct? See also Wassim's comment: bug 54900, comment 18.

Comment 1 Darin Wright

2006-01-05 08:40:41 EST

We do support breakpoints in external files, bug the feature was broken when we added support to not add breakpoints in remote files. We have bug 120170 logged for this.

Comment 2 Dani Megert

2006-01-05 08:43:16 EST

Note: you can now easily test it since there's now a vertical ruler for external files (HEAD).

Comment 3 Darin Wright

2006-01-30 15:33:24 EST

Fixed in ToggleBreakpointAction. Its an API action, but only meant to be instantiated. Method addition OK.

Comment 4 Darin Wright

2006-01-30 15:33:40 EST

Please verify, Kevin.

Comment 5 Kevin Barnes

2006-02-03 12:14:03 EST

verified