Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 122461

Summary: Snippets Settings Should Be Preferences
Product: [Tools] GEF Reporter: Arthur Ryman <ryman>
Component: GEF-Legacy GEF (MVC)Assignee: gef-inbox <gef-inbox>
Status: RESOLVED WONTFIX QA Contact:
Severity: enhancement    
Priority: P3 CC: ahunter.eclipse, for.work.things, hudsonr
Version: 2.1   
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:

Description Arthur Ryman CLA 2006-01-02 12:29:02 EST
The snippets view has Settings and Customize commands. These seem inconsistent with Eclipse UI guidelines. I think these should really be Preferences. Certainly the Settings are display preferences. The Customize adds content, but Snippets and very similar to Templates and those are handled by Preferences. Perhaps the pop commands should say Properties to control the Settings, and also have New, Edit, Delete commands which are context sensitive depending on the selected item.
Comment 1 Nitin Dahyabhai CLA 2008-12-08 22:53:33 EST
The "Settings" and "Customize" actions from the context menu come from org.eclipse.gef.ui.palette.PaletteContextMenuProvider.
Comment 2 Anthony Hunter CLA 2008-12-09 11:12:41 EST
This would be an enhancement request.

Given that these menus have been in GEF for at least five releases, we would not do this work in a minor release.

Comment 3 Randy Hudson CLA 2008-12-09 11:54:50 EST
It's not 100% clear what is being requested. Do you want to modify both the content and layout of the snippets view in a single place? So, combine the two actions into one and write a dialog which merges everything together? Note that some applications don't support both settings and content customization, or the scope of each is not the same.

I can't see a pattern in eclipse views. Some expose all of their "preferences" in the view menu, so "Preferences..." doesn't appear in the menu. Project Explorer view has a "Customize View...", Problems View has both "Configure Contents..." and "Preferences...". The most commonly used view(s), Package Explorer/Navigator, don't have a "Preferences..." action.
Comment 4 Arthur Ryman CLA 2008-12-09 12:38:13 EST
Randy, I opened this 2 years ago and have moved on to another project so I really can't comment intelligently about the current state of WTP. I think you should work with the owner of the snippets component in WTP.
Comment 5 Anthony Hunter CLA 2008-12-09 14:15:08 EST
WTP can reopen if they require any GEF enhancements.