Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 12216

Summary:	[ActionSets] Problems using actionSetPartAssociations
Product:	[Eclipse Project] Platform	Reporter:	Dirk Baeumer <dirk_baeumer>
Component:	UI	Assignee:	Platform UI Triaged <platform-ui-triaged>
Status:	CLOSED WONTFIX	QA Contact:
Severity:	major
Priority:	P5	CC:	erich_gamma, mistria, n.a.edgar, pchaganti
Version:	2.0	Keywords:	helpwanted
Target Milestone:	---
Hardware:	PC
OS:	Windows 2000
Whiteboard:
Bug Depends on:	35168
Bug Blocks:

Description Dirk Baeumer

2002-03-25 09:57:12 EST

Build 20020321

I have created a action set part association that associates the refactoring 
action set with the packages view and the compilation unit editor (like in the 
documentation). 

Create a fresh workspace reveals the following behaviour:

- focus on packages view: action set visible
- focus on non Welcome editor: action set not visible
- focus on task list: action set not visible

Now, create Test project and a CU A

- focus on Compilation unit editor: action set visible
- focus on task list: action set visible <== ??

Close editor with task list having focus:

- focus on task list: action set visible <== ??
- giving focus to packages view and then back to task list: action 
  set not visible

Ensure task list has focus

- open customize menu
- check refactoring action set
- press ok
- open customize menu
- uncheck refactoring action set
- press ok

Now the action set is completely gone and there is no way to get the old 
behaviour back (where the action set is enabled for packages view and 
compilation unit editor). If I enable the action set, it is enabled for all 
views.

I am aware of the note in the documentation but IMO this is simply not the 
desired behaviour.

Comment 1 Dirk Baeumer

2002-04-23 05:08:17 EDT

The problem is that as soon as you use the customize dialog to enable or 
disable an action set you can't reset the action set into a state that the part-
action set association is used. Steps to reproduce:

- create a fresh workspace
- switch to Java prespective
- disable Java action set
- give focus to Java part (e.g package view)
  observe: Source and Refactor menu are still missing although there is a
    view part - action set association.

We thought about letting the user deceide whether the Source and Refactor is 
active for all views in a Java perspective or only if a Java view part or 
editor is selected.

Expected behaviour:

- use a combo box with three states (enabled, disabled, honor part-action set
  association) instead of a check box

A simple solution whould be:

- if action set is unchecked the workbench honors the part-action set
  association

Comment 2 Nick Edgar

2002-04-23 10:00:23 EDT

Note that Reset Perspective gets the part associations back.

Comment 3 Randy Giffen

2002-05-28 00:00:02 EDT

Defer work on better perspective custimization dialog

Comment 4 Randy Giffen

2002-08-09 16:07:30 EDT

Reopen to investigate

Comment 5 Nick Edgar

2002-11-22 14:10:49 EST

For the two strange cases noted above for
- focus on task list: action set visible <== ??

The first case occurs because actions sets associated with an editor remain 
visible as long as the editor is frontmost (even if it is not active).  This is 
desirable for UI stability when switching between views and editors.

The second case sounds like a bug, but I cannot reproduce it in I20021119.

So the only remaining issue here is being able to recover the dynamic part 
association behaviour after the user explicitly turns an action set on or off.

Comment 6 Nick Edgar

2004-10-20 12:24:34 EDT

*** Bug 76550 has been marked as a duplicate of this bug. ***

Comment 7 Paul Webster

2007-04-05 19:01:21 EDT

Assigning to component owner
PW

Comment 8 Mickael Istria

2016-11-10 12:02:54 EST

actionSetPartAssociations have been deprecated in favor of the org.eclipse.ui.commands/org.eclipse.ui.menus extensions. No more work will be planned on deprecated extensions.