Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 120027

Summary: TVT3.1.x:TCT246: Decorator Preview should be LTR
Product: [Eclipse Project] Platform Reporter: CDE Administration <cdeadmin>
Component: CVSAssignee: Michael Valenta <Michael.Valenta>
Status: RESOLVED FIXED QA Contact:
Severity: major    
Priority: P3 CC: camle, Karice_McIntyre, kitlo, Michael.Valenta, mtveety, steven.wasleski
Version: 3.1.1   
Target Milestone: 3.2 M5   
Hardware: PC   
OS: Windows XP   
URL: 246
Whiteboard:
Attachments:
Description Flags
decorator_preview.jpg none

Description CDE Administration CLA 2005-12-08 18:29:51 EST 
The tree view in the Preview part of the Label Decorations -> General panel is not displayed correctly. Labels consisting of English and neutrals are garbled because reading order is RTL. I don't think I can do anything about that as they are not coming from PII, although I did find similar entries in
eclipse\plugins\org.eclipse.team.cvs.ui\org\eclipse\team\internal\ccvs\ui\message.properties.

Reading order of the lables should be LTR, if that can't be done then the entire tree has to be LTR.

This article was reassigned from Category:''Legacy Project,TVT,Uncategorized''.
Comment 1 CDE Administration CLA 2005-12-08 18:29:55 EST 
Created attachment 31436 [details]
decorator_preview.jpg
Comment 2 CDE Administration CLA 2005-12-08 18:29:58 EST 
<cde:tctdetail>
Testcase: 09.002780
Project: WSW3A
Component: Platform
Priority: 2
Subject: Decorator Preview should be LTR
Article ID: 246
Originator: gpelleg@il.ibm.com
</cde:tctdetail>
Comment 3 Michael Valenta CLA 2005-12-08 20:41:03 EST 
Billy, why did you assign this to the CVS component? Karice, if this is a CVS problem, feel free to assign it back but I'll need you to provide a description of what we are doing wrong and how to correct it (or a pointer to documentation that describes it).
Comment 4 Billy Biggs CLA 2005-12-08 20:49:33 EST 
The reporter changed the component to CVS so I just reassigned it
to make sure that the inbox matched the component field so it didn't
get lost. :)
Comment 5 Karice McIntyre CLA 2005-12-09 10:32:17 EST 
It's ok to leave it in Platform UI for now.  We will probably need to use LRM markers in the .properties files to resolve this problem (it appears to be a widespread problem), but I need to investigate that solution a bit more first.
Comment 6 Karice McIntyre CLA 2006-01-03 18:31:27 EST 
Michael, is the text in the preview area of the CVS Label Decorations preference page a translated string?  Specifically, do the neutral characters >, ], and ) appear in the properties files?  If so, then this can bug should be fixable by the translators.  Looks like the > in English got flipped to < in rtl orientation.
Comment 7 Michael Valenta CLA 2006-01-04 10:48:01 EST 
I found the problem. The text in question is user configurable but the defaults are not NLSed. I'll NLS the defaults.
Comment 8 Michael Valenta CLA 2006-01-04 10:57:16 EST 
Fix released to HEAD. The default decorator configuration strings are now NLSed. The new keys in the org.eclipse.team.cvs.ui/src/org/eclipse/team/internal/ccvs/messages.properties file are:

	CVSDecoratorConfiguration_0;
	CVSDecoratorConfiguration_1;
	CVSDecoratorConfiguration_2;
	CVSDecoratorConfiguration_3;
	CVSDecoratorConfiguration_4;