Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 118857

Summary:	[Viewers] AbstractTreeViewer#add(Object, Object[]) is inefficient
Product:	[Eclipse Project] Platform	Reporter:	Markus Keller <markus.kell.r>
Component:	UI	Assignee:	Platform UI Triaged <platform-ui-triaged>
Status:	CLOSED WONTFIX	QA Contact:
Severity:	normal
Priority:	P3	Keywords:	helpwanted
Version:	3.2
Target Milestone:	---
Hardware:	PC
OS:	Windows XP
Whiteboard:	stalebug

Description Markus Keller

2005-12-01 11:37:44 EST

I20051130-1215

AbstractTreeViewer#add(Object, Object[]) is inefficient:
It calls (after some intermediate methods) createAddedElements(Widget, Object[]), which calls refresh(Object) on every element. refresh(Object) wrappers a preservingSelection(..) around each internalRefresh(Object).

It would be enough to
- wrapper internalAdd() or createAddedElements() in a preservingSelection(..),
- and call internalRefresh(Object) in createAddedElements(Widget, Object[])

Comment 1 Boris Bokowski

2009-11-26 09:55:51 EST

Hitesh is now responsible for watching bugs in the [Viewers] component area.

Comment 2 Eclipse Webmaster

2019-09-06 15:31:17 EDT

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

Comment 3 Eclipse Genie

2021-08-31 16:59:10 EDT

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.