Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 118288

Summary: Remove workaround in restarting server after updating web.xml
Product: [WebTools] WTP Webservices Reporter: Kathy Chan <kathy>
Component: jst.wsAssignee: Kathy Chan <kathy>
Status: CLOSED DUPLICATE QA Contact:
Severity: normal    
Priority: P3    
Version: 1.0   
Target Milestone: 1.0.1 M101   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Bug Depends on: 119954    
Bug Blocks:    

Description Kathy Chan CLA 2005-11-28 15:29:57 EST 
Now that bug 118099 had been fixed by Tim, we should remove the workaround put in for the problem found in bug 102117.

See TODO in UpdateWebXMLCommand put in by Jeffrey:

// TODO: The following snippet of code is to restart the server
            // after web.xml gets updated with the Axis Admin servlet.
            // Ideally, we do NOT need this because the base framework should
            // handle the restart for us. However, we found that the Tomcat
            // server is over reporting whether it needs to be restarted or not.
            // For example, if you put a .java file in a Web module, Tomcat
            // will say, I need to be restarted. To prevent restarting of
            // servers every time we generate a Web service, the base framewrok
            // made the restart condition to be more restrictive. That is,
            // not only does the server has to say it needs to be restarted, it
            // also have to say it needs to be re-published. A side effect of the
            // more restrictive condition is that, web.xml changes will not
            // cause a server restart. The following piece of code is to
            // workaround the problem reported in bug 118099. For more information, see comments
            // in org.eclipse.jst.ws.internal.consumption.ui.command.StartServerCommand
Comment 1 Chris Brealey CLA 2005-11-29 10:43:26 EST 
This is cleanup - Not a major issue. Lowering severity.
Comment 2 Kathy Chan CLA 2006-01-19 12:12:23 EST 

*** This bug has been marked as a duplicate of 119954 ***
Comment 3 Kathy Chan CLA 2006-01-19 12:26:28 EST 
Also removing the unnecessary call to PublishServerCommand put in as a safety measure in bug 119140 when server tooling was not reporting publish state properly.  The change to server tooling was in WTP 1.0.  We just did not remove this unnecessary call then.  I tested for the problem reported in 119140 (top-down followed by bottom-up and two bottom-up scenario one after another) after removing the call to PublishServerCommand and those scenarios were fine.

After removing calling publish and start server in UpdateWebXmlCommand, 
I've also tested with the scenario described in the original bug 102117 (Web module added to server and server started when running through Web service creation).  The problem is no longer there with the fix for bug 119954.
Comment 4 Kathy Chan CLA 2006-01-30 12:16:57 EST 
Verified on M101 0124_0254 driver.