Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 117991

Summary:

[Create Patch] Suggested UI/option improvements

Product:

[Eclipse Project] Platform

Reporter:

Paul Smith <psmith>

Component:

CVS

Assignee:

platform-cvs-inbox <platform-cvs-inbox>

Status:

RESOLVED WORKSFORME

QA Contact:

Severity:

trivial

Priority:

CC:

tomasz.zarna

Version:

3.2

Keywords:

helpwanted

Target Milestone:

---

Hardware:

Macintosh

OS:

Mac OS X - Carbon (unsup.)

Whiteboard:

Attachments:

Description	Flags
Screenshot of Create patch wizard on OSX showing lack of space allocated to workspace area.	none

Description Paul Smith

2005-11-24 22:47:54 EST

against 3.2 M3

The new Create Patch wizard is TheBomb(tm), how happy am I with the ability to select which bits make up the patch (was the original reporter for that one).

Anyway, 2 very minor suggestions to make it UberAwesome (out now from Mattel...):

1) (In OSX at least) the Create Patch window cannot be maximized.  If you're dealing with a large project, the FIRST thing I always have to do is resize the dialag so I can see what the hell I'm doing.  Allowing it to be maximizing would be damn handy.  I would also suggest that the proportion of space of the dialog given to the selection-of-changes area is way to small out of the box. 50% of the dialog is in the Patch loaction, 25% is in the toolbar at the bottom, and there's wasted space below Select All etc (see attached screenshot, just incase this is an OSX specific issue)

2) The Patch Root option in the 2nd sequence of the wizard is default to the new "Workspace".  I debate the setting of this as the default.  Wouldn't project be a more common use-case?  Particularly in a team environment you want to be able to send around a project specific patch more often than workspace. (i guess it all depends on how people do things) 

cheers Guys 'n' Gals

Comment 1 Paul Smith

2005-11-24 22:48:38 EST

Created attachment 30594 [details]
Screenshot of Create patch wizard on OSX showing lack of space allocated to workspace area.

Comment 2 Michael Valenta

2006-01-10 16:29:49 EST

Glad you like it.

Comment 3 Tomasz Zarna

2008-08-11 07:13:23 EDT

(In reply to comment #0)
> 1) (In OSX at least) the Create Patch window cannot be maximized.  

The wizard can be maximized in 3.5M1. I didn't check it in OSX though, but I guess you can do it there too.

> 2) The Patch Root option in the 2nd sequence of the wizard is default to the
> new "Workspace".  

The wizard stores the last selection of that option. If you choose "Project" once, it will be the default selection until you change it to something different. However, sometimes the option can be switched automatically, take a look at bug 191052 for more details.

Please upgrade to the latest version (3.4 or an I-build for 3.5) and feel free reopen if I lied to you :)