Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 117869

Summary:	[UI] Convert file delimiters actions not available in SSE editors
Product:	[WebTools] WTP Source Editing	Reporter:	Missing name <iyers>
Component:	wst.sse	Assignee:	wst.sse <wst.sse-inbox>
Status:	RESOLVED FIXED	QA Contact:	Nitin Dahyabhai <thatnitind>
Severity:	normal
Priority:	P3	CC:	for.work.things, nsand.dev
Version:	1.0
Target Milestone:	3.3 M1
Hardware:	PC
OS:	Windows XP
Whiteboard:
Bug Depends on:	130773
Bug Blocks:

Description Missing name

2005-11-24 05:25:36 EST

Convert file delimiters actions was available for xml, html files etc. in WTP 0.7

They are missing WTP1.0M8.

Comment 1 Nitin Dahyabhai

2005-11-28 14:27:13 EST

Also missing in 1.0M9.

Comment 2 Amy Wu

2005-11-29 18:14:04 EST

Looks like this could be a base bug that became exposed when we changed how selection works in our editors.

The convert line delimiter actions all extend FileBufferOperationAction and in the selectionChanged method, there's a check on the current selection.  If it's a structured selection, it checks if one of the selections is a resource of some sort.  If it's a text selection, then it does some special text selection processing.  We need the special text selection processing but we have a structuredselection.

I'll open a bug on the base saying they should add that if they are given a structured selection, they should look within the structured selection for a text selection.

Comment 3 Amy Wu

2005-11-29 19:12:23 EST

bug 118543 was opened on the base.

Comment 4 Amy Wu

2006-01-04 12:42:49 EST

Clarified the bug summary because while the base's convert file delimiters actions are not available from within the WTP editors, you can still use the convert delimiters actions if you select the files from the Project Explorer or Navigator view.

Also, as a workaround, you can use the convert line delimiters option inside the Cleanup dialog (Cleanup Document.. in the editors' context menu)

Comment 5 Amy Wu

2006-03-07 14:05:39 EST

This bug is now fixed for all editors except for the xml editor thanks to the platform fixing bug 118543.

While verifying, I discovered Convert Line delimiters is still not available in the xml editor.  Actually, it is available when you are on the design page, but not the source page.  This seems a little backwards.  This is due to another bug: bug 130773.  I will go ahead and mark this bug dependent on that one.

Comment 6 Amy Wu

2008-10-27 04:33:31 EDT

reassigning to inbox

Comment 7 Ian Tewksbury

2009-12-15 14:18:53 EST

Supposedly this will be fixed by Bug 130773.  I will wait for that fix before looking into this any more.

Comment 8 Nick Sandonato

2010-07-27 17:38:18 EDT

Has been fixed by Bug 130773.