Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 117068

Summary: [Scale up]Log File Import Wizard - change the formatter/outputter for GLA
Product: z_Archived Reporter: Christine Knight <knight>
Component: TPTP.monitoringAssignee: Alex Nan <apnan>
Status: CLOSED FIXED QA Contact:
Severity: enhancement    
Priority: P1 CC: labadie, prafulr, rohit.shetty, slavescu, zung
Version: unspecifiedKeywords: plan
Target Milestone: ---   
Hardware: PC   
OS: Windows 2000   
URL: http://www.eclipse.org/tptp/groups/Architecture/documents/features/hf_117068.html
Whiteboard: closed460
Bug Depends on: 117062    
Bug Blocks: 112558    
Attachments:
Description Flags
Old CommonBaseEvent XML Log parser adapter
none
New CommonBaseEvent XML Log Parser adapter file none

Description Christine Knight CLA 2005-11-18 11:19:00 EST
The GLA will have a formatter to produce consumer CBE and outputter which caches
these for direct consumption by LTA (see bug 117062). Need the loader to grab
the cache and add the CBE to the model. 

The file import wizard will need to under the covers change the GLA config to
use the formatter above.
Comment 1 Christine Knight CLA 2005-11-18 11:21:56 EST
Please raise this to P1.

Note that this new mechanism should also be used when receiving CBE XML from the
remote AC.
Comment 2 Christine Knight CLA 2005-11-18 12:00:28 EST
From original description - no loader changes needed.
The GLA will have a formatter to produce consumer CBE and outputter which caches
these for direct consumption by LTA (see bug 117062). 

The file import wizard will need to under the covers change the GLA config to
use the formatter above.

Comment 3 Dave Smith CLA 2005-11-25 09:57:54 EST
The Log Import Wizard needs to include this new formatter in the adapter files in the non-filter scenario.

For rules-based adapters, the existing formatter and outputter need to be replaced with this new formatter.

For static parser adapter, the outputter needs to be replaced with this new formatter.
Comment 4 Dave Smith CLA 2005-11-25 16:08:07 EST
To improve the performance of importing CommonBaseEvent XML Log files in the local case without filtering, the GLA can be take out of the operation.  Marius indicates the XML file can be read and loaded directly into the model using the XMLLoader.

To improve the performance of importing CommonBaseEvent XML Log files in the remote case without filtering, the Log Import Wizard can update the adapter file to make it as specified in 112558 (only Sensor and Outputter) and send it to the remote machine as it does now for the filtering case.
Comment 5 Valentina Popescu CLA 2005-11-30 10:57:16 EST
Theme: Scale up
Comment 6 Dave Smith CLA 2005-12-05 11:46:55 EST
For static parsers, instead of using the new formatter created in 117062, the LocalLogParserLoader can be changed to accept producer CommonBaseEvent objects and convert them directly into consumer CommonBaseEvent objects which are then loaded directly into the model.  This eliminates the serialization/deserialization to/from XML String steps.
Comment 7 Dave Smith CLA 2005-12-07 10:58:07 EST
Candidate for 4.2
Comment 8 Dave Smith CLA 2006-04-03 10:47:51 EDT
Deferring this to iteration 3 because it cannot be contained in iteration 2 and it does not have any UI impact.
Comment 9 Dave Smith CLA 2006-05-12 16:13:20 EDT
There is a change to the case related to the CommonBaseEvent XML log parser and defect 112558 that is mentioned in Comment #4.  112558 introduced a new outputter that accepts output from the sensor or extractor instead of CommonBaseEvent objects, thus eliminating the need for the SerializedCBEFormatter in the no-filter case.  Instead of having the Log Import Wizard update the adapter file to use this new outputter, the log import CommonBaseEvent XML Parser adapter file shipped with TPTP (regex.adapter) will be changed to include the new outputter.  Now the Log Import Wizard will only need to change the adapter file in the import with filter case (both local and remote) by replacing the new outputter with the SerializedCBEFormatter component plus the old outputter (org.eclipse.hyades.logging.adapter.config.outputters.StaticParserOutputter).  By doing this, forward compatibility will be maintained (importing with a 4.2 client and pre 4.2 RAC).  I'll attach the old and new adapter files so you can see what needs to be replaced in the new adapter to make it the same as the old one to add the filter blade to.
Comment 10 Dave Smith CLA 2006-05-12 16:17:16 EDT
Created attachment 41374 [details]
Old CommonBaseEvent XML Log parser adapter

Old CommonBaseEvent XML Log parser adapter to be used for the import with filter case.
Comment 11 Dave Smith CLA 2006-05-12 16:28:25 EDT
Created attachment 41375 [details]
New CommonBaseEvent XML Log Parser adapter file

New CommonBaseEvent XML Log parser adapter file to be used in the no-filter case for remote log import.  This one will be packaged with TPTP 4.2.
Comment 12 Alex Nan CLA 2006-05-13 20:46:21 EDT
Functionality delivered.
Comment 13 Praful Rajawat CLA 2006-09-25 16:49:37 EDT
added in cc list.
Comment 14 Dave Smith CLA 2006-09-27 02:42:39 EDT
The changes made for this feature are those indicated in the Design Summary section of the description document linked from the URL field above, except for the last sentence. The change to improve local log import of CommonBaseEvent XML log files by removing the GLA from the scenario was not made.
Comment 15 Paul Slauenwhite CLA 2009-06-30 12:21:58 EDT
As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since this enhancement/defect has been resolved and unverified for more than 1 year and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open.