Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 116197

Summary: [Help] Help window for dialogs is very small
Product: [Eclipse Project] Platform Reporter: Tobias Schwarz <tobias.schwarz>
Component: User AssistanceAssignee: Curtis d'Entremont <curtispd>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: billy.biggs
Version: 3.1   
Target Milestone: 3.2 M6   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
patch none

Description Tobias Schwarz CLA 2005-11-14 04:18:37 EST 
when i open a help window out of a displayed dialog, eg. by pressing F1, the 
help window is placed right to the dialog with the same hight as the parent 
dialog.

when doing this with very small dialogs, eg. an error dialog with an extended 
help feature, the help window is to small to be able to read the text.
the user first has to resize the help window.

is there any possibility to give a minimum hight to the opening help window?
perhaps the help window itself should have a minimum hight and so it is 
getting a little bit higher than a very small dialog.
Comment 1 Curtis d'Entremont CLA 2005-11-18 15:12:42 EST 
Will be doing some work in this area for 3.2 so I'll take a look at this later 
on. Need to investigate our options for solving this one.. minimum height would 
work but wouldn't look very good, although I can't think of a better solution 
at the moment.
Comment 2 Dejan Glozic CLA 2006-01-25 11:46:02 EST 
Curtis, I think it should be a combination of minimum height and resizable style of the dialog. We should only show the tray:

IF the dialog is taller than the minimum height OR the dialog has resizable SWT style

When the dialog has resizable style, users can make the dialog taller to compensate. Otherwise, we should simply show the yellow sticky.

This should work for both F1 and the new help button/link we are adding.
Comment 3 Curtis d'Entremont CLA 2006-02-16 18:04:40 EST 
Created attachment 34884 [details]
patch

Here's the fix. Tray makes an attempt to bring the dialog height back to original. It will try to reduce the height by the same amount it was increased to fit the tray, unless the resulting height would be less than the original dialog height. In this case it will reduce no further than the original height. This can happen if, for example, you open the tray, make the dialog shorter, then close the tray. The resulting height will be the original.
Comment 4 Curtis d'Entremont CLA 2006-02-23 16:45:15 EST 
Applied.