| Summary: | [UI] Improve rendering of fixed project facets | ||
|---|---|---|---|
| Product: | [WebTools] Web Tools | Reporter: | Konstantin Komissarchik <konstantin> |
| Component: | Web Standard Tools | Assignee: | Konstantin Komissarchik <konstantin> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | deboer |
| Version: | 1.0 | Keywords: | Documentation |
| Target Milestone: | 1.5 RC2 | ||
| Hardware: | PC | ||
| OS: | Windows XP | ||
| See Also: | https://git.eclipse.org/r/107818 | ||
| Whiteboard: | |||
|
Description
Konstantin Komissarchik
*** Bug 117354 has been marked as a duplicate of this bug. *** It's too late to do this for 1.0. 1. Stopped rendering fixed facets in bold.
2. Added an overlay lock icon to visually designate fixed facets.
3. Stopped sorting fixed facets to the top. They are now intermixed with the rest of the facets.
4. When a user tries to deselect a fixed facet, added a message box that explains why they cannot do that: "Project facet {0} cannot be deselected. It is critical to the proper function of this project."
Fix released. The popup is a little disorienting. I like the "lock" overlay, though. Maybe the facets that have no de-install ability or are necessary for the project could have a grayed-out checkbox. Instead of a popup, could the description text of the wizard relay the information about why the facet can not be deselected? Then other information messages could be shown (e.g. you can't add that facet because a certain runtime does not support it, or you can't remove that facet because it has no de-install ability). Seems to me that this would be more in keeping with the convention of error messages in other wizards, such as when you have entered an empty project name. A fixed facet is not the same as a facet that has no uninstall capability. Fixed facets are those deemed by project creation wizard author as key to project's operation. Not only can they not be uninstalled after the project is created, but they cannot be deselected on project creation. The previous behavior was to not allow the checkbox to be unchecked. People found that confusing. Hence the dialog that explains why they cannot do that. The grayed out checkbox icon cannot be used as that icon represents partially selected categories of facets. closing New Gerrit change created: https://git.eclipse.org/r/107818 |