Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 114356

Summary:	[WorkbenchParts] PlaceholderFolderLayout does not honor WILD_CARD.
Product:	[Eclipse Project] Platform	Reporter:	venkataramana m <venkataramanam>
Component:	UI	Assignee:	Platform UI Triaged <platform-ui-triaged>
Status:	CLOSED WONTFIX	QA Contact:
Severity:	normal
Priority:	P5	CC:	bokowski, emoffatt
Version:	3.0	Keywords:	helpwanted
Target Milestone:	---
Hardware:	PC
OS:	Windows XP
Whiteboard:	stalebug

Description venkataramana m

2005-10-31 08:45:28 EST

In order to position views based on wild-card matching in a  
PlaceholderFolderLayout, PlaceholderFolderLayout::addPlaceholder(String 
viewId) does not check if viewId is a WILD_CARD expression whereas 
FolderLayout::addPlaceholder(String viewId) checks the same.

The code FolderLayout::addPlaceholder and 
PlaceholderFolderLayout::addPlaceholder is exactly the same except for one 
difference...i.e., FolderLayout checks if viewId is a wild-card expression 
like below...

if (viewId.indexOf(PartPlaceholder.WILD_CARD) == -1)

So I think it has been just been forgotten to update the code in 
PlaceholderFolderLayout.

This came out in one of our requirements where we want to create an invisible 
folder by means of IPlaceholderFolderLayout and then position some views at 
runtime (opened through some actions) at that place.

Thanks
~Venkat

Comment 1 venkataramana m

2005-11-08 05:58:38 EST

(In reply to comment #0)
> In order to position views based on wild-card matching in a  
> PlaceholderFolderLayout, PlaceholderFolderLayout::addPlaceholder(String 
> viewId) does not check if viewId is a WILD_CARD expression whereas 
> FolderLayout::addPlaceholder(String viewId) checks the same.
> The code FolderLayout::addPlaceholder and 
> PlaceholderFolderLayout::addPlaceholder is exactly the same except for one 
> difference...i.e., FolderLayout checks if viewId is a wild-card expression 
> like below...
> if (viewId.indexOf(PartPlaceholder.WILD_CARD) == -1)
> So I think it has been just been forgotten to update the code in 
> PlaceholderFolderLayout.
> This came out in one of our requirements where we want to create an 
invisible 
> folder by means of IPlaceholderFolderLayout and then position some views at 
> runtime (opened through some actions) at that place.
> Thanks
> ~Venkat

This seems to have been solved in Eclipse 3.1.1 release. We recently moved 
from Eclipse 3.0 and I checked the code and reran our plugins which involved 
the discrepancy.

Comment 2 Paul Webster

2006-09-28 15:17:08 EDT

Is this still a problem in 3.3?

PW

Comment 3 venkataramana m

2006-09-28 19:43:20 EDT

(In reply to comment #2)
> Is this still a problem in 3.3?
> 
> PW
> 

I had replied before saying it had been solved in Eclipse 3.1.1;
But I am not sure if it had refurfaced in 3.1.1; I am not much into Eclipse these days. So I cannot comment about the current status in 3.1.1.

Thanks
Venkat

Comment 4 Paul Webster

2006-09-28 21:08:14 EDT

Will re-check.

PW

Comment 5 Eclipse Webmaster

2019-09-06 16:12:46 EDT

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

Comment 6 Eclipse Genie

2022-02-10 01:16:43 EST

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.