| Summary: | Historical reference to test suite not deleted | ||||||
|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Ruth Lee <ruthdaly> | ||||
| Component: | TPTP | Assignee: | Joe Toomey <jptoomey> | ||||
| Status: | CLOSED FIXED | QA Contact: | |||||
| Severity: | critical | ||||||
| Priority: | P1 | CC: | dmorris, jkubasta, paulslau, sleeloy, smith | ||||
| Version: | unspecified | Keywords: | plan | ||||
| Target Milestone: | --- | Flags: | dmorris:
review+
|
||||
| Hardware: | PC | ||||||
| OS: | Windows 2000 | ||||||
| Whiteboard: | closed460 | ||||||
| Attachments: |
|
||||||
|
Description
Ruth Lee
Highly desirable and planned for this release, but not stop ship Prevents function from being used, but a work around is possible Cannot contain in TPTP V4.2.0 (i2). This occurs for all test types (e.g. JUnit, URL and manual). When generating reports, the behavior a test should be traversed and not the list of referenced test suites since this list is sometimes used as a cache for performance reasons. Although this defect is valid fro completeness, especially in the scenario when all referenced tests/test suites have been removed from a test suite's behaviour, it is not a high severity issue. Ruth, can we reduce the severity to normal? Reduced as per Paul's explanation. The intent of the referencedSuites element is to keep track of referenced test suites to make it easier to compute closure. For example, adding an invocation to test suite B from test suite A will add test suite B as a referenced suite for test suite A, unless test suite B is already referenced. However, when all references (test case and/or the test suite itself) to a test suite have been removed, the reference test suite should be removed. *** Bug 143875 has been marked as a duplicate of this bug. *** Cannot contain in TPTP V4.2.0 (i3). Retargeting to 4.3 per Paul's mailing list post and lack of dissent. Retargeting to 4.4 as decided in today's AG call (only permitting blocking and critical defects in 4.3 i3). Increasing severity since this defect impacts the test report use case. After investigating, this problem is localized to the org.eclipse.hyades.models.common.facades.behavioral.impl.HyadesBVRInteractionAdapter.notifyChanged(Notification) method. The Notification.REMOVE and Notification.REMOVE_MANY blocks of the switch statement never enters their conditional blocks that removes the referenced test suite since the ITestSuite test is always null. Transferring to Platfrom.Models. Joe please take a look at this defect. i2 is closed to new fixes, transferring to i3 Increasing severity since this defect is causing erroneous reports thereby breaking our test reporting. Joe, can you provide a fix for this in 4.4 i4? *** Bug 187884 has been marked as a duplicate of this bug. *** Can we have this issue addressed in 4.4.1? The TPTP Test Reports are continually impacted by this defect, causing the reported results to be skewed. *** Bug 187884 has been marked as a duplicate of this bug. *** Agreed. Targeting 4.4.1 (although we should also do the work for https://bugs.eclipse.org/bugs/show_bug.cgi?id=187242 which remove the use of this collection for report generation.) (In reply to comment #20) > Agreed. Targeting 4.4.1 (although we should also do the work for > https://bugs.eclipse.org/bugs/show_bug.cgi?id=187242 which remove the use of > this collection for report generation.) > I agree. I have targeted 187242 to 4.5, where we will be focusing on improving our reporting functionality. Attaching patch file. Reviewed with DuWayne. Created attachment 76714 [details]
Fix for Historical reference to test suite not deleted
I have reviewed this fix with Joe and approve for delivery. Fixed in 4.4.1 As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since this originator of this enhancement/defect has an inactive Bugzilla account and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open. As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since this originator of this enhancement/defect has an inactive Bugzilla account and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open. |