Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 113590

Summary: Historical reference to test suite not deleted
Product: z_Archived Reporter: Ruth Lee <ruthdaly>
Component: TPTPAssignee: Joe Toomey <jptoomey>
Status: CLOSED FIXED QA Contact:
Severity: critical    
Priority: P1 CC: dmorris, jkubasta, paulslau, sleeloy, smith
Version: unspecifiedKeywords: plan
Target Milestone: ---Flags: dmorris: review+
Hardware: PC   
OS: Windows 2000   
Whiteboard: closed460
Attachments:
Description Flags
Fix for Historical reference to test suite not deleted none

Description Ruth Lee CLA 2005-10-24 16:29:24 EDT
When you turn to the "Behavior" tab of the test editor and remove an invocation,
the corresponding reference is not deleted in the test suite, e.g. 
  <referencedSuites
href="statcon/SAUAddSliders.testsuite#29AF1B000EC611D88000B854F1AF5017"/>

In
test-results\platform\org.eclipse.hyades.statistical.ui.tests\manual\AllTests.testsuite.

To reproduce the problem, pick any manual test suite, turn to the "Behaviors"
tab  and delete an invocation. Then open the test suite using Winzip, scroll to
the bottom of ResourceContents and confirm that the reference was not removed.

I'll work around this by coding the tabular test report to ignore test suites
with null names. I believe that Jerome has already worked around this for the
build-in test reports.
Comment 1 Paul Slauenwhite CLA 2005-10-24 16:58:07 EDT
Highly desirable and planned for this release, but not stop ship
Prevents function from being used, but a work around is possible
Comment 2 Paul Slauenwhite CLA 2006-04-03 14:55:29 EDT
Cannot contain in TPTP V4.2.0 (i2).
Comment 3 Paul Slauenwhite CLA 2006-04-06 11:36:07 EDT
This occurs for all test types (e.g. JUnit, URL and manual).
Comment 4 Paul Slauenwhite CLA 2006-04-09 16:23:51 EDT
When generating reports, the behavior a test should be traversed and not the list of referenced test suites since this list is sometimes used as a cache for performance reasons.  Although this defect is valid fro completeness, especially in the scenario when all referenced tests/test suites have been removed from a test suite's behaviour, it is not a high severity issue. 

Ruth, can we reduce the severity to normal?
Comment 5 Ruth Lee CLA 2006-04-10 10:28:31 EDT
Reduced as per Paul's explanation.
Comment 6 Paul Slauenwhite CLA 2006-05-02 15:03:03 EDT
The intent of the referencedSuites element is to keep track of referenced test suites to make it easier to compute closure.  For example, adding an invocation to test suite B from test suite A will add test suite B as a referenced suite for test suite A, unless test suite B is already referenced.  However, when all references (test case and/or the test suite itself) to a test suite have been removed, the reference test suite should be removed.
Comment 7 Paul Slauenwhite CLA 2006-05-26 09:35:10 EDT
*** Bug 143875 has been marked as a duplicate of this bug. ***
Comment 8 Paul Slauenwhite CLA 2006-06-01 13:39:54 EDT
Cannot contain in TPTP V4.2.0 (i3).
Comment 9 Joe Toomey CLA 2006-07-31 11:08:42 EDT
Retargeting to 4.3 per Paul's mailing list post and lack of dissent.
Comment 10 Paul Slauenwhite CLA 2006-10-20 16:08:38 EDT
Retargeting to 4.4 as decided in today's AG call (only permitting blocking and critical defects in 4.3 i3).
Comment 11 Paul Slauenwhite CLA 2007-02-07 11:34:06 EST
Increasing severity since this defect impacts the test report use case.
Comment 12 Paul Slauenwhite CLA 2007-02-07 13:23:27 EST
After investigating, this problem is localized to the org.eclipse.hyades.models.common.facades.behavioral.impl.HyadesBVRInteractionAdapter.notifyChanged(Notification) method.  The Notification.REMOVE and Notification.REMOVE_MANY blocks of the switch  statement never enters their conditional blocks that removes the referenced test suite since the ITestSuite test is always null.

Transferring to Platfrom.Models.
Comment 13 Marius Slavescu CLA 2007-03-26 10:15:07 EDT
Joe please take a look at this defect.
Comment 14 Joe Toomey CLA 2007-03-26 10:21:06 EDT
i2 is closed to new fixes, transferring to i3
Comment 15 Paul Slauenwhite CLA 2007-03-30 10:59:20 EDT
Increasing severity since this defect is causing erroneous reports thereby breaking our test reporting.  
Comment 16 Paul Slauenwhite CLA 2007-05-18 15:03:18 EDT
Joe, can you provide a fix for this in 4.4 i4?
Comment 17 Paul Slauenwhite CLA 2007-05-18 15:03:34 EDT
*** Bug 187884 has been marked as a duplicate of this bug. ***
Comment 18 Paul Slauenwhite CLA 2007-06-29 06:12:03 EDT
Can we have this issue addressed in 4.4.1?  The TPTP Test Reports are continually impacted by this defect, causing the reported results to be skewed.
Comment 19 Paul Slauenwhite CLA 2007-06-29 07:52:29 EDT
*** Bug 187884 has been marked as a duplicate of this bug. ***
Comment 20 Joe Toomey CLA 2007-06-29 09:36:27 EDT
Agreed.  Targeting 4.4.1 (although we should also do the work for https://bugs.eclipse.org/bugs/show_bug.cgi?id=187242 which remove the use of this collection for report generation.)
Comment 21 Paul Slauenwhite CLA 2007-06-29 09:43:38 EDT
(In reply to comment #20)
> Agreed.  Targeting 4.4.1 (although we should also do the work for
> https://bugs.eclipse.org/bugs/show_bug.cgi?id=187242 which remove the use of
> this collection for report generation.)
> 

I agree.  I have targeted 187242 to 4.5, where we will be focusing on improving our reporting functionality.
Comment 22 Joe Toomey CLA 2007-08-22 17:12:41 EDT
Attaching patch file.  Reviewed with DuWayne.
Comment 23 Joe Toomey CLA 2007-08-22 17:13:29 EDT
Created attachment 76714 [details]
Fix for Historical reference to test suite not deleted
Comment 24 DuWayne Morris CLA 2007-08-22 17:51:44 EDT
I have reviewed this fix with Joe and approve for delivery.
Comment 25 Joe Toomey CLA 2007-08-22 20:31:37 EDT
Fixed in 4.4.1
Comment 26 Paul Slauenwhite CLA 2009-06-30 09:50:07 EDT
As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since this originator of this enhancement/defect has an inactive Bugzilla account and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open.
Comment 27 Paul Slauenwhite CLA 2009-06-30 09:52:58 EDT
As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since this originator of this enhancement/defect has an inactive Bugzilla account and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open.