Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 113171

Summary: No error message when Logging Agent Outputter fails to communicate with Agent Controller
Product: z_Archived Reporter: Dave Smith <smith>
Component: TPTP.monitoringAssignee: Cindy Jin <jx_china>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P1 Keywords: plan
Version: unspecified   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard: closed460
Bug Depends on: 113173    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
patch file none

Description Dave Smith CLA 2005-10-19 18:33:41 EDT 
When attempting to do live monitoring of a log file using standalone GLA 
configured with a Logging Agent Outputter (CBELogOutputter), there is no error 
message issued if the Agent Controller DLL's are not accessible to the GLA 
process.  The GLA just hangs waiting for the logging agent to register with 
Agent Controller and be monitored.  Standalone GLA should exit with an error 
message or log an error message in this case so the user knows what is wrong.
Comment 1 Dave Smith CLA 2005-10-19 18:41:20 EDT 
The org.eclipse.hyades.logging.adapter.outputters.CBELogOutputter.update() 
method creates an org.eclipse.hyades.logging.core.LoggingAgent object but there 
is no exception thrown by the LoggingAgent constructor or way of determining 
that the agent cannot communicate with the Agent Controller.  Without changes 
to LoggingAgent there is now way CBELogOutputter can return an error for this 
case.
Comment 2 Dave Smith CLA 2005-10-19 23:53:42 EDT 
Deferring this to 4.2 because 113173 is targetted to 4.2.
Comment 3 Dave Smith CLA 2005-10-19 23:54:56 EDT 
It is desireable for the CBELogOutputter.update method to throw an exception if 
the Agent Controller is unavailable.
Comment 4 Dave Smith CLA 2005-10-20 01:55:03 EDT 
Created attachment 28497 [details]
Patch

This patch assumes bugzilla 113173 is fixed as I suggested.
Comment 5 Dave Smith CLA 2005-11-30 16:50:30 EST 
A readme item is added for this in 4.1 Release notes - see https://bugs.eclipse.org/bugs/show_bug.cgi?id=118710.
Comment 6 Dave Smith CLA 2006-06-05 10:36:44 EDT 
Deferring to 4.3 because the required bugzilla 113173 is being deferred.
Comment 7 Dave Smith CLA 2006-10-20 18:26:50 EDT 
Cannot be contained in 4.3 - deferring to 4.4.  Increasing priority because 113171 was implemented in 4.3.
Comment 8 Dave Smith CLA 2007-02-06 02:46:49 EST 
Targetting to complete in i2 and reassigning to Cindy.
Comment 9 Cindy Jin CLA 2007-03-22 17:04:11 EDT 
Created attachment 61748 [details]
patch file

Dave, I created the patch based on the patch you attached before. Please review it. Thanks
Comment 10 Dave Smith CLA 2007-03-27 10:50:32 EDT 
Deferring this to iteration 3 because it was too late to integrate this patch into iteration 2.  I did not want to risk a regression.  Note, the new message is already in the properties file in CVS.  It was added in a previous release.
Comment 11 Dave Smith CLA 2007-04-23 01:44:05 EDT 
Committed fix to TPTP Head CVS.  Made a small change to the patch submitted by Cindy.  I moved the !cbelogger.isAgentControllerAvailable() test inside the if (cbelogger == null && !validating && !isDisabled()) block so it is not executed when the outputter is disabled.

I also changed the default outputter in the GLA Editor to be the LogImportEditor from CBELogOutputter because CBELogOuputter now throws an exception which would make it difficult to test new adapters in the editor.
The changed editor files were:
org.eclipse.hyades.logging.adapter.ui.internal.presentation.AdaptorModelWizard
org.eclipse.hyades.logging.adapter.ui.extension.internal.impl.ContextInstanceProvider
Comment 12 Paul Slauenwhite CLA 2009-06-30 09:53:00 EDT 
As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since this originator of this enhancement/defect has an inactive Bugzilla account and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open.