Bugzilla – Full Text Bug Listing
| Summary: | Provide mechanisms for adding and launching new statistical agents | ||||||
|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Erik Putrycz <erik.putrycz> | ||||
| Component: | TPTP.monitoring | Assignee: | George Christelis <george.christelis> | ||||
| Status: | CLOSED FIXED | QA Contact: | |||||
| Severity: | enhancement | ||||||
| Priority: | P1 | CC: | guru.nagarajan, jnorris, karla.callaghan | ||||
| Version: | unspecified | Keywords: | Documentation, plan | ||||
| Target Milestone: | --- | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| URL: | http://www.eclipse.org/tptp/groups/Architecture/documents/features/hf_113166.html | ||||||
| Whiteboard: | closed460 | ||||||
| Attachments: |
|
||||||
Created attachment 29136 [details]
new Extension point
This patch creates a new extension point + schema in the
org.eclipse.hyades.perfmon for registering the Statistical Agents User
Interfaces. I refactored the existing code for using this extension point and
remove all references to existing agents. I had to add some other code for
managing the icons from the new schema.
Thanks Erik. So far I've written a feature doc for this enhancement, but I need to wait for it to get authorized and placed into plan before any design work can begin. Theme: Design for Extensibility: Be a Better Platform I just had a look at the document. In my patch, the ACAgentName, the UI Agent Name and the UI Agent Image are in the plugin properties for the extention point. This really simplifies the interface to implement and reduces it to:
public boolean isValid(ILaunchConfiguration conf);
public String getErrorMessage();
public AgentVariable [] getVariables();
In the patch and the current code, variable names, default and current values are handled by different methods. Are these stored in the AgentVariable?
Also shouldn't the AgentInterface move out of the "internal" package if it will be the main external interface?
Erik, I've restructed and cleaned up the code in the internal code in the org.eclipse.hyades.perfmon plugin. I've left the extension point as internal as there are going to be some discussions here to see if this coincides with our support for statistical agents on all the ACs. I think that it will become public however, in which case the org.eclipse.hyades.perfmon.internal.agentextension package will be exposed, allow with the extension schema. Tell me what you think of the interfaces and classes in that package, and if any further work should be done to clean the API up. Checked changes into 4.2 CVS - org.eclipse.hyades.perfmon This bug is marked as resolved, but the extension point is still internal. Please take this work the rest of the way and make it possible for users like me to add new statistical agents. It's not clear that there's even a reasonable workaround for adding new statistical agents right now. Thanks! Also, it would be great if there was some basic documentation on how one would go about writing a new statistical agent. Is there a document out there that I've missed? As of TPTP 4.6.0, TPTP is in maintenance mode and focusing on improving quality by resolving relevant enhancements/defects and increasing test coverage through test creation, automation, Build Verification Tests (BVTs), and expanded run-time execution. As part of the TPTP Bugzilla housecleaning process (see http://wiki.eclipse.org/Bugzilla_Housecleaning_Processes), this enhancement/defect is verified/closed by the Project Lead since this enhancement/defect has been resolved and unverified for more than 1 year and considered to be fixed. If this enhancement/defect is still unresolved and reproducible in the latest TPTP release (http://www.eclipse.org/tptp/home/downloads/), please re-open. |
The current list of statistical agents is hardcoded in the class org.eclipse. hyades.perfmon.common.internal.launch.StatisticalAgentTabGroup: static { agentTabList.add(new PerfmonTabInterface()); agentTabList.add(new LinuxTabInterface()); agentTabList.add(new JBossTabInterface()); agentTabList.add(new JonasTabInterface()); agentTabList.add(new ApacheTabInterface()); agentTabList.add(new MySQLTabInterface()); } this should be refactored with extension points to allow third parties to implement new statistical agents. I'd be willing to contribute on this.