Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 112884

Summary: Get rid of XSDTextEditor (no subclassing of StructuredTextEditor allowed)
Product: [WebTools] WTP Source Editing Reporter: Amy Wu <for.work.things>
Component: wst.xsdAssignee: Keith Chong <keith.chong.ca>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: jgowder
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Bug Depends on:    
Bug Blocks: 103556, 112885    
Attachments:
Description Flags
Attempted fix for this bug.
none
org.eclipse.wst.xsd.ui.patch none

Description Amy Wu CLA 2005-10-17 19:31:48 EDT 
StructuredTextEditor does not allow subclassing.  WTP should set a better
example by not having any subclasses of StructuredTextEditor in it.  Clients
should try to use the editor configurations and other hooks.  If more is needed
of StructuredTextEditor, clients can open bugs requesting more extensibility.

For now, the easiest solution may be to move all function of XSDTextEditor into
XSDEditor since there is really no such thing as an XSD Source Page editor and
XSDEditor can have more control.
Comment 1 Keith Chong CLA 2005-10-20 12:07:08 EDT 
Created attachment 28524 [details]
Attempted fix for this bug.

Still need to add text editor and content outline configuration
Resolve issue with open on and the refactor actions that were added via the
XSDTextEditor.
Thanks a bunch Amy
Comment 2 Amy Wu CLA 2005-10-26 13:59:47 EDT 
Created attachment 28810 [details]
org.eclipse.wst.xsd.ui.patch

This patch includes the previously attached patch.
I added the code to use the editorconfiguration framework
(contentoutlineconfiguration, sourceviewerconfiguration) and the hyperlink
navigation framework.

Files added:
-StructuredTextViewerConfigurationXSD
-XSDContentOutlineConfiguration
-XSDHyperlink
-XSDHyperlinkDetector

Several files modified.

Files deprecated (and should be deleted if no one is using):
XSDContentOutlinePage - replaced by ConfigurableOutlinePage &
XSDContentOutlineConfiguration
XSDTextEditor - replaced by StructuredTextEditor
Comment 3 Amy Wu CLA 2005-10-26 14:03:28 EDT 
Assigning to Keith to apply patches if he sees fit.  Thanks.

Remaining TODOs:
-Delete XSDTextEditor & XSDContentOutlinePage if no one else is referencing them
(Keith, maybe just check in once with deprecation in CVS history, then delete)

-Get refactor actions back into source page.  I ran into some issues with this.
 I'll open a new bug for this since I don't want to hold up the rest of this
bug.  And post the bug number back in this bug.
Comment 4 Amy Wu CLA 2005-10-26 14:14:58 EDT 
Bug 113864 was open for adding refactor actions back into xsd source page.
Comment 5 Keith Chong CLA 2005-11-01 11:30:09 EST 
Amy, the patch looks good.  There were some
outline view selection problems that I fixed.
(ie. For add action, we want the newly added item to be selected)
I also added back the filter actions on the drop
down menu of the outline.

This was checked in yesterday.
Comment 6 Keith Chong CLA 2005-11-01 11:37:47 EST 
I'll add the remaining TODO's to the other bug.
Comment 7 Keith Chong CLA 2005-11-08 11:04:27 EST 
*** Bug 112720 has been marked as a duplicate of this bug. ***
Comment 8 Amy Wu CLA 2005-12-12 18:56:15 EST 
verified in wtp 1.0 rc3 code that xsdtexteditor no longer exists.
Comment 9 John Lanuti CLA 2006-11-28 15:39:21 EST 
This is part of a mass update to close out all stale WTP defects already verified by the reporter but awaiting closure by the assignee.  If you feel this defect was closed inappropriately, please reopen.

Thanks, John Lanuti