Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 112822

Summary:	[WorkbenchParts] setInputWithNotify not easily adopted
Product:	[Eclipse Project] Platform	Reporter:	Randy Hudson <hudsonr>
Component:	UI	Assignee:	Paul Webster <pwebster>
Status:	RESOLVED DUPLICATE	QA Contact:
Severity:	major
Priority:	P4	CC:	michaelvanmeekeren
Version:	3.2
Target Milestone:	---
Hardware:	PC
OS:	Windows XP
Whiteboard:

Description Randy Hudson

2005-10-17 13:17:35 EDT

subclasses normally call super() right away when extending a method. In this
case the notification of input changed would occur before the subclass has done
its normal processing of the new input.

If the subclass calls super() last, any methods it calls before that will not
have access to the new input, since super sets the field.

Comment 1 Randy Hudson

2005-10-17 14:51:11 EDT

The other problem I am having with this method is that it doesn't call the old 
method. So, if I have an editor that is currently calling setInput, I need to 
switch to calling the new method, and I need to override setInputandNotify() to 
call setInput() in case subclasses have extended the old method.

Comment 2 Michael Van Meekeren

2005-10-17 15:18:17 EDT

to keep things organized, I suggest that this bug should be marked as a dup ...
the comments are in the same vein and should be together.

*** This bug has been marked as a duplicate of 110285 ***