Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 111879

Summary:

[XML Catalog] Add XML Catalog Entry missing text on URI "browse" button

Product:

[WebTools] WTP Source Editing

Reporter:

Nitin Dahyabhai <thatnitind>

Component:

wst.xml

Assignee:

Gabriel Indik <gindik>

Status:

CLOSED FIXED

QA Contact:

Nitin Dahyabhai <thatnitind>

Severity:

enhancement

Priority:

CC:

david_williams, keith.chong.ca, nsand.dev, valentinbaciu

Version:

1.0

Flags:

keith.chong.ca: review+

Target Milestone:

3.1 M4

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
Patch	valentinbaciu: iplog+
Screen shot	none
Patch	valentinbaciu: iplog+

Description Nitin Dahyabhai

2005-10-07 04:03:44 EDT

Pressing the Add button on the XML Catalog Preference page opens a dialog.  I'm
not sure about the Outlook-ish appearance (it doesn't look similar to anything
else in WTP), but the Catalog Entry... thing... has a "URI" field with a
textless button to the right of it.  Is this screen readable for disabled users?
 Shouldn't it just have a "Browse" label like everywhere else?

Comment 1 David Williams

2006-03-28 02:59:13 EST

Craig, will you please triage and/or re-assign these bugs that were assigned to Ella?

Comment 2 Valentin Baciu

2008-11-05 11:34:21 EST

Let's look at other places in the platform where the user can choose from a workspace or file system location. 
At a minimum we could have two buttons if needed...

Gabriel, let's try to look into this for 3.1.

Comment 3 Gabriel Indik

2008-11-17 15:51:03 EST

Created attachment 118091 [details]
Patch

The following patch changes the interface to match that of other places in the platform that provide browsing for files in the workspace and file system. The solution consists of two buttons placed next to the lower-right corner of the resource field, one for browsing the workspace, the other for browsing the file system.

Comment 4 Gabriel Indik

2008-11-17 15:52:43 EST

Created attachment 118092 [details]
Screen shot

The attached image shows how the dialog box is displayed with the patch applied.

Comment 5 Keith Chong

2008-12-10 14:58:58 EST

I tested this out: I imported and exported catalogs, and specified to entries from the workspace and external filesystem.  Looks good.

One minor thing I changed was that I made the buttons non-flat, since the other buttons in the dialog and the combo-box are non-flat.

Released for 3.1 M4.

Comment 6 Nitin Dahyabhai

2008-12-17 15:05:22 EST

Verified with S-3.1M4-20081215095735, much better.

Comment 7 Valentin Baciu

2009-01-19 14:12:45 EST

Gabriel, the two buttons seem to be missing shortcut keys (accelerators).

Comment 8 Gabriel Indik

2009-01-21 11:47:03 EST

Created attachment 123251 [details]
Patch

I revised the XML catalog dialog boxes and there were several controls that were missing shortcut keys. This patch addresses this problem by including the necessary shortcut keys.
A quick glance at other parts of the tooling including the XML, XSD and WSDL editors, XML generator and preferences (including validation) revealed there are many places where shortcut keys are missing. It would be a good idea to centralize the effort on ensuring shortcuts are properly used across all tools.

Comment 9 Valentin Baciu

2009-01-25 16:22:21 EST

Second patch released for WTP 3.1 builds > v200901252121 UTC.

Comment 10 Nick Sandonato

2009-02-05 16:30:46 EST

Verified in S-3.1M5-20090205031422.

Comment 11 Valentin Baciu

2009-02-06 14:52:23 EST

Closing.