Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 111635

Summary:	[Preferences] Incorrect documentation in StringFieldEditor.valueChanged()
Product:	[Eclipse Project] Platform	Reporter:	Martin Oberhuber <mober.at+eclipse>
Component:	UI	Assignee:	Platform UI Triaged <platform-ui-triaged>
Status:	CLOSED WONTFIX	QA Contact:
Severity:	normal
Priority:	P5	Keywords:	helpwanted
Version:	3.1
Target Milestone:	---
Hardware:	PC
OS:	Windows XP
Whiteboard:	stalebug

Description Martin Oberhuber

2005-10-05 12:01:09 EDT

The Javadoc of StringFieldEditor.valueChanged() says:

  "This hook is <em>not</em> called when the text is initialized 
   (or reset to the default value) from the preference store."

but StringFieldEditor.doLoadDefault() calls valueChanged().

In general, it appears that the various field editors are not always consistent
with respect to whether a Property Changed event is fired on doLoad() or
doLoadDefault() or not. Partially, it appears that the ModifyListener attached
to the UI control leads to firing the event on loading the field editor.

In my opinion, it might be helpful to change the behavior such that a property
change event *is* sent on doLoad() or doLoadDefault(), because this would allow
clients to update enablement of other GUI controls on the same page due to the
loading. Currently, this must be done in the performOk() or performDefaults()
method of the Preference page.

Comment 1 Susan McCourt

2009-07-09 19:27:43 EDT

As per http://wiki.eclipse.org/Platform_UI/Bug_Triage_Change_2009

Comment 2 Eclipse Webmaster

2019-09-06 16:18:04 EDT

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

Comment 3 Eclipse Genie

2022-01-02 07:35:34 EST

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.