Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 111478

Summary:	[Markers] applying Quick Fix on multi-selection needs to be cancelable
Product:	[Eclipse Project] Platform	Reporter:	Dani Megert <daniel_megert>
Component:	IDE	Assignee:	Platform UI Triaged <platform-ui-triaged>
Status:	RESOLVED WORKSFORME	QA Contact:	Hitesh <hsoliwal>
Severity:	normal
Priority:	P3	CC:	martinae
Version:	3.2	Keywords:	helpwanted
Target Milestone:	---
Hardware:	PC
OS:	Windows XP
Whiteboard:

Description Dani Megert

2005-10-04 12:08:48 EDT

I20051004-0800

Having the possibility to quick fix multiple problems at once (bug 23889) is
great. However, it can cause problems if a Quick Fix opens a dialog and many
such problems are selected: in such situations there's no way for the user to
cancel the operation, he has to click through all of them or kill Eclipse.

There should be a UI that allows to step through the problems/quick fixes and
also cancel them.

Comment 1 Tod Creasey

2005-10-04 16:12:35 EDT

Dani currently selecting cancel stops the operation. Are you looking for a
"skip" option so that you can continue on?

Comment 2 Dani Megert

2005-10-05 02:57:38 EDT

>Dani currently selecting cancel stops the operation.
Tod, I have to disagree:
Cancelation only works if there's more than one quick fix for a particular
problem because then your new dialog comes into play. If there's just one quick
fix for each selected problem and that quick fix opens a dialog then canceling
that dialog (if possible at all) simply results in the next problem being processed.

Test Case: create a class with many discouraged access problems and try to fix
them at once.

Here's what would be good to have:
- allow to cancel the whole operation
- allow to skip/ignore the current problem type for the rest of the operation
- allow to skip/ignore further problems in same file

It might be a good idea to delegate the set of same (even similar?) problem
types at once to a resolver (extend current API/extension point). It could then
ask relevant questions only once instead of opening the same dialog for each
quick fix of the same problem type.

Comment 3 Martin Aeschlimann

2005-10-05 04:03:23 EDT

I filed bug 111567 against the auto-apply feature in general. Also in the single
selection case, I think the user should always have a chance to know what the
fix is and to cancel it.

Comment 4 Susan McCourt

2009-07-15 12:16:36 EDT

"As per http://wiki.eclipse.org/Platform_UI/Bug_Triage_Change_2009"

Comment 5 Hitesh

2010-04-09 07:27:07 EDT

Problems view has seen several changes since 3.2. The quick fix enables only for single selection now. No longer relevant (3.4+), marking as WORKSFORME.