Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 111068

Summary: WI9: Add JFace and SWT plugins to the Agent Controller installation/configuration.
Product: z_Archived Reporter: Paul Slauenwhite <paulslau>
Component: TPTPAssignee: Paul Slauenwhite <paulslau>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P1 CC: hkyleung, samwai
Version: unspecified   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:
Bug Depends on:    
Bug Blocks: 74841    

Description Paul Slauenwhite CLA 2005-09-29 10:22:03 EDT
WI9: Add JFace and SWT plugins to the Agent Controller 
installation/configuration.

As a result of feature #74841, the following plug-ins are required in the Agent 
Controller installation for the new RCP/SWT-based Manual Test Client:

-org.eclipse.jface*
-org.eclipse.swt
-org.eclipse.core.commands*

*Require exiting org.eclipse.core.runtime plugin.

Note: This defect covers work item 9 of enhancement #74841 
(https://bugs.eclipse.org/bugs/show_bug.cgi?id=74841) to provide a RCP/SWT-
based Manual Test Client to replace the existing Swing-based Manual Test Client.

P1 Cannot ship without this enhancement 
normal A problem making a function difficult to use but no special work around 
is required
Comment 1 Hubert Leung CLA 2005-10-03 17:59:18 EDT
In build TPTP-4.1.0-200510031701, I have add 
org.eclipse.core.commands_3.1.0.jar, org.eclipse.jface_3.1.0.jar, and swt.jar.  
The swt.jar is platform specific.  

The next step is to change the main SetConfig.java file to include these 3 
files in the classpath.  I am assigning this bug to Samson to get it done.

When I discussed this bug with Samson last week, he said changes may also be 
needed in the SetConfig.java of the test plugin.  Paul, please work with Samson 
to understand how the configuration works.  
Comment 2 Paul Slauenwhite CLA 2005-10-04 08:17:20 EDT
These Eclipse plugins should be packaged as separate Agent Controller plugins 
in the <Agent Controller>/plugins directory and added to the Agent Controller's 
default AgentControllerEnvironment in the <Agent 
Controller>/config/serviceconfig.xml file.  Finally, the HyadesTestingSession 
application in th <Agent 
Controller>/plugins/org.eclipse.hyades.test.tools.core/config/pluginconfig.xml 
file will be changed to reference the new SWT/JFace plugins.

Comment 3 Samson Wai CLA 2005-10-05 10:40:34 EDT
Just want to confirm that the actual plugin ID's are:
org.eclipse.core.commands
org.eclipse.jface
org.eclipse.swt

So I will need to set the following env vars in the main serviceconfig.xml:
CLASSPATH_ORG_ECLIPSE_CORE_COMMANDS = org.eclipse.core.commands_3.1.0.jar
CLASSPATH_ORG_ECLIPSE_JFACE = org.eclipse.jface_3.1.0.jar
CLASSPATH_ORG_ECLIPSE_SWT = swt.jar

Then the test client's config will need to reference these env vars in its own
pluginconfig.xml file.
Comment 4 Paul Slauenwhite CLA 2005-10-05 12:08:22 EDT
(In reply to comment #3)

Yes.  Keep in mind that the SWT JAR is platform dependant.
Comment 5 Samson Wai CLA 2005-10-05 13:46:34 EDT
Ok. I have checked the fix into CVS to add those "CLASSPATH_" variables to the
main serviceconfig.xml. So what's left to be done is to reference them from the
manual test client's pluginconfig.xml.
Comment 6 Paul Slauenwhite CLA 2005-10-05 14:28:37 EDT
(In reply to comment #5)

Please reassign to me.
Comment 7 Paul Slauenwhite CLA 2005-10-05 19:29:58 EDT
Required configuration for the org.eclipse.hyades.test.tools.core plugin:

<Variable name="CLASSPATH" position="append" value="%
CLASSPATH_ORG_ECLIPSE_CORE_COMMANDS%"/>
<Variable name="CLASSPATH" position="append" value="%
CLASSPATH_ORG_ECLIPSE_JFACE%"/>
<Variable name="CLASSPATH" position="append" value="%
CLASSPATH_ORG_ECLIPSE_SWT%"/>

However, the native SWT libraries (e.g. swt-win32-3138.dll DLL for Windows) 
needs to be on the PATH.
Comment 8 Samson Wai CLA 2005-10-06 11:22:16 EDT
Paul, please assign this to Hubert so that the SWT DLL can be packaged into the
RAC's "bin" (or "lib" for linux/unix) dir. It will be picked up the same way as
other RAC DLLs.
Comment 9 Paul Slauenwhite CLA 2005-10-07 18:27:09 EDT
org.eclipse.hyades.test.tools.core.SetConfig.java checked in to TPTP CVS (HEAD) 
on October 7, 2005.
Comment 10 Paul Slauenwhite CLA 2005-10-17 17:09:49 EDT
Verified in TPTP_v4_1_0_200510140100.