Bugzilla – Full Text Bug Listing
| Summary: | [Progress] Progress infrastructure jobs should not be shown in progress view | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | John Arthorne <john.arthorne> | ||||
| Component: | UI | Assignee: | Platform UI Triaged <platform-ui-triaged> | ||||
| Status: | CLOSED WONTFIX | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | david_williams, deboer, igor, Michael.Valenta, thatnitind | ||||
| Version: | 3.1 | Keywords: | helpwanted | ||||
| Target Milestone: | --- | ||||||
| Hardware: | PC | ||||||
| OS: | Windows 2000 | ||||||
| Whiteboard: | stalebug | ||||||
| Bug Depends on: | 139254 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
John Arthorne
Created attachment 27559 [details]
System jobs staying in progress view
The update progess job will always be there looking at system jobs. You need to remove completed tasks for the other one I have to reopen this one... It's still easy to reproduce, and "Remove All Finished Operations" does *not* remove completed system jobs from the view. Also, since these jobs don't use KEEP the user shouldn't need to remove them from the view manually. *** Bug 139155 has been marked as a duplicate of this bug. *** I've already duped at least 2 defects in WTP to this problem; since I don't see the other dups here I think there is another bug open for this as well. This probem still exists in 3.2 and we see it fairly frequently in WTP. Is there anything we can do to help resolve it (traces?), and otherwise is there anything that we can do to try to avoid this behaviour with our jobs? Tim is this just happening with System Jobs for you? There may be other cases, but here is the one I can reproduce easily: 1) Start a workbench with the org.eclipse.ui.examples.job plugin installed. 2) Open the Job Factory and Progress View 3) Change the progress view preference to show sleeping and system jobs 4) In the job factory, set Duration to "1 second", reschedule delay to "30000", and select "reschedule" and "system job" 5) Click "Create jobs" -> When the job finishes, you see an entry that looks like this: Test Job (finished) OK If you click "Remove all finished operations" it does not go away, despite the fact that it says "finished" in the view. However, this case is subtle. The job should still be in the view, because it is now in the "sleeping" state. However, the title needs to be changed from "Finished" to "sleeping" to accurately reflect the state of the job. John see Bug 113400 for your issue We should only show the jobs to update animations and progress when a debug option is set in the .options file. It is not usueful information for people debugging thier own system jobs I don't think my issue is bug 113400. The problem I describe in comment #0 and comment #7 is that if the job changes from the "finished" to "sleeping" state, then the job still says "finished". I just used the "updating progress" job as an example, but the same problem occurs for any system job. Sorry John I meant 139254. Ok, that makes sense. Changing the title back to what you had set it to. I just debugged one instance of this problem in WTP and think I know what is going on. In WTP, they call IProgressMonitor.isCanceled (ProgressManager$JobMonitor.isCanceled, to be more specific) *after* the job has finished and has been removed from ProgressManager.jobs map. JobMonitor.isCanceled, however, calls into getJobInfo(Job) which adds the job back to the jobs map. I have steps to reproduce this problem 100% in WTP if you are interested. (In reply to comment #13) > I have steps to reproduce this problem 100% in WTP if you > are interested. > Yes, Igor, we are interested! :) If you are saying WTP is "doing it wrong", please open a bug in WTP .. if you are saying the runtime should handle better :) then feel free to just explain here. I(In reply to comment #14) > Yes, Igor, we are interested! :) If you are saying WTP is "doing it wrong", > please open a bug in WTP .. if you are saying the runtime should handle better > :) then feel free to just explain here. > Can I do both? :-) I've opened bug 140471 for WTP specific problems but at the same time I think platform can do better too -- methods of ProgressManager$JobMonitor should not add finished jobs back to the jobs map. Ditto to Igor's comments. There is a bug (unnecessary code) in WTP and that's what appears to be caussing our particular case of this problem. We'll fix it, but the other fix should be in the platform to avoid issues like comment #13, since I've heard this problem in other cases as well. Igor, can you enter a new bug report against Platform UI for the issue you are describing? This bug report was capturing two many unrelated issues, and is now focused on not showing progress for the job that updates the progress view. I have created bug 149857 for the problem mentioned in comment 13. This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug. If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. -- The automated Eclipse Genie. |