Bug 109926

Comment 1 Olivier Thomann 2005-10-03 13:03:50 EDT

I thought this was an issue with the code formatter, but it looks more like an
issue with the DOM rewriter.
Martin, could you please look at this one? It looks like the rewriter is not
using the formatter's option when the expresion is an array initializer.

Comment 2 Martin Aeschlimann 2005-10-03 13:20:36 EDT

There special code in the rewriter that sets the line length to unlimited. I
have to investigate why.

Comment 3 Olivier Thomann 2005-10-03 13:22:47 EDT

In this case, the force option is set for the array initializer line wrapping.
So even if the length of the line is unlimited, it should still wrap it,
shouldn't it?

Comment 4 Martin Aeschlimann 2005-10-04 03:36:13 EDT

Sunny, can you give more details on how the annotation nodes were created?
Are they all new and were added as a whole, or did you just make modifications
on an existing one?

When making modifications, the AST rewriter doesn't follow all the formatter
preferences. It's a limitation of the rewriter that isn't easy to change.

Comment 5 Sunny Yee 2005-10-04 14:31:30 EDT

Martin,

I update the AST with new NormalAnnotation nodes, and also by modifying existing
NormalAnnotation nodes.  I see problems in the formatting on both, so even with
all new nodes, I see formatting to one line.   In the following example, if the
@Wpa.Action doesn't exist for a particular class method, I created it new along
with the list of name-value pairs.

    @Wpa.Action(forwardConfigs = {@Wpa.ForwardConfig(forward="success",
layout="athp", layoutActions={com.hp.SampleLayoutAction.class},
layoutProperties={@Wpa.LayoutProperty(name="pageTitle", value="demo page 1")})
    })

Psudeo code:

// adding a new @Wpa.Action node if it doesn't exists
if (noWpaActionNode == false) {
    wpaActionAnn = ast.newNormalAnnotation();
    wpaActionAnn.setTypeName(ast.newName(JpfConstants.WPA_ACTION_ANNO));
				
    methodDecl.modifiers().add(pos, wpaActionAnn);
}

// Add a new 'forwardConfigs={}' member pair if it doesn't exists.

MemberValuePair forwardConfigsPair = null; 
List<MemberValuePair> forwardConfigsList = wpaActionAnn.values();
for (MemberValuePair pair: forwardConfigsList) {
    if pair.getName().getFullyQualifiedName().
            equals(JpfConstants.FORWARD_CONFIG_MEMBER_NAME)) {
	// found 'forwardsConfig' node
	forwardConfigsPair = pair;
	break;
				
    }
}

// 'forwardConfigs' member value pair doesn't exists, so create one.
if (noForwardConfigsPair == true) {
    forwardConfigsPair = ast.newMemberValuePair();
    forwardConfigsPair.setName(
            ast.newSimpleName(JpfConstants.FORWARD_CONFIG_MEMBER_NAME));
				
    // Create empty array.
    ArrayInitializer arrayInit = ast.newArrayInitializer();
    forwardConfigsPair.setValue(arrayInit);
				
    wpaActionAnn.values().add(forwardConfigsPair);
}
			
// Code to add to array ...

Comment 6 Gary Horen 2005-11-10 18:54:31 EST

Formatting of annotations is very important to us; we do a lot of programmatic 
insertion of them into source files.

Comment 7 Gary Horen 2006-01-05 20:27:29 EST

*** Bug 122838 has been marked as a duplicate of this bug. ***

Comment 8 Martin Aeschlimann 2006-02-10 14:41:59 EST

It seems to me that the rewriter uses the formatter, but we don't have the formatter settings that can do exactly what you want.

In my formatter profile I configured:
New Lines:
  Insert new lines after open brace of array initailizer : true
  Insert new lines after open brace of array initailizer : true
Line Wrapping:
  Extension - Array Initialiers: Always wrap except first, indent one

This is my code sample to format:
---
package pack;

@MyAnnot(x1 = "", y1 = {@MyAnnot2(z1 = "")})
public class Y {
}

@interface MyAnnot {
	String x1();	
	MyAnnot2[] y1();
}

@interface MyAnnot2 {
	String z1();
}
--
This is what I get (select all, Source > Format)
---
package pack;

@MyAnnot(x1 = "", y1 = {
	@MyAnnot2(z1 = "")
}) public class Y {
}

@interface MyAnnot {
	String x1();

	MyAnnot2[] y1();
}

@interface MyAnnot2 {
	String z1();
}



When removing the y1 = {...} line and using quick fix, the result is:
package pack;

@MyAnnot(x1 = "", y1 = {
	@MyAnnot2
})
public class Y {
}

@interface MyAnnot {
	String x1();

	MyAnnot2[] y1();
}

@interface MyAnnot2 {
	String z1();
}

So it seems the rewriter correctly uses the formatter for the new node.

It seems to me that this is a formatter issue. Olivier did I miss something?
Also note the strange placement of 'public' just after the closing parenthesis.

Comment 9 Frederic Fusier 2008-08-18 08:07:02 EDT

Ownership has changed for the formatter, but I surely will not have enough time to fix your bug during the 3.5 development process, hence set its priority to P5.
Please provide a patch if you definitely need the bug to be fixed in this version and I'll have a look at it...
TIA

Comment 10 Raoul 2008-09-01 04:57:31 EDT

Hy,

I had this bug too, to resolve it you have only to :
   - delete "site.xml" where in you eclipse folder.
   - run eclipse : "eclipse.exe -clean"

Normaly it work.

Best regards,
Aurélie

Comment 11 Eclipse Genie 2019-12-23 08:15:18 EST

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.