Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 109277

Summary: [OLE] OleEditor does not support external files
Product: [Eclipse Project] Platform Reporter: Christof Marti <christof_marti>
Component: UIAssignee: Eric Moffatt <emoffatt>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: daniel_megert
Version: 3.1   
Target Milestone: 3.5   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Bug Depends on:    
Bug Blocks: 74194    
Attachments:
Description Flags
Patch against OleEditor.java none

Description Christof Marti CLA 2005-09-12 06:42:36 EDT 
3.1

OleEditor is restricted to IFiles, which is an issue when opening external files
from File->Open File... or when opening temporary files on the filesystem.
Comment 1 Dani Megert CLA 2005-09-21 16:34:15 EDT 
Created attachment 27363 [details]
Patch against OleEditor.java
Comment 2 Dani Megert CLA 2005-09-21 16:39:11 EDT 
The patch enhances the OleEditor to also handle IPathEditorInput.

Note: I fixed bug 74194 which will now cause stack dumps until this bug will be
fixed. This is not worse than before where things like Excel tables got opened
inside the text editor with all kinds of special characters.
Comment 3 Eric Moffatt CLA 2005-09-22 10:02:50 EDT 
I've just tried this and, as long as you get the 
latest 'org.eclipse.ui.editors' to pick up the changes in the 
OpenExternalFileAction, it seems to work like a charm...

nice one, Thanks

Alas, I have no commit rights...over to you Tod.
Comment 4 Dani Megert CLA 2005-09-22 10:09:15 EDT 
Technically I do have commit rights - but maybe I will get them officially
sometimes since I already contributed some patches ;-)
Comment 5 Eric Moffatt CLA 2005-09-22 10:28:14 EDT 
Not only that, they work!
Comment 6 Dani Megert CLA 2005-10-04 05:11:19 EDT 
Any updates on this one? Is there a problem with the patch?
Comment 7 Tod Creasey CLA 2005-10-04 11:27:02 EDT 
Patch released for build >20051003
Comment 8 Eric Moffatt CLA 2007-06-25 14:30:52 EDT 
I just tried opening an external word doc and get an error saying that I have to adapt to an IFile...?
Comment 9 Christof Marti CLA 2008-09-26 05:59:39 EDT 
Is this a problem with the provided fix or did it not make it into a build?
Comment 10 Christof Marti CLA 2008-09-26 06:32:26 EDT 
Works for me in 3.4.
Comment 11 Eric Moffatt CLA 2008-10-01 13:36:22 EDT 
Marking as Fixed as per the last comment.

Marking as 3.5 for verification.
Comment 12 Eric Moffatt CLA 2008-10-28 13:36:26 EDT 
Verified in I20081027-1300.