Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 107594

Summary: Decouple profiling UI from agent controller implementation
Product: z_Archived Reporter: Curtis d'Entremont <curtispd>
Component: TPTPAssignee: amehrega
Status: CLOSED FIXED QA Contact:
Severity: enhancement    
Priority: P1 CC: ashishp
Version: unspecifiedKeywords: plan
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:
Bug Depends on: 93212    
Bug Blocks:    

Description Curtis d'Entremont CLA 2005-08-22 09:29:14 EDT
We are using the Profiling Monitor to display and control our agents, however
these are not implemented using the agent controller. Rather than reimplementing
a new view to control these agents, we would like to use the same view as with
other agents. However, the problem is that the UI is too tightly coupled with
the agent controller.

For instance, our agents support start and stop monitoring, but the start/stop
actions in the profiling monitor are hardcoded to talk directly to the agent
controller, so they don't work for us.

The UI should be de-coupled from the back end as much as possible, such that you
can replace the backend and plug in a new one. The only way I can make this work
as-is is to try and short circuit the actions and add a layer of indirection so
that they don't talk to the agent controller for our agents. However, this is
only a temporary hack.. we need a real solution.

There should be a way to provide an implementation for each action, for each
agent. Thus, if I add a new agent to the UI, I should also provide an
implementation for the actions. I imagine something very similar to the eclipse
debug framework, where you plug in processes.
Comment 1 Valentina Popescu CLA 2005-11-23 09:57:19 EST
Ali, this should be reviewed during the JVMTI design
Comment 2 amehrega CLA 2006-01-14 23:24:53 EST
The design document attached to feature: https://bugs.eclipse.org/bugs/show_bug.cgi?id=93212 describes an extension point that will allow contributors to define their own context provider for a specific agent type.  The context provider will allow contributors to define menu items/tool bar items based on the user's selection of the agent.

The investigate along with the helpwanted keyword can be taken off.  I will cover this feature as part of 93212 in 4.2i2.
Comment 3 Sri Doddapaneni CLA 2006-01-15 00:50:23 EST
Added dependency on 93212 and included in draft plan.
Comment 4 amehrega CLA 2006-03-31 17:37:25 EST
I should note that the client code for JVMTI agent is targeted to 4.2i3 and tracked under defect:  https://bugs.eclipse.org/bugs/show_bug.cgi?id=134341
Comment 6 Ashish Patel CLA 2006-11-16 14:16:02 EST
Closing.