Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 106194

Summary: [plan item] Enhance the text editor
Product: [Eclipse Project] Platform Reporter: Mike Wilson <Mike_Wilson>
Component: TextAssignee: Platform-Text-Inbox <platform-text-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: enhancement    
Priority: P4 CC: david_williams, eclipse, ed.burnette, ekuleshov, for.work.things, gunnar, mlists, mober.at+eclipse, rjlorimer, stephan.wahlbrink, thatnitind, thomasf
Version: 3.1Keywords: plan
Target Milestone: 3.2   
Hardware: All   
OS: All   
Whiteboard:

Description Mike Wilson CLA 2005-08-05 12:27:12 EDT
The Eclipse Text component provides a powerful editing framework that is useful in many contexts, but 
some of its capabilities are currently only available in the Java editor. The Java editor should be opened up 
to allow more general access to the reconciling, code assist, and template proposal mechanisms. Other 
enhancements to the look and feel of the editor should also be considered in areas such as the Find/
Replace dialog, showing change history and comments in the editor, and annotation roll-overs. [Platform 
Text]
Comment 1 Amy Wu CLA 2005-08-12 16:40:06 EDT
Additional Java editor features/infrastructure that should be moved down:

Bug 84819 - document folding
Bug 87455 - text hover
Bug 91504 - Quick fix/assist
Comment 2 Dani Megert CLA 2005-08-16 10:51:06 EDT
Just to clarify: the document folding and text hovering infrastructure are in
Platform Text. The listed bugs are some additional requests/features.

Quick Fix/Assist is on the plan since it is needed when pushing down spell checking.
Comment 3 Eugene Kuleshov CLA 2005-08-21 15:34:34 EDT
How about Bug 85751? 

[rulers][api] Common way to globally add custom info into editor left bar
https://bugs.eclipse.org/bugs/show_bug.cgi?id=85751
Comment 4 Dani Megert CLA 2005-08-22 04:55:09 EDT
>How about Bug 85751? 
Most likely not for 3.2.
Comment 5 Eugene Kuleshov CLA 2005-08-23 23:58:19 EDT
(In reply to comment #4)
> >How about Bug 85751? 
> Most likely not for 3.2.

That would be really bad. Means at least another year. :-(

Maybe it could be done outside of the editor, so any other component could
decorate embedded text editors?
Comment 6 Eugene Kuleshov CLA 2005-11-09 14:17:01 EST
(In reply to comment #4)
> >How about Bug 85751? 
> Most likely not for 3.2.

Support for the new RevisionRulerColumn had been recently added to the text
component. I wonder if it can be generalized to show not only revision info but
also any other data that could be provided by pluggable data provider (perhaps
somehow similar to QuickDiff providers). See discussion thread from
platform-text-dev mail list.

http://dev.eclipse.org/mhonarc/lists/platform-text-dev/msg00248.html
Comment 7 Dani Megert CLA 2005-11-09 16:51:39 EST
The annotate ruler is quite special and from there to an API that allows to
plug-in custom rulers requires much work (see also Tom's comments in bug 85751).
Providing only means to set text and image as mentioned on the mailing list
would not be sufficient - a solution would be closer to what Tom proposed as API.

We will not have time to do this for 3.2. However, If this is an important
feature for you I suggest to participate and send us patches.
Comment 8 Eugene Kuleshov CLA 2005-11-12 22:57:21 EST
(In reply to comment #7)
> The annotate ruler is quite special and from there to an API that allows to
> plug-in custom rulers requires much work (see also Tom's comments in bug 85751).

Not sure what makes it so special? There are number of numeric (or id-based like
in VCS revisions) characteristics that can be attached to particular line ranges
in Java code, which are need to be easy to observe. That include metrics, test
coverage, and number of others applications.

> Providing only means to set text and image as mentioned on the mailing list
> would not be sufficient - a solution would be closer to what Tom proposed as API.

My suggestion for text+color only API is based on several practical use cases
that I've seen. None of those need custom draving, but rather text only and
optionally color for given line range. Besides, existing icon-based ruller is
quite sufficient for image-based annotation markers.

> We will not have time to do this for 3.2. However, If this is an important
> feature for you I suggest to participate and send us patches.

I'll try that.
Comment 9 Martin Oberhuber CLA 2005-11-29 04:21:17 EST
What about the following features which are in the JDT editor only right now:
   * Select (next,previous,enclosing) element
   * Go to Matching Bracket
   * Show Source of Selected Element Only
It appears that these could also be pushed down if there were some common concept of a "Hierarchy of Elements" in a text. Also,
   * Toggle Mark Occurrences
appears to be totally independent of Java and should be moved down to Text.
Comment 10 Dani Megert CLA 2005-11-29 04:33:29 EST
>It appears that these could also be pushed down if there were some common
>concept of a "Hierarchy of Elements" in a text.
Since we do not have this (kind of model) yet we won't start pushing it down - at least not for 3.2. Having said that, we started work on an LTK UI plug-in that will in the beginning just contain some command definitions that are interesting for editors that offer more than just simple text editing. This will be the right place to push things like you mentioned into.
Comment 11 Martin Oberhuber CLA 2005-11-29 05:14:49 EST
Agree regarding LTK UI.
But "Toggle Mark Occurrences" should be text-only, isn't it?


Comment 12 Dani Megert CLA 2005-11-29 05:45:46 EST
>Agree regarding LTK UI.
>But "Toggle Mark Occurrences" should be text-only, isn't it?
For text occurrence we think it's better to merge this into Find/Replace (see bug 29692).
Comment 13 Mike Wilson CLA 2006-02-14 15:05:04 EST
The text of this item in the plan has changed. The new text is:
"
The Eclipse Text component provides a powerful editing framework that is useful in many contexts, but some of its capabilities are currently only available in the Java editor. The Java editor should be opened up to allow more general access to the reconciling, code assist, and template proposal mechanisms. Another enhancement to the look and feel of the editor is to show change history and comments in the editor. Other possible enhancements include improving the Find/Replace dialog and annotation roll-overs. [Text]
"
Comment 14 Dani Megert CLA 2006-03-27 15:00:37 EST
The features as advertised are in 3.2 except for:
>Other possible enhancements include
>improving the Find/Replace dialog and annotation roll-overs. [Text]
This has to be deferred.