Bug 105685

Description Pascal Rapicault 2005-08-01 13:04:17 EDT

This is a post from the newsgroup. It suggests some improvements to the doc for jnlp.
===========

First of all, THANK YOU to Pascal for writing the new Java Web Start  documentation for Eclipse 3.1RC3. 
It helps to have all the concepts tied  together like this.

However, I do have some constructive feedback for the documentation. Is  this newsgroup the most 
effective way to send comments, or would it be  more appropriate to post the comments in Bugzilla Bug 
94141?

Either way, I guess it won't hurt to post them to the newsgroup. Here goes:

In Step 1:
* Is "wrappering" the correct word in this context?  Would "wrapper" be  more concise?
* The instructions say: "Create a feature including all the features that  are listed in your product 
definition."  Does this refer to just the  plug-ins that are unique to our product, or all the dependencies 
as well?
* The instructions say: "Copy in a folder of your feature the  startup.jar."  Does this mean: "Copy the 
startup.jar file into your  feature's folder"?
* When we add the "root=" line to build.properties, should we specify the  absolute path, or the relative 
path?  If relative, should the folder just  be "." (dot)?

In Step 2:
* At the phrase "You need to use keytool", you may wish to add a hyperlink  to  http://java.sun.com/
j2se/1.5.0/docs/guide/javaws/developersguide/development.html#signing  which provides an 
excellent overview of how to use keytool.
* "File > Export > Features" should be "File > Export > Deployable  Features"

In Step 3:
* No questions.

In the section "Plug-ins based application"
* This section is very confusing to me (maybe it's just me!).  I thought  _all_ of the instructions thus far 
were specifically for plugin-based  (RCP) applications.  Why a separate section for it?  Weren't we told to  
create a wrappering feature in Step 1?  Are we supposed to create a second  wrappering feature, 
different from the first?  Any additional words of  clarification for this section would be very 
appreciated.

In general:
* Every occurrence of the word "than" in the document can be safely  replaced with "as".

I hope this helps for RC4 and beyond!  Please let me know if you have any  questions or want 
clarification on any of my comments herein posted.

Thanks,
Geoff