Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 105656

Summary:	[DnD] Type of first parameter of the constructor of PluginDropAdapter must be a Viewer not a StructuredViewer
Product:	[Eclipse Project] Platform	Reporter:	Olivier Oeuillot <oeuillot>
Component:	UI	Assignee:	Platform UI Triaged <platform-ui-triaged>
Status:	CLOSED WONTFIX	QA Contact:
Severity:	normal
Priority:	P3	CC:	jeem
Version:	3.2	Keywords:	helpwanted
Target Milestone:	---
Hardware:	PC
OS:	Windows XP
Whiteboard:	stalebug

Description Olivier Oeuillot

2005-08-01 05:04:56 EDT

I see no reason why the first parameter of the constructor of
org.eclipse.ui.part.PluginDropAdapter must be a StructuredViewer.

I have already implemented a Viewer, and I want use a class which extends
PluginDropAdapter, 
but I cant !  (I must duplicate this class !)

So, for a future developper, It should be nice to change this type ;-)

Comment 1 Kim Horne

2005-08-02 11:17:04 EDT

I think it'd be safe for us to downgrade the requirement to Viewer in the constructor.  Jim, is this safe?

Comment 2 Jim des Rivieres

2005-08-02 12:52:12 EDT

You cannot change the parameter type in the constructor without breaking 
existing clients. However, you could add an additional constructor that takes 
a Viewer.  Also, you need to be careful if the class has any methods that 
expose the object passed in to the constructor, and find a non-breaking way to 
deal with those too.

Comment 3 Eclipse Genie

2019-07-08 19:38:16 EDT

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.