Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 105446

Summary:	[GlobalActions] Revert is too close to SaveAll in File menu
Product:	[Eclipse Project] Platform	Reporter:	Jagan Gowder <jgowder>
Component:	UI	Assignee:	Paul Webster <pwebster>
Status:	RESOLVED WONTFIX	QA Contact:
Severity:	normal
Priority:	P5	CC:	daniel_megert, h.klene
Version:	3.1	Keywords:	helpwanted
Target Milestone:	---
Hardware:	PC
OS:	Windows XP
Whiteboard:

Description Jagan Gowder

2005-07-28 10:19:49 EDT

Should that Revert menu item be so close to save all. since there is no shortcut
in the tool bar for SaveAll, when  you are trying to hit saveAll there are
always chance of hitting Revert . Can it be moved some where else on the file
menu so that it is not right next to the save All.

Thank you.

Comment 1 Jess Garms

2005-07-28 19:16:39 EDT

I assume this was meant for the UI component rather than the APT component.
Reassigning.

Comment 2 Dirk Baeumer

2005-07-29 04:39:15 EDT

The Menu layout is defined by Platform/UI.

Comment 3 Kelly R. Denehy

2006-08-14 11:01:55 EDT

"Revert file" is also dangerously close to "Save" in the context-sensitive popup menu.  I personally have probably lost about an hour of work by accidentally selecting revert a few times now.

Revert file is dangerous in general.  A confirmation might help a little, but often we automatically click YES or OK.  The best solution would be to make revert file an undo-able operation.

Comment 4 Paul Webster

2007-04-05 19:04:29 EDT

Assigning to component owner
PW

Comment 5 Adrian Mouat

2007-06-05 05:50:50 EDT

I completely agree with this.

I too have lost work due to an inadvertent mouse click.

Is there anyway I can disable it?

(In reply to comment #3)
> "Revert file" is also dangerously close to "Save" in the context-sensitive
> popup menu.  I personally have probably lost about an hour of work by
> accidentally selecting revert a few times now.
> 
> Revert file is dangerous in general.  A confirmation might help a little, but
> often we automatically click YES or OK.  The best solution would be to make
> revert file an undo-able operation.
>

Comment 6 Holger Klene

2012-04-13 21:02:20 EDT

Revert is undoable now (4.2M6 I20120315-1300) as long as the editor tab was not closed altogether. It only has the slight inconvenience of selecting all text and scrolling up to the top of the file, thereby obscuring what exactly changed.

On Undo of a revert operation the cursor might as well move to the first changed line within the file. But on the other hand: Those markers are buggy themselves and I don't really trust them, once they start persisting after a save.

Comment 7 Dani Megert

2013-04-23 03:41:10 EDT

It's like that for more than 10 years and people got used to the current locations of those menu items. Changing the location of those menus would hurt more people than it helps.