Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 104996

Summary: plugin.xml GUI editor crashes on massive undo
Product: [Eclipse Project] PDE Reporter: Martin Olsson <mnemo>
Component: UIAssignee: PDE-UI-Inbox <pde-ui-inbox>
Status: RESOLVED DUPLICATE QA Contact:
Severity: normal    
Priority: P3    
Version: 3.1   
Target Milestone: ---   
Hardware: PC   
OS: Windows 2000   
Whiteboard:
Attachments:
Description Flags
the crash error message none

Description Martin Olsson CLA 2005-07-25 08:30:22 EDT
So I'm just editing my plugin.xml and all is well. I'm pressing CTRL-S every 
now and then as I always do (for no sane reason). Sometimes I save even though 
an extension point or actionSet-action/menu etc are not completely filled in. 
In the middle of it all I take a look at the raw version of plugin.xml and now 
it won't let me even use the GUI editor until I fixed all the errors in the raw 
version of the file... and when I look at it a little bit more carefully I find 
lots of attributes and tags called PluginElementNode@df3384 etc.

In the middle of this I start to panic a little bit so I just press the CTRL-Z 
keys and keep them pressed while the editors undos a ton of stuff at lightning 
speed. Then all the suddenly the whole plugin.xml GUI thing crashes on me and 
says ABNORMAL WORKBENCH CONDITION. It says some exception occurred but it gives 
no clue as to what exception and certainly no stacktrace (not even in 
details?!). This is how it looked:

http://mnemo.minimum.se/eclipse_crashes/undo_crash_two.png

(it should also be obvious from this image that
I got some serious MSPaint skills :-D)

Also try to create an actionSet empty the boxes for id and label, then press 
save. Then it says only "Save Fail:null" and nothing else.. what kind of weird 
error message is that? Why can't it just save a raw file with id="" like any 
sane person would expect?

In general, in all parts of Eclipse error messages should say what exception 
occurred. And in details there should always be a proper stacktrace. Why are 
you guys so sloppy with this? Of course, sitting idle myself I cannot expect 
someone else to do the work but maybe atleast new code would try to display 
better error messages? As it stands today I don't even know where to begin 
searching for these bugs.
Comment 1 Martin Olsson CLA 2005-07-25 08:31:31 EDT
Created attachment 25232 [details]
the crash error message
Comment 2 Wassim Melhem CLA 2006-06-20 16:47:42 EDT
we'll use bug 68423 to track the undo/redo deficiencies in the plug-in manifest editor.

*** This bug has been marked as a duplicate of 68423 ***