Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 104783

Summary: landmarks blink on save
Product: z_Archived Reporter: Mik Kersten <mik.kersten>
Component: MylynAssignee: Mik Kersten <mik.kersten>
Status: RESOLVED FIXED QA Contact:
Severity: enhancement    
Priority: P4 CC: mik.kersten, peik.aschan
Version: unspecified   
Target Milestone: ---   
Hardware: Other   
OS: other   
Whiteboard:

Description Mik Kersten CLA 2005-07-22 08:52:27 EDT
Perhaps it is possible to avoid the refresh that's causes this, e.g. by checking
if the node is currently visible in the tree and not refreshing if it is there.
Comment 1 Eugene Kuleshov CLA 2005-08-13 01:57:11 EDT
This could be the same as 
Comment 2 Mik Kersten CLA 2005-08-15 14:09:30 EDT
Eugene, it looks like you didn't get your whole comment in?
Comment 3 Mik Kersten CLA 2005-09-26 18:44:05 EDT
This should happen much more rarely now, but when landmarks change on an 
element Eclispe forces a re-decoration.
Comment 4 Peik Aschan CLA 2006-02-27 01:38:40 EST
Selected text copied from bug 129121:

------- Peik Aschan -------
The landmarks in the Package Explorer and Outline view blink on and off, usually after saving. (Is this the same as bug 104783?) This is very annoying an may cause epilepsia :-).

------- Mik Kersten -------
Regarding the epilepsy, we definitely don't want Mylar to cause that ;)  Yes,
it sounds like bug 104783, but the blinking should only be quite infrequent,
and in general only on the resource that you're changing.  But perhaps this is
different if you have a lot of landmarks.  If possible could you attach a
screenshot to that bug report, and mention how much blinks?

Comment 5 Peik Aschan CLA 2006-02-27 01:45:02 EST
Mik, I'll mail a picture of the blinking to you.

The amount of blinking depends on how many landmarks the task has, and can be much worse than in the picture at times. It does stop after a while, but I don't quite know how to make it stop explicitly. Usually I just switch the Mylar view off for a while and let it calm down.
Comment 6 Peik Aschan CLA 2006-03-03 10:42:56 EST
Some additional information: 

The blinking most often occurs when I save a file (or all files, Ctrl+Shift+s, as I usually do). 

We use SourceSafe for version control, and the Eclipse VSS plugin 1.6.1 (http://sourceforge.net/projects/vssplugin/). Blinking sometimes occurs after refreshing files from SourceSafe, but not always. 

I've also seen refreshing the workspace project (Project->Refresh) to cause some blinking, but only for a short time, after which it stops by itself.

Comment 7 Peik Aschan CLA 2006-03-03 10:46:28 EST
VSS check-in may also cause blinking.
Comment 8 Mik Kersten CLA 2006-03-03 11:06:36 EST
So it blinks more than once (i.e. goes bold, unbold, bold again?).  That I have not seen before (only single blink) and is almost certianly due to the VSS plug-in requesting too much refresh on the Package Explorer.
Comment 9 Peik Aschan CLA 2006-03-03 11:14:04 EST
Yes, hence the epilepsia warning ;-)

I wouldn't be surprised if the VSS plugin was responsible, it has a lot of other annoyances and is apparently not very actively developed. Unfortunately we can't live without it as long as we're on SourceSafe. I don't suppose there's any way to work around the blinking it causes?
Comment 10 Mik Kersten CLA 2006-03-03 11:50:10 EST
We're dependent on an Eclipse SDK mechanism here, so I've created platfrom bug 130340 to see if we can figure out a way to be defensive against downstream plug-ins causing this sort of blinking.  If that doesn't go well we'll have to make the decorator configurable so that there is a way of turning off the bolding.
Comment 11 Peik Aschan CLA 2006-03-20 10:13:04 EST
Something rendered my old workbench unusably slow, and I suspect the Mylar/VSS conflict to be at least part the cause. I had to kill the Eclipse process a few times when it stalled, and this seems to have corrupted my workbench.

In any case, I've now upgraded to Eclipse 3.2M5a and Mylar 0.4.10, so just a few observations about that configuration and some other discoveries I've made.

The symptoms are still the same, and one additional effect can be seen while the blinking is happening. The Eclipse status bar at the lower right flashes the text "Updating Check-Out View...". If I close the "VSS Checked Out Files" view, the blinking stops and does not seem to reoccur. 

On the other hand, disabling VSS label decorators has no effect on the blinking. So it appears that the problem is with that specific view and not the label decorators?

We make heavy use of the VSS Checked Out Files view, so it's not really a satisfactory workaround to keep the view closed.

What parts of this problem do you think are something Mylar can work around, and for what parts should I send my pleas for help to the VSS plugin developer or the Eclipse platform team? Wherein lies the conflict?
Comment 12 Mik Kersten CLA 2006-03-20 11:45:55 EST
On the platform side: one thing you could do is vote for bug 130340 and state that you see this problem using Mylar's bolding decorations with the VSS plug-in whose Updating Check-Out View causes excessive refresh.

On the VSS side: they should definitely not be causing all that refresh since it's a performance/UI issue, and just manifests itself a lot more visible with the bolding, so please do file a bug and CC me.

On the Mylar side: the only way I can think of working around this is to provide configurable landmark decorators, so that you could turn off bolding.  I've bumped bug 107091 to P1 so that it makes it into 0.5, and that will allow you to preview and configure landmark display.
Comment 13 Peik Aschan CLA 2006-03-20 12:32:05 EST
I filed a bug report with the VSS plugin bug tracker: http://sourceforge.net/tracker/index.php?func=detail&aid=1454754&group_id=54205&atid=473011

I did not notice VSS plugin causing this problem before using Mylar, but as you say, maybe Mylar just makes it that much more visible. I'll disable Mylar for a few days to see if I notice any excessive refreshs without it.
Comment 14 Mik Kersten CLA 2006-03-20 12:34:49 EST
You shouldn't need to disable Mylar--just deactivate your active task, after which point Mylar will be effectively disabled (but you'll still have your task list).

And yup, without the bolding/decoratoin it can be very hard to notice excessive refresh (other than watching the CPU).
Comment 15 Mik Kersten CLA 2006-04-03 20:00:44 EDT
Peik: I should have mentioned earlier that you can already disable the landmark and interest decorator, which should address your flickering problem.  Follow the instructions at:

http://www.eclipse.org/mylar/doc/faq.php#context-ui-config
Comment 16 Mik Kersten CLA 2006-04-24 21:59:36 EDT
The last problems related to this have been resolved by the fixing of Eclipse bug 130340 (Eclipse 3.2 only).