Bugzilla – Full Text Bug Listing
| Summary: | "Create Patch" should offer a Verify Patch step | ||
|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Aaron Luchko <aaron> |
| Component: | Team | Assignee: | Bogdan Gheorghe <gheorghe> |
| Status: | VERIFIED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | gunnar, markus.kell.r, mlists |
| Version: | 3.1 | ||
| Target Milestone: | 3.2 M3 | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Bug Depends on: | 41340 | ||
| Bug Blocks: | |||
I personally only ever want to create patches whose paths start at the topmost (project) level. IMO, this should be the default. Since we already have "Ignore leading path name segments", the "Strip leading path name segments" would not even be necessary. (In reply to comment #1) > I personally only ever want to create patches whose paths start at the topmost > (project) level. IMO, this should be the default. Same here, that's the main reason I suggested this patch. Right now the only way to get a patch at the topmost level generates a patch for every altered file within that project (which it not always what one wants). > Since we already have "Ignore > leading path name segments", the "Strip leading path name segments" would not > even be necessary. Yeah, that was just me suggesting a slightly different name for that functionality which in hindsight was kinda pointless, just keep it as "Ignore" :) Indeed it would be nice if someone can exclude specific files/folders from a project wide patch. I think the word "verify" in the summary is misleading. What you really want is a page in the Create Patch wizard that allows to customize the files/folders, which should be included in the patch. This is addressed by the new Create Patch wizard. Fixed Verified |
Currently if you wish to make a patch for a single file in a directory, from the perspective of that directory, it's impossible to do so without including any other files you've changed in the directory in the patch. For instance if I'm working on a project foo/ bar/ A.java B.java C.java and I've altered all three files but only wish to make a patch for A.java and B.java which is appliable from the foo/ directory there is no way to do so. Adding a "verify patch" similar to one used for "Apply Patch" would solve this problem by allowing me to deselect C.java. Also a "Strip leading path name segments" option similar to "Ignore leading path name segments" would offer a solution to bug 41340 as well.