Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 102907

Summary:	[refactoring] Rename field Preview dialog misplaced on desktop, is overlaid by Dock
Product:	[Eclipse Project] JDT	Reporter:	Sean Montgomery <sean_montgomery>
Component:	UI	Assignee:	Dirk Baeumer <dirk_baeumer>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	andre_weinand
Version:	3.1
Target Milestone:	3.2 M2
Hardware:	Macintosh
OS:	Mac OS X - Carbon (unsup.)
Whiteboard:

Description Sean Montgomery

2005-07-06 14:33:15 EDT

MacOS 10.4.1, OS X Dock set to right edge of primary screen (I work with two Eclipse windows - one on 
the main laptop screen, and one on a separate monitor to the left of the main laptop screen).  In a Java 
source file select a field, preferably one mentioned in comments to force a Preview below.  Select 
Rename... from Refactor menu to get the Rename Field dialog.  Change field name and click on Preview 
button.  The Rename Field (preview) dialog shows up on the main laptop screen but is too low on the 
screen by about the height of a window title bar - this leads to the Preview >, Cancel and OK buttons 
being clipped by the bottom edge of the screen.  The right edge of the dialog lies under the Dock on 
the right of the screen.

Note also that, even though the Rename Field (preview) has a working resize icon on the lower right, it 
does not have a green resize "gumdrop" (whatever it's called) in the upper left (on the title bar).  Having 
the green resize gumdrop would be a quick fix for whenever the Rename Field (preview) dialog was 
misplaced - normally in most Mac apps clicking the green gumdrop maximizes the window/dialog - 
allowing for the Dock, of course.

Comment 1 Sean Montgomery

2005-07-06 15:03:48 EDT

After another Eclipse crash that required me to set up my two Eclipse windows with views, perspectives, 
fast views, etc. I performed another Refactor:Rename... on a field.  This time the Rename Field preview 
dialog showed up correctly positioned horizontally - it was bounded on the left by the main laptop 
screen's left edge, and bounded on the right by the Dock's left edge.  This time the dialog was too high by 
about the height of the title bar, i.e. the title bar area (with gumdrops) was hidden behind the menu bar.  
Since it was entirely hidden I was unable to drag it down.

Comment 2 Dirk Baeumer

2005-07-14 11:15:13 EDT

Andre, can you reproduce this. Normally the dialog should be limited to the
available screen real estate.

Comment 3 Sean Montgomery

2005-08-15 11:09:48 EDT

I've added bug #107029 to separately address the need for maximize buttons on all resizable dialogs.

Not only do the refactoring rename preview dialogs come up clipped by the dock and too low on the 
screen so that the cancel and ok buttons get clipped, but I have also noticed a worse case occuring: the 
top of the rename preview dialog will be too high on the screen, so that its title bar is hidden under the 
Mac menu bar.  In this case there is no way to move the dialog.

Comment 4 Andre Weinand

2005-08-15 11:52:34 EDT

Yes, I was able to reproduce the problem where the title bar of the rename preview dialog is hidden under 
the Mac menu bar.

Comment 5 Dirk Baeumer

2005-09-05 12:53:15 EDT

Two problems:

- we always have to make sure that we take the client area of the monitor
- when the secondary monitor is places left beside the primary monitor the x 
  coordinate is negative. Same for y when positions above.

Comment 6 Dirk Baeumer

2005-09-05 12:53:28 EDT

Fixed for I20050906.

Comment 7 Martin Aeschlimann

2005-09-20 12:33:53 EDT

Andre, can you verify?

Comment 8 Andre Weinand

2005-09-21 05:06:10 EDT

verified for M2