| Summary: | [quick fix] 'Change to a_type' does not consider generics | ||
|---|---|---|---|
| Product: | [Eclipse Project] JDT | Reporter: | Markus Keller <markus.kell.r> |
| Component: | UI | Assignee: | Martin Aeschlimann <martinae> |
| Status: | VERIFIED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | dirk_baeumer |
| Version: | 3.1 | ||
| Target Milestone: | 3.2 M1 | ||
| Hardware: | PC | ||
| OS: | Windows XP | ||
| Whiteboard: | |||
Martin, is this something we should conisder for 3.1.1 ? Martin, can you please investigate for 3.1.1 and explain the risk of the fix. This is a bigger fix and could only be added to 3.1.1 if we decide to make a greater (non-minimal) update to quickfixes with generics. Can you explore the greater update to quick fix in 3.2 so that we can decide if we want to add it to 3.1.1. Martin, will bug 106069 address this one as well ? No, bug 106069 does not address this problem. I released a fix for this one to 3.2. When it looks good then I'll add an extra patch to bug 106069. The fix for this one is to add extra quick fixes. Before suggesting this fix for 3.1.1 I want to make sure that the new proposals don't conflict with the other proposals. E.g. you will get: Change to List Change to List<String> IMO not highly important for 3.1.1 Agree. this is already in 3.2 M1 verified 20051213-0010 |
I20050627-1435 (3.1) HashMap<Integer, String> idToName= new HashMap<Integer, String>(); String entries1= idToName.entrySet(); XXX entries2= idToName.entrySet(); The quick fix for entries1 is: Change type of 'entries1' to Set<Entry<Integer, String>> The quick fix for XXX is: Change to 'Set' (java.util) Expected: quick fix for XXX also offers Set<Entry<Integer, String>>, and not only the raw type.