Bug 102736

Comment 1 Steve Northover 2005-07-07 22:59:28 EDT

Here is an SWT only program that WORKSFORME.  Can you make it fail?

import org.eclipse.swt.*;
import org.eclipse.swt.events.*;
import org.eclipse.swt.layout.*;
import org.eclipse.swt.widgets.*;

public class PR_102736 {

public static void main(String[] args) {
	Display display = new Display ();
	final Shell shell = new Shell (display);
	shell.setLayout (new FillLayout (SWT.VERTICAL));
	final Tree tree = new Tree(shell, SWT.SINGLE | SWT.BORDER);
	TreeItem root = new TreeItem(tree, SWT.NONE);
	root.setText ("root");
	TreeItem item = new TreeItem(root, SWT.NONE);
	item.setText ("alpha");
	item = new TreeItem(root, SWT.NONE);
	item.setText ("beta");
	item = new TreeItem(root, SWT.NONE);
	item.setText ("gamma");	
	tree.addSelectionListener(new SelectionAdapter() {
		public void widgetSelected(SelectionEvent event) {
			System.out.println("Selected "+event.item);
		}
	});
	tree.setSelection(new TreeItem [] {item});
	Button button = new Button(shell, SWT.PUSH);
	button.setText("Delete Selected Item");
	button.addSelectionListener(new SelectionAdapter() {
		public void widgetSelected(SelectionEvent event) {
			TreeItem[] selected = tree.getSelection();
			for(int i=0; i<selected.length; i++) {
				TreeItem item = selected [i];
				System.out.println("Deleting "+item);
				item.dispose();
			}
		}
	});
	shell.pack ();
	shell.setSize (200, 200);
	shell.open ();
	while (!shell.isDisposed ()) {
		if (!display.readAndDispatch ()) display.sleep ();
	}
	display.dispose ();
}
}

Comment 2 Tanya Jenkin 2005-07-11 05:37:34 EDT

(In reply to comment #1)
No, it WORKSFORME too, even when I get rid of 'root' so is a 3-item multiple-
rooted tree.  Guess bug is in JFace or my use of it.  Here is the TreeNode data 
class from my original example.  Pressing the delete button eventually calls 
the tree viewer refresh() method.

import java.util.ArrayList;
import java.util.List;

import org.eclipse.jface.viewers.Viewer;

public class TreeNode {
    private String name;
    private List<TreeNode> children;
    private TreeNode parent;
    private List<Viewer> changeListeners;
	
    public TreeNode(String name) {
        super();
        this.name = name;
        this.children = new ArrayList<TreeNode>();
        this.changeListeners = new ArrayList<Viewer>();
        this.parent = null;
    }
    @Override
    public String toString() {
        return getName();
    }
    public String getName() {
        return name;
    }
    public void setName(String name) {
        this.name = name;
        notifyChangeListeners();
    }
    public TreeNode getParent() {
        return parent;
    }
    public void addChild(TreeNode child) {
        children.add(child);
        child.parent = this;
        notifyChangeListeners();
    }
    public List<TreeNode> getChildren() {
        return children; 
    }
    public void removeChild(TreeNode child) {
        children.remove(child);
        child.parent = null;
        notifyChangeListeners();
    }
    public void addChangeListener(Viewer listener) {
	changeListeners.add(listener);
    }
    public void removeChangeListener(Viewer listener) {
	changeListeners.remove(listener);
    }
    public void notifyChangeListeners() {
        for(Viewer viewer : changeListeners) viewer.refresh();
    }
}

> Here is an SWT only program that WORKSFORME.  Can you make it fail?
> import org.eclipse.swt.*;
> import org.eclipse.swt.events.*;
> import org.eclipse.swt.layout.*;
> import org.eclipse.swt.widgets.*;
> public class PR_102736 {
> public static void main(String[] args) {
> 	Display display = new Display ();
> 	final Shell shell = new Shell (display);
> 	shell.setLayout (new FillLayout (SWT.VERTICAL));
> 	final Tree tree = new Tree(shell, SWT.SINGLE | SWT.BORDER);
> 	TreeItem root = new TreeItem(tree, SWT.NONE);
> 	root.setText ("root");
> 	TreeItem item = new TreeItem(root, SWT.NONE);
> 	item.setText ("alpha");
> 	item = new TreeItem(root, SWT.NONE);
> 	item.setText ("beta");
> 	item = new TreeItem(root, SWT.NONE);
> 	item.setText ("gamma");	
> 	tree.addSelectionListener(new SelectionAdapter() {
> 		public void widgetSelected(SelectionEvent event) {
> 			System.out.println("Selected "+event.item);
> 		}
> 	});
> 	tree.setSelection(new TreeItem [] {item});
> 	Button button = new Button(shell, SWT.PUSH);
> 	button.setText("Delete Selected Item");
> 	button.addSelectionListener(new SelectionAdapter() {
> 		public void widgetSelected(SelectionEvent event) {
> 			TreeItem[] selected = tree.getSelection();
> 			for(int i=0; i<selected.length; i++) {
> 				TreeItem item = selected [i];
> 				System.out.println("Deleting "+item);
> 				item.dispose();
> 			}
> 		}
> 	});
> 	shell.pack ();
> 	shell.setSize (200, 200);
> 	shell.open ();
> 	while (!shell.isDisposed ()) {
> 		if (!display.readAndDispatch ()) display.sleep ();
> 	}
> 	display.dispose ();
> }
> }

Comment 3 Steve Northover 2005-07-11 12:37:38 EDT

Ok, I'm going to move this bug to UI for them to investigate.  They can move 
it back if it turns out to be an SWT problem.

Comment 4 Boris Bokowski 2009-11-26 09:54:49 EST

Hitesh is now responsible for watching bugs in the [Viewers] component area.

Comment 5 Eclipse Webmaster 2019-09-06 15:32:21 EDT

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

Comment 6 Eclipse Genie 2021-10-14 16:44:32 EDT

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.