Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 101860

Summary:	WTP document implementations should IDocumentExtension4.
Product:	[WebTools] WTP Source Editing	Reporter:	Dani Megert <daniel_megert>
Component:	wst.sse	Assignee:	David Williams <david_williams>
Status:	CLOSED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	david_williams, for.work.things
Version:	unspecified
Target Milestone:	1.5 RC5
Hardware:	PC
OS:	Windows XP
Whiteboard:
Bug Depends on:	102822
Bug Blocks:

Description Dani Megert

2005-06-27 09:02:31 EDT

WTP I20050617

Due to a bug in Eclipse Platform Text and the WTP document(s) not implementing
the new IDocumentExtension4 interface, that has been added to support user
configurable line delimiters, users run into a StackOverflowError when opening
an xml file with the Ant Editor instead of the XML source page editor.

See bug 101834 for details.

Comment 1 David Williams

2005-06-27 16:35:43 EDT

Changing to P3 since the base platform is putting in fix.
We still want to do this for .7, but a little less critical.

Comment 2 David Williams

2005-07-07 10:50:09 EDT

*** Bug 102967 has been marked as a duplicate of this bug. ***

Comment 3 David Williams

2005-07-07 10:51:18 EDT

This is important to "keep up" with basic Eclipse behavior in 3.1, for rewrite
sessions, undo resetting to non-dirty state, and handing EOL preferences.

Comment 4 David Williams

2005-07-07 10:51:55 EDT

I've started on implementing this (if you have too, Nitin, let's compare notes).

Comment 5 Amy Wu

2006-01-04 15:21:28 EST

Text's IDocumentExtension4 has:
	String getDefaultLineDelimiter();
	void setInitialLineDelimiter(String lineDelimiter);


SSE's IEncodedDocument has:
	String getPreferredLineDelimiter();
	void setPreferredLineDelimiter(String probableLineDelimiter);

These should be consolidated somehow.

Comment 6 Amy Wu

2006-01-04 16:50:11 EST

There's also SSE's IStructuredDocument, which is already extending IEncodedDocument, but it also has the following methods on its interface:
	public String getLineDelimiter();
	public void setLineDelimiter(String delimiter);

And not to mention the following (which are already in IEncodedDocument):
	void setEncodingMemento(EncodingMemento encodingMemento);
	EncodingMemento getEncodingMemento();

Comment 7 Amy Wu

2006-06-06 17:12:13 EDT

Bug 102822 includes having SSE's StructuredDocuments implementing IDocumentExtension4.  So if that bug is fixed, I assume it's safe to say this bug is fixed as well?

Comment 8 Amy Wu

2006-06-12 10:18:28 EDT

Resolving as fixed.  Like I said in previous comment, bug 102822 included a fix for this bug as well.  And marking this bug dependent on bug 102822 in case something happens and that bug's fix is rolled back.

Comment 9 Jeffrey Liu

2006-09-25 12:26:12 EDT

I am closing this bug per the email I got from Daniel.