Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 100841

Summary: [rename] rename method overriding a binary method has bad error handling
Product: [Eclipse Project] JDT Reporter: Tobias Widmer <tobias_widmer>
Component: UIAssignee: Markus Keller <markus.kell.r>
Status: CLOSED WONTFIX QA Contact:
Severity: normal    
Priority: P3 CC: milos.gligoric
Version: 3.1   
Target Milestone: ---   
Hardware: PC   
OS: All   
Whiteboard: stalebug

Description Tobias Widmer CLA 2005-06-20 11:07:25 EDT
3.1 RC3

Steps to reproduce:
- Create compilation unit

class MyList extends ArrayList {
	public boolean addAll(int arg0, Collection arg1) {
		return super.addAll(arg0, arg1);
	}
}

- Try renaming addAll
-> Refactoring correctly asks whether it should perform on ArrayList#addAll
-> Then, a dialog appears that addAll is read only

-> Since the refactoring knows that the selected method is an implementation 
of a binary one, it should directly issue a concise error message and abort
Comment 1 Tobias Widmer CLA 2005-06-20 11:08:44 EDT
On special methods like reimplementations of Object#toString(), the 
refactoring is not available at all.
Comment 2 Dirk Baeumer CLA 2005-06-20 11:18:55 EDT
This would indeed improve usability.
Comment 3 Milos Gligoric CLA 2012-11-28 23:47:41 EST
Eclipse SDK
Version: 3.7.2
Build id: M20120208-0800

The refactoring immediately opens a dialog with an error message.  Should this be considered fixed?
Comment 4 Eclipse Genie CLA 2019-09-04 19:10:14 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.