Bugzilla – Full Text Bug Listing
| Summary: | catelog uri reference broken with emf-sdo-xsd-SDK-I200506160200 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] PDE | Reporter: | David Williams <david_williams> | ||||
| Component: | UI | Assignee: | Konrad Kolosowski <konradk> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | csalter, dejan, ebelisar, Ed.Merks, jeffliu, thatnitind, wassim.melhem | ||||
| Version: | 3.1 | ||||||
| Target Milestone: | 3.1 RC4 | ||||||
| Hardware: | PC | ||||||
| OS: | Windows XP | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
|
Description
David Williams
CCing Ed Merks for comment ... have you seen this the jarred plugins too? Finding the cached schemas via a platform:/plugin URL should work transparently the same whether the file is in a jar or not. Just in case it's not a typo below, the reference should use platform:/plugin/org.eclipse.xsd/cache/... Yes, it was a typo, the full URI given is uri="platform:/plugin/org.eclipse.xsd/cache/www.w3.org/2001/XMLSchema.xsd" /> And, I've convinced myself we can find it just fine, I'll open bug on PDE. In case its not clear from 'moving' bug, I think this is an erroneous error/valdation message the PDE Editor/validator gives for a plugin.xml file that contains a URI using platform:/plugin for a jarred plugin. In previous version, the referenced plugin was not jarred, and did not give the error messages. I found this using RC3 development environment. The jarred plugin is in the PDE target environment. David, can you please restate the problem in comment 4 more clearly, with a sample xml snippet and what the alleged erroneous PDE behavior is? thanks. Yes, the snippet below gives a "resource not found" error in problems view and PDE editor (or warning, depending on setttings. To be exact, here's a past from problem's view. 2 Referenced resource 'platform:/plugin/org.eclipse.xsd/cache/www.w3.org/2001/XMLSchema.xsd' in attribute 'uri' cannot be found. plugin.xml org.eclipse.wst.xsd.ui line 152 June 20, 2005 4:00:15 PM Here's the snippet from our plugin.xml <extension point="org.eclipse.wst.xml.core.catalogContributions"> <catalogContribution id="default"> <uri name="http://www.w3.org/2001/XMLSchema" uri="platform:/plugin/org.eclipse.xsd/cache/www.w3.org/2001/XMLSchema.xsd" /> </catalogContribution> </extension> Thanks David. The code checking for the presence of a resource is still assuming a flat structure. Konrad, please investigate a fix for RC4. Created attachment 23658 [details]
100708 ExtensionsErrorReporter patch.txt
The Patch _I_ attached above, fixes following problems in the error reporter: Resources referenced using platform: did not work on non Windows platform, because on Windows IPath returns platform: as device and on non Windows as first segment. I added the code to expect platform: as the first segment as well when parsing. Code was assuming plug-ins in the target platform are flat. I added the code to check existance of jar entry in the jar if plug-in location ends with ".jar". Wassim, Please evaluate risk/benefits of this fix for RC4. Thanks. The old code + new code could be simplified/generalized, but I was trying not to refactor anything, and leave as much of existing code as is. *** Bug 101341 has been marked as a duplicate of this bug. *** I would like to advocate to have this fixed in 3.1 if at all possible. I find this "resource checking" to be very handy because there's no other way to do it, and these types of bugs are hard to find "just by testing". (That is, may be a long time before the problem is hit). I was reminded of this today as I set up a linux environment (I saw orignal problem on windows), and saw on Linux that even "icons" were not being correctly "found" in another plugin. (They were when ran, just that it was being reported as an error in dev. env.). All in all, I've found that incorrect validation messages makes users ignore them completely, so would be a shame to spoil the 3.1 bushel with this bad apple (sorry for the metaphore, I'm just in a poetic mood or something). Thanks all. If there's anything I can do to help, let me know. *** Bug 101461 has been marked as a duplicate of this bug. *** Wassim, and I propose releasing this into RC4. Dejan? +1 The patch is not exactly a one-liner as I would like it, but it is seems important for 3.1. Please apply rigorous testing after applying. +1 tagged for the 4 pm build. thanks konrad. The patch has two strings that need to be tagged as NON-NLS. Please consider
doing it for 8pm.
lines 345, 360:
if(bundleLocation.endsWith(".jar")) {
*** Bug 101338 has been marked as a duplicate of this bug. *** |