Attachment 99406 Details for Bug 222309 – Additional places in the UI that need localized values

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Additional places in the UI that need localized values

222309Patch4.txt (text/plain), 47.26 KB, created by Dave Stevenson

on 2008-05-08 20:43:49 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Dave Stevenson

Created: 2008-05-08 20:43:49 EDT

Size: 47.26 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.equinox.p2.metadata.generator
>Index: src/org/eclipse/equinox/internal/provisional/p2/metadata/generator/MetadataGeneratorHelper.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.equinox/p2/bundles/org.eclipse.equinox.p2.metadata.generator/src/org/eclipse/equinox/internal/provisional/p2/metadata/generator/MetadataGeneratorHelper.java,v
>retrieving revision 1.47
>diff -u -r1.47 MetadataGeneratorHelper.java
>--- src/org/eclipse/equinox/internal/provisional/p2/metadata/generator/MetadataGeneratorHelper.java	2 May 2008 20:05:06 -0000	1.47
>+++ src/org/eclipse/equinox/internal/provisional/p2/metadata/generator/MetadataGeneratorHelper.java	9 May 2008 00:30:09 -0000
>@@ -12,8 +12,6 @@
> package org.eclipse.equinox.internal.provisional.p2.metadata.generator;
> 
> import java.io.*;
>-import java.net.URL;
>-import java.net.URLConnection;
> import java.util.*;
> import java.util.zip.ZipEntry;
> import java.util.zip.ZipFile;
>@@ -22,6 +20,7 @@
> import org.eclipse.equinox.internal.p2.metadata.ArtifactKey;
> import org.eclipse.equinox.internal.p2.metadata.InstallableUnit;
> import org.eclipse.equinox.internal.p2.metadata.generator.Activator;
>+import org.eclipse.equinox.internal.p2.metadata.generator.LocalizationHelper;
> import org.eclipse.equinox.internal.p2.metadata.generator.features.SiteCategory;
> import org.eclipse.equinox.internal.provisional.frameworkadmin.BundleInfo;
> import org.eclipse.equinox.internal.provisional.p2.artifact.repository.ArtifactDescriptor;
>@@ -112,7 +111,6 @@
> 
> 	static final String DEFAULT_BUNDLE_LOCALIZATION = "plugin"; //$NON-NLS-1$	
> 	static final String PROPERTIES_FILE_EXTENSION = ".properties"; //$NON-NLS-1$
>-	static final String MANIFEST_LOCALIZATIONS = "eclipse.p2.manifest.localizations"; //$NON-NLS-1$
> 
> 	static final String BUNDLE_ADVICE_FILE = "META-INF/p2.inf"; //$NON-NLS-1$
> 	static final String ADVICE_INSTRUCTIONS_PREFIX = "instructions."; //$NON-NLS-1$
>@@ -562,6 +560,13 @@
> 		Version version = new Version(feature.getVersion());
> 		iu.setVersion(version);
> 		iu.setUpdateDescriptor(MetadataFactory.createUpdateDescriptor(id, new VersionRange(new Version(0, 0, 0), true, new Version(feature.getVersion()), false), IUpdateDescriptor.NORMAL, null));
>+		iu.setProperty(IInstallableUnit.PROP_NAME, feature.getLabel());
>+		if (feature.getDescription() != null)
>+			iu.setProperty(IInstallableUnit.PROP_DESCRIPTION, feature.getDescription());
>+		if (feature.getDescriptionURL() != null)
>+			iu.setProperty(IInstallableUnit.PROP_DESCRIPTION_URL, feature.getDescriptionURL());
>+		if (feature.getProviderName() != null)
>+			iu.setProperty(IInstallableUnit.PROP_PROVIDER, feature.getProviderName());
> 		if (feature.getLicense() != null)
> 			iu.setLicense(new License(feature.getLicenseURL(), feature.getLicense()));
> 		if (feature.getCopyright() != null)
>@@ -585,7 +590,12 @@
> 			iu.setProperty(ECLIPSE_INSTALL_HANDLER_PROP, installHandlerProperty);
> 		}
> 
>-		iu.setCapabilities(new ProvidedCapability[] {createSelfCapability(id, version), FEATURE_CAPABILITY, MetadataFactory.createProvidedCapability(CAPABILITY_NS_UPDATE_FEATURE, feature.getId(), version)});
>+		// Create set of provided capabilities
>+		ArrayList providedCapabilities = new ArrayList();
>+		providedCapabilities.add(createSelfCapability(id, version));
>+		providedCapabilities.add(FEATURE_CAPABILITY);
>+		providedCapabilities.add(MetadataFactory.createProvidedCapability(CAPABILITY_NS_UPDATE_FEATURE, feature.getId(), version));
>+
> 		iu.setArtifacts(new IArtifactKey[] {createFeatureArtifactKey(feature.getId(), version.toString())});
> 
> 		if (isExploded) {
>@@ -596,6 +606,22 @@
> 			iu.addTouchpointData(MetadataFactory.createTouchpointData(touchpointData));
> 		}
> 
>+		Map localizations = feature.getLocalizations();
>+		if (localizations != null) {
>+			for (Iterator iter = localizations.keySet().iterator(); iter.hasNext();) {
>+				Locale locale = (Locale) iter.next();
>+				Properties translatedStrings = (Properties) localizations.get(locale);
>+				Enumeration propertyKeys = translatedStrings.propertyNames();
>+				while (propertyKeys.hasMoreElements()) {
>+					String nextKey = (String) propertyKeys.nextElement();
>+					iu.setProperty(locale.toString() + '.' + nextKey, translatedStrings.getProperty(nextKey));
>+				}
>+				providedCapabilities.add(makeTranslationCapability(id, locale));
>+			}
>+		}
>+
>+		iu.setCapabilities((ProvidedCapability[]) providedCapabilities.toArray(new ProvidedCapability[providedCapabilities.size()]));
>+
> 		if (extraProperties != null) {
> 			Enumeration e = extraProperties.propertyNames();
> 			while (e.hasMoreElements()) {
>@@ -624,6 +650,8 @@
> 			iu.setProperty(IInstallableUnit.PROP_DESCRIPTION, feature.getDescription());
> 		if (feature.getDescriptionURL() != null)
> 			iu.setProperty(IInstallableUnit.PROP_DESCRIPTION_URL, feature.getDescriptionURL());
>+		if (feature.getProviderName() != null)
>+			iu.setProperty(IInstallableUnit.PROP_PROVIDER, feature.getProviderName());
> 		if (feature.getLicense() != null)
> 			iu.setLicense(new License(feature.getLicenseURL(), feature.getLicense()));
> 		if (feature.getCopyright() != null)
>@@ -643,7 +671,26 @@
> 		// TODO: shouldn't the filter for the group be constructed from os, ws, arch, nl
> 		// 		 of the feature?
> 		// iu.setFilter(filter);
>-		iu.setCapabilities(new ProvidedCapability[] {createSelfCapability(id, version)});
>+
>+		// Create set of provided capabilities
>+		ArrayList providedCapabilities = new ArrayList();
>+		providedCapabilities.add(createSelfCapability(id, version));
>+
>+		Map localizations = feature.getLocalizations();
>+		if (localizations != null) {
>+			for (Iterator iter = localizations.keySet().iterator(); iter.hasNext();) {
>+				Locale locale = (Locale) iter.next();
>+				Properties translatedStrings = (Properties) localizations.get(locale);
>+				Enumeration propertyKeys = translatedStrings.propertyNames();
>+				while (propertyKeys.hasMoreElements()) {
>+					String nextKey = (String) propertyKeys.nextElement();
>+					iu.setProperty(locale.toString() + '.' + nextKey, translatedStrings.getProperty(nextKey));
>+				}
>+				providedCapabilities.add(makeTranslationCapability(id, locale));
>+			}
>+		}
>+
>+		iu.setCapabilities((ProvidedCapability[]) providedCapabilities.toArray(new ProvidedCapability[providedCapabilities.size()]));
> 
> 		if (extraProperties != null) {
> 			Enumeration e = extraProperties.propertyNames();
>@@ -663,10 +710,6 @@
> 		Version version = new Version(feature.getVersion());
> 		iu.setVersion(version);
> 		iu.setProperty(IInstallableUnit.PROP_NAME, feature.getLabel());
>-		if (feature.getDescription() != null)
>-			iu.setProperty(IInstallableUnit.PROP_DESCRIPTION, feature.getDescription());
>-		if (feature.getDescriptionURL() != null)
>-			iu.setProperty(IInstallableUnit.PROP_DESCRIPTION_URL, feature.getDescriptionURL());
> 		if (feature.getLicense() != null)
> 			iu.setLicense(new License(feature.getLicenseURL(), feature.getLicense()));
> 		if (feature.getCopyright() != null)
>@@ -1098,9 +1141,11 @@
> 
> 		if ("jar".equalsIgnoreCase(new Path(bundleLocation.getName()).getFileExtension()) && //$NON-NLS-1$
> 				bundleLocation.isFile()) {
>-			localizations = getJarManifestLocalization(bundleLocation, bundleLocalization, defaultLocale, bundleManifestValues);
>+			localizations = LocalizationHelper.getJarPropertyLocalizations(bundleLocation, bundleLocalization, defaultLocale, bundleManifestValues);
>+			//localizations = getJarManifestLocalization(bundleLocation, bundleLocalization, defaultLocale, bundleManifestValues);
> 		} else {
>-			localizations = getDirManifestLocalization(bundleLocation, bundleLocalization, defaultLocale, bundleManifestValues);
>+			localizations = LocalizationHelper.getDirPropertyLocalizations(bundleLocation, bundleLocalization, defaultLocale, bundleManifestValues);
>+			// localizations = getDirManifestLocalization(bundleLocation, bundleLocalization, defaultLocale, bundleManifestValues);
> 		}
> 
> 		return localizations;
>@@ -1129,165 +1174,14 @@
> 
> 		if ("jar".equalsIgnoreCase(new Path(bundleLocation.getName()).getFileExtension()) && //$NON-NLS-1$
> 				bundleLocation.isFile()) {
>-			localizations = getJarManifestLocalization(bundleLocation, hostBundleLocalization, defaultLocale, hostBundleManifestValues);
>+			localizations = LocalizationHelper.getJarPropertyLocalizations(bundleLocation, hostBundleLocalization, defaultLocale, hostBundleManifestValues);
>+			//localizations = getJarManifestLocalization(bundleLocation, hostBundleLocalization, defaultLocale, hostBundleManifestValues);
> 		} else {
>-			localizations = getDirManifestLocalization(bundleLocation, hostBundleLocalization, defaultLocale, hostBundleManifestValues);
>-		}
>-
>-		return localizations;
>-	}
>-
>-	private static Map getJarManifestLocalization(File bundleLocation, String bundleLocalization, Locale defaultLocale, String[] bundleManifestValues) {
>-		ZipFile jarFile = null;
>-		Map localizations = new HashMap(4);
>-		try {
>-			jarFile = new ZipFile(bundleLocation, ZipFile.OPEN_READ);
>-			for (Enumeration entries = jarFile.entries(); entries.hasMoreElements();) {
>-				ZipEntry nextEntry = (ZipEntry) entries.nextElement();
>-				String nextName = nextEntry.getName();
>-				String localeString = getLocaleString(nextName, bundleLocalization);
>-
>-				if (!nextEntry.isDirectory() && localeString != null) {
>-					Locale nextLocale = getLocale(localeString);
>-					InputStream stream = null;
>-					try {
>-						stream = jarFile.getInputStream(nextEntry);
>-						Properties properties = new Properties();
>-						properties.load(stream);
>-						Properties localizedStrings = getLocalizedProperties(bundleManifestValues, properties);
>-						if (localizedStrings.size() > 0) {
>-							localizations.put(nextLocale, localizedStrings);
>-							if (DEFAULT_LOCALE.equals(nextLocale) && defaultLocale != null) {
>-								localizations.put(nextLocale, localizedStrings);
>-							}
>-						}
>-					} finally {
>-						if (stream != null)
>-							stream.close();
>-					}
>-				}
>-			}
>-		} catch (IOException ioe) {
>-			ioe.printStackTrace();
>-		} finally {
>-			if (jarFile != null) {
>-				try {
>-					jarFile.close();
>-				} catch (IOException ioe) {
>-					// do nothing
>-				}
>-			}
>-		}
>-
>-		return localizations;
>-	}
>-
>-	private static Map getDirManifestLocalization(File bundleLocation, String bundleLocalization, Locale defaultLocale, String[] hostBundleManifestValues) {
>-		File localizationPath = new File(bundleLocation, bundleLocalization);
>-		File localizationDir = localizationPath.getParentFile();
>-		final String localizationFile = localizationPath.getName();
>-		MetadataGeneratorHelper foo = new MetadataGeneratorHelper();
>-		String[] localizationFiles = localizationDir.list(foo.new LocalizationFileFilter() {
>-			public boolean accept(File directory, String filename) {
>-				return (getLocaleString(filename, localizationFile) != null ? true : false);
>-			}
>-		});
>-
>-		HashMap localizations = null;
>-
>-		if (localizationFiles != null) {
>-			localizations = new HashMap(localizationFiles.length);
>-			for (int i = 0; i < localizationFiles.length; i++) {
>-				String nextFile = localizationFiles[i];
>-				Locale nextLocale = getLocale(getLocaleString(nextFile, localizationFile));
>-
>-				try {
>-					Properties properties = loadProperties(bundleLocation, nextFile);
>-					Properties localizedStrings = getLocalizedProperties(hostBundleManifestValues, properties);
>-					if (localizedStrings.size() > 0) {
>-						localizations.put(nextLocale, localizedStrings);
>-						if (DEFAULT_LOCALE.equals(nextLocale) && defaultLocale != null) {
>-							localizations.put(nextLocale, localizedStrings);
>-						}
>-					}
>-				} catch (IOException ioe) {
>-					ioe.printStackTrace();
>-				}
>-			}
>+			localizations = LocalizationHelper.getDirPropertyLocalizations(bundleLocation, hostBundleLocalization, defaultLocale, hostBundleManifestValues);
>+			// localizations = getDirManifestLocalization(bundleLocation, hostBundleLocalization, defaultLocale, hostBundleManifestValues);
> 		}
> 
> 		return localizations;
> 	}
> 
>-	private abstract class LocalizationFileFilter implements FilenameFilter {
>-
>-		public LocalizationFileFilter() {
>-			// Nothing to do
>-		}
>-
>-		/* (non-Javadoc)
>-		 * @see java.io.FilenameFilter#accept(java.io.File, java.lang.String)
>-		 */
>-		public abstract boolean accept(File directory, String filename);
>-	}
>-
>-	static public String getLocaleString(String filename, String filenamePrefix) {
>-		String localeString = null;
>-		if (filename.startsWith(filenamePrefix) && filename.endsWith(PROPERTIES_FILE_EXTENSION)) {
>-			if (filename.length() > filenamePrefix.length() + PROPERTIES_FILE_EXTENSION.length()) {
>-				localeString = filename.substring(filenamePrefix.length() + 1, filename.length() - PROPERTIES_FILE_EXTENSION.length());
>-			} else {
>-				localeString = ""; //$NON-NLS-1$
>-			}
>-		}
>-		return localeString;
>-	}
>-
>-	private static Properties loadProperties(File bundleLocation, String localizationFile) throws IOException {
>-		Properties result = new Properties();
>-		InputStream propertyStream = null;
>-		try {
>-			try {
>-				if (bundleLocation.isDirectory())
>-					propertyStream = new FileInputStream(new File(bundleLocation, localizationFile));
>-				else {
>-					URLConnection connection = new URL("jar:" + bundleLocation.toURL().toExternalForm() + "!/" + localizationFile).openConnection(); //$NON-NLS-1$ //$NON-NLS-2$
>-					connection.setUseCaches(false);
>-					propertyStream = connection.getInputStream();
>-				}
>-			} catch (FileNotFoundException e) {
>-				// if there is no messages file then just return;
>-				return result;
>-			}
>-			result.load(propertyStream);
>-		} finally {
>-			if (propertyStream != null)
>-				propertyStream.close();
>-		}
>-		return result;
>-	}
>-
>-	static private Locale getLocale(String localeString) {
>-		Locale locale = DEFAULT_LOCALE;
>-		if (localeString.length() == 5 && localeString.indexOf('_') == 2) {
>-			locale = new Locale(localeString.substring(0, 2), localeString.substring(3, 5));
>-		} else if (localeString.length() == 2) {
>-			locale = new Locale(localeString.substring(0, 2));
>-		}
>-		return locale;
>-	}
>-
>-	static private Properties getLocalizedProperties(String[] bundleManifestKeys, Properties properties) {
>-		Properties localizedProperties = new Properties();
>-		for (int i = 0; i < BUNDLE_LOCALIZED_PROPERTIES.length; i++) {
>-			String key = bundleManifestKeys[i];
>-			if (key != null) {
>-				String localizedValue = properties.getProperty(key);
>-				if (localizedValue != null)
>-					localizedProperties.put(key, localizedValue);
>-			}
>-		}
>-		return localizedProperties;
>-	}
>-
> }
>Index: src/org/eclipse/equinox/internal/provisional/p2/metadata/generator/Feature.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.equinox/p2/bundles/org.eclipse.equinox.p2.metadata.generator/src/org/eclipse/equinox/internal/provisional/p2/metadata/generator/Feature.java,v
>retrieving revision 1.2
>diff -u -r1.2 Feature.java
>--- src/org/eclipse/equinox/internal/provisional/p2/metadata/generator/Feature.java	11 Feb 2008 05:46:43 -0000	1.2
>+++ src/org/eclipse/equinox/internal/provisional/p2/metadata/generator/Feature.java	9 May 2008 00:30:09 -0000
>@@ -11,6 +11,7 @@
> package org.eclipse.equinox.internal.provisional.p2.metadata.generator;
> 
> import java.util.ArrayList;
>+import java.util.Map;
> 
> /**
>  * 
>@@ -43,6 +44,8 @@
> 
> 	private String location;
> 
>+	private Map localizations;
>+
> 	public Feature(String id, String version) {
> 		if (id == null)
> 			throw new IllegalArgumentException();
>@@ -50,14 +53,14 @@
> 		this.version = version;
> 	}
> 
>-	public void addDiscoverySite(String label, String url) {
>-		if (label == null && url == null)
>+	public void addDiscoverySite(String siteLabel, String url) {
>+		if (siteLabel == null && url == null)
> 			return;
> 
> 		if (this.discoverySites == null)
> 			this.discoverySites = new ArrayList();
> 
>-		URLEntry entry = new URLEntry(url, label);
>+		URLEntry entry = new URLEntry(url, siteLabel);
> 		this.discoverySites.add(entry);
> 	}
> 
>@@ -143,6 +146,10 @@
> 		return null;
> 	}
> 
>+	public Map getLocalizations() {
>+		return this.localizations;
>+	}
>+
> 	public String getLocation() {
> 		return this.location;
> 	}
>@@ -242,6 +249,10 @@
> 		this.license.setURL(licenseURL);
> 	}
> 
>+	public void setLocalizations(Map localizations) {
>+		this.localizations = localizations;
>+	}
>+
> 	public void setLocation(String location) {
> 		this.location = location;
> 	}
>@@ -263,6 +274,7 @@
> 	}
> 
> 	public void setURL(String value) {
>+		//
> 	}
> 
> 	public void setVersion(String version) {
>Index: src/org/eclipse/equinox/internal/p2/metadata/generator/features/FeatureParser.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.equinox/p2/bundles/org.eclipse.equinox.p2.metadata.generator/src/org/eclipse/equinox/internal/p2/metadata/generator/features/FeatureParser.java,v
>retrieving revision 1.19
>diff -u -r1.19 FeatureParser.java
>--- src/org/eclipse/equinox/internal/p2/metadata/generator/features/FeatureParser.java	30 Apr 2008 03:00:41 -0000	1.19
>+++ src/org/eclipse/equinox/internal/p2/metadata/generator/features/FeatureParser.java	9 May 2008 00:30:09 -0000
>@@ -12,7 +12,7 @@
> 
> import java.io.*;
> import java.net.URL;
>-import java.util.Properties;
>+import java.util.*;
> import java.util.jar.JarEntry;
> import java.util.jar.JarFile;
> import javax.xml.parsers.*;
>@@ -20,6 +20,7 @@
> import org.eclipse.core.runtime.Status;
> import org.eclipse.equinox.internal.p2.core.helpers.LogHelper;
> import org.eclipse.equinox.internal.p2.metadata.generator.Activator;
>+import org.eclipse.equinox.internal.p2.metadata.generator.LocalizationHelper;
> import org.eclipse.equinox.internal.provisional.p2.metadata.generator.Feature;
> import org.eclipse.equinox.internal.provisional.p2.metadata.generator.FeatureEntry;
> import org.eclipse.osgi.util.NLS;
>@@ -41,6 +42,7 @@
> 	private StringBuffer characters = null;
> 
> 	private Properties messages = null;
>+	private List messageKeys = null;
> 
> 	public FeatureParser() {
> 		this(true);
>@@ -87,17 +89,15 @@
> 		return result;
> 	}
> 
>-	private Properties loadProperties(File directory) {
>+	private void loadProperties(File directory, Properties properties) {
> 		//skip directories that don't contain a feature.properties file
> 		File file = new File(directory, "feature.properties"); //$NON-NLS-1$
> 		if (!file.exists())
>-			return null;
>+			return;
> 		try {
> 			InputStream input = new BufferedInputStream(new FileInputStream(file));
> 			try {
>-				Properties result = new Properties();
>-				result.load(input);
>-				return result;
>+				properties.load(input);
> 			} finally {
> 				if (input != null)
> 					input.close();
>@@ -105,19 +105,16 @@
> 		} catch (IOException e) {
> 			e.printStackTrace();
> 		}
>-		return null;
> 	}
> 
>-	private Properties loadProperties(JarFile jar) {
>+	private void loadProperties(JarFile jar, Properties properties) {
> 		JarEntry entry = jar.getJarEntry("feature.properties"); //$NON-NLS-1$
> 		if (entry == null)
>-			return null;
>+			return;
> 		try {
> 			InputStream input = new BufferedInputStream(jar.getInputStream(entry));
> 			try {
>-				Properties result = new Properties();
>-				result.load(input);
>-				return result;
>+				properties.load(input);
> 			} finally {
> 				if (input != null)
> 					input.close();
>@@ -125,7 +122,6 @@
> 		} catch (IOException e) {
> 			e.printStackTrace();
> 		}
>-		return null;
> 	}
> 
> 	private String localize(String value) {
>@@ -133,7 +129,9 @@
> 			return value;
> 		if (!value.startsWith("%")) //$NON-NLS-1$
> 			return value;
>-		return messages.getProperty(value.substring(1), value);
>+		String key = value.substring(1);
>+		messageKeys.add(key);
>+		return value;
> 	}
> 
> 	/**
>@@ -146,15 +144,23 @@
> 	public Feature parse(File location) {
> 		if (!location.exists())
> 			return null;
>+
>+		Feature feature = null;
>+		Properties properties = new Properties();
>+
> 		if (location.isDirectory()) {
> 			//skip directories that don't contain a feature.xml file
> 			File file = new File(location, "feature.xml"); //$NON-NLS-1$
> 			if (!file.exists())
> 				return null;
>-			Properties properties = loadProperties(location);
>+			loadProperties(location, properties);
> 			try {
> 				InputStream input = new BufferedInputStream(new FileInputStream(file));
>-				return parse(input, properties);
>+				feature = parse(input, properties);
>+				if (feature != null) {
>+					String[] keyStrings = (String[]) messageKeys.toArray(new String[messageKeys.size()]);
>+					feature.setLocalizations(LocalizationHelper.getDirPropertyLocalizations(location, "feature", null, keyStrings)); //$NON-NLS-1$
>+				}
> 			} catch (FileNotFoundException e) {
> 				e.printStackTrace();
> 			}
>@@ -162,12 +168,16 @@
> 			JarFile jar = null;
> 			try {
> 				jar = new JarFile(location);
>-				Properties properties = loadProperties(jar);
>+				loadProperties(jar, properties);
> 				JarEntry entry = jar.getJarEntry("feature.xml"); //$NON-NLS-1$
> 				if (entry == null)
> 					return null;
> 				InputStream input = new BufferedInputStream(jar.getInputStream(entry));
>-				return parse(input, properties);
>+				feature = parse(input, properties);
>+				if (feature != null) {
>+					String[] keyStrings = (String[]) messageKeys.toArray(new String[messageKeys.size()]);
>+					feature.setLocalizations(LocalizationHelper.getDirPropertyLocalizations(location, "feature", null, keyStrings)); //$NON-NLS-1$
>+				}
> 			} catch (IOException e) {
> 				e.printStackTrace();
> 			} catch (SecurityException e) {
>@@ -181,7 +191,7 @@
> 				}
> 			}
> 		}
>-		return null;
>+		return feature;
> 	}
> 
> 	/**
>@@ -190,6 +200,7 @@
> 	 */
> 	public Feature parse(InputStream in, Properties messages) {
> 		this.messages = messages;
>+		this.messageKeys = new ArrayList(messages.size());
> 		result = null;
> 		try {
> 			parser.parse(new InputSource(in), this);
>Index: src/org/eclipse/equinox/internal/p2/metadata/generator/LocalizationHelper.java
>===================================================================
>RCS file: src/org/eclipse/equinox/internal/p2/metadata/generator/LocalizationHelper.java
>diff -N src/org/eclipse/equinox/internal/p2/metadata/generator/LocalizationHelper.java
>--- /dev/null	1 Jan 1970 00:00:00 -0000
>+++ src/org/eclipse/equinox/internal/p2/metadata/generator/LocalizationHelper.java	1 Jan 1970 00:00:00 -0000
>@@ -0,0 +1,200 @@
>+/*******************************************************************************
>+ * Copyright (c) 2008 IBM Corporation and others.
>+ * All rights reserved. This program and the accompanying materials
>+ * are made available under the terms of the Eclipse Public License v1.0
>+ * which accompanies this distribution, and is available at
>+ * http://www.eclipse.org/legal/epl-v10.html
>+ *
>+ * Contributors:
>+ *     IBM Corporation - initial API and implementation
>+ *******************************************************************************/
>+package org.eclipse.equinox.internal.p2.metadata.generator;
>+
>+import java.io.*;
>+import java.net.URL;
>+import java.net.URLConnection;
>+import java.util.*;
>+import java.util.zip.ZipEntry;
>+import java.util.zip.ZipFile;
>+
>+/**
>+ * 	Helper functions supporting the processing of localized
>+ * 	property files.
>+ *
>+ */
>+public final class LocalizationHelper {
>+
>+	private static final String PROPERTIES_FILE_EXTENSION = ".properties"; //$NON-NLS-1$
>+	private static final Locale DEFAULT_LOCALE = new Locale("df", "LT"); //$NON-NLS-1$//$NON-NLS-2$
>+	private static LocalizationHelper instance = new LocalizationHelper();
>+
>+	// Extract the locale string from the properties file with the given filename
>+	// where the locale string follows the given prefix. For example, return "zh_HK"
>+	// from filename == "plugin_zh_HK.properties" and prefix == "plugin". 
>+	static public String getLocaleString(String filename, String prefix) {
>+		String localeString = null;
>+		if (filename.startsWith(prefix) && filename.endsWith(PROPERTIES_FILE_EXTENSION)) {
>+			if (filename.length() > prefix.length() + PROPERTIES_FILE_EXTENSION.length()) {
>+				localeString = filename.substring(prefix.length() + 1, filename.length() - PROPERTIES_FILE_EXTENSION.length());
>+			} else {
>+				localeString = ""; //$NON-NLS-1$
>+			}
>+		}
>+		return localeString;
>+	}
>+
>+	// Get the locale corresponding to the given locale string
>+	static public Locale getLocale(String localeString) {
>+		Locale locale = DEFAULT_LOCALE;
>+		if (localeString.length() == 5 && localeString.indexOf('_') == 2) {
>+			locale = new Locale(localeString.substring(0, 2), localeString.substring(3, 5));
>+		} else if (localeString.length() == 2) {
>+			locale = new Locale(localeString.substring(0, 2));
>+		}
>+		return locale;
>+	}
>+
>+	// For the given root directory and path to localization files within that directory
>+	// get a map from locale to property set for the localization property files.
>+	public static Map getDirPropertyLocalizations(File root, String localizationPath, Locale defaultLocale, String[] propertyKeys) {
>+		File fullPath = new File(root, localizationPath);
>+		File localizationDir = fullPath.getParentFile();
>+		final String localizationFile = fullPath.getName();
>+		String[] localizationFiles = LocalizationHelper.getLocalizationFiles(localizationDir, localizationFile);
>+
>+		HashMap localizations = null;
>+
>+		if (localizationFiles != null) {
>+			localizations = new HashMap(localizationFiles.length);
>+			for (int i = 0; i < localizationFiles.length; i++) {
>+				String nextFile = localizationFiles[i];
>+				Locale nextLocale = getLocale(LocalizationHelper.getLocaleString(nextFile, localizationFile));
>+
>+				try {
>+					Properties properties = loadProperties(root, nextFile);
>+					Properties localizedStrings = getLocalizedProperties(propertyKeys, properties);
>+					if (localizedStrings.size() > 0) {
>+						localizations.put(nextLocale, localizedStrings);
>+						if (DEFAULT_LOCALE.equals(nextLocale) && defaultLocale != null) {
>+							localizations.put(nextLocale, localizedStrings);
>+						}
>+					}
>+				} catch (IOException ioe) {
>+					ioe.printStackTrace();
>+				}
>+			}
>+		}
>+
>+		return localizations;
>+	}
>+
>+	public static Map getJarPropertyLocalizations(File root, String localizationPath, Locale defaultLocale, String[] propertyKeys) {
>+		ZipFile jarFile = null;
>+		Map localizations = new HashMap(4);
>+		try {
>+			jarFile = new ZipFile(root, ZipFile.OPEN_READ);
>+			for (Enumeration entries = jarFile.entries(); entries.hasMoreElements();) {
>+				ZipEntry nextEntry = (ZipEntry) entries.nextElement();
>+				String nextName = nextEntry.getName();
>+				String localeString = LocalizationHelper.getLocaleString(nextName, localizationPath);
>+
>+				if (!nextEntry.isDirectory() && localeString != null) {
>+					Locale nextLocale = LocalizationHelper.getLocale(localeString);
>+					InputStream stream = null;
>+					try {
>+						stream = jarFile.getInputStream(nextEntry);
>+						Properties properties = new Properties();
>+						properties.load(stream);
>+						Properties localizedStrings = LocalizationHelper.getLocalizedProperties(propertyKeys, properties);
>+						if (localizedStrings.size() > 0) {
>+							localizations.put(nextLocale, localizedStrings);
>+							if (DEFAULT_LOCALE.equals(nextLocale) && defaultLocale != null) {
>+								localizations.put(nextLocale, localizedStrings);
>+							}
>+						}
>+					} finally {
>+						if (stream != null)
>+							stream.close();
>+					}
>+				}
>+			}
>+		} catch (IOException ioe) {
>+			ioe.printStackTrace();
>+		} finally {
>+			if (jarFile != null) {
>+				try {
>+					jarFile.close();
>+				} catch (IOException ioe) {
>+					// do nothing
>+				}
>+			}
>+		}
>+
>+		return localizations;
>+	}
>+
>+	// Load a property set from given root and file with the given name
>+	private static Properties loadProperties(File root, String propertyFilename) throws IOException {
>+		Properties result = new Properties();
>+		InputStream propertyStream = null;
>+		try {
>+			try {
>+				if (root.isDirectory())
>+					propertyStream = new FileInputStream(new File(root, propertyFilename));
>+				else {
>+					URLConnection connection = new URL("jar:" + root.toURL().toExternalForm() + "!/" + propertyFilename).openConnection(); //$NON-NLS-1$ //$NON-NLS-2$
>+					connection.setUseCaches(false);
>+					propertyStream = connection.getInputStream();
>+				}
>+			} catch (FileNotFoundException e) {
>+				// if there is no messages file then just return;
>+				return result;
>+			}
>+			result.load(propertyStream);
>+		} finally {
>+			if (propertyStream != null)
>+				propertyStream.close();
>+		}
>+		return result;
>+	}
>+
>+	// Given a list of keys and the corresponding localized property set,
>+	// return a new property set with those keys and the localized values. 
>+	static public Properties getLocalizedProperties(String[] propertyKeys, Properties properties) {
>+		Properties localizedProperties = new Properties();
>+		for (int i = 0; i < propertyKeys.length; i++) {
>+			String key = propertyKeys[i];
>+			if (key != null) {
>+				String localizedValue = properties.getProperty(key);
>+				if (localizedValue != null)
>+					localizedProperties.put(key, localizedValue);
>+			}
>+		}
>+		return localizedProperties;
>+	}
>+
>+	public static String[] getLocalizationFiles(File localizationDir, final String filenamePrefix) {
>+		return localizationDir.list(instance.new FileFilter() {
>+			public boolean accept(File directory, String filename) {
>+				return (getLocaleString(filename, filenamePrefix) != null ? true : false);
>+			}
>+		});
>+	}
>+
>+	private abstract class FileFilter implements FilenameFilter {
>+
>+		public FileFilter() {
>+			// Nothing to do
>+		}
>+
>+		/* (non-Javadoc)
>+		 * @see java.io.FilenameFilter#accept(java.io.File, java.lang.String)
>+		 */
>+		public abstract boolean accept(File directory, String filename);
>+	}
>+
>+	private LocalizationHelper() {
>+		//
>+	}
>+
>+}
>#P org.eclipse.equinox.p2.ui
>Index: src/org/eclipse/equinox/internal/provisional/p2/ui/query/IUPropertyUtils.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.equinox/p2/bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/internal/provisional/p2/ui/query/IUPropertyUtils.java,v
>retrieving revision 1.3
>diff -u -r1.3 IUPropertyUtils.java
>--- src/org/eclipse/equinox/internal/provisional/p2/ui/query/IUPropertyUtils.java	1 Apr 2008 00:48:07 -0000	1.3
>+++ src/org/eclipse/equinox/internal/provisional/p2/ui/query/IUPropertyUtils.java	9 May 2008 00:30:11 -0000
>@@ -10,6 +10,7 @@
>  *******************************************************************************/
> package org.eclipse.equinox.internal.provisional.p2.ui.query;
> 
>+import java.net.URL;
> import java.util.*;
> import org.eclipse.equinox.internal.p2.core.helpers.ServiceHelper;
> import org.eclipse.equinox.internal.p2.ui.ProvUIActivator;
>@@ -24,12 +25,59 @@
> 	static final Locale DEFAULT_LOCALE = new Locale("df", "LT"); //$NON-NLS-1$//$NON-NLS-2$
> 	static final String NAMESPACE_IU_LOCALIZATION = "org.eclipse.equinox.p2.localization"; //$NON-NLS-1$
> 
>+	// Get the license in the default locale.
>+	public static License getLicense(IInstallableUnit iu) {
>+		return getLicense(iu, getCurrentLocale());
>+	}
>+
>+	// Get the copyright in the default locale.
>+	public static Copyright getCopyright(IInstallableUnit iu) {
>+		return getCopyright(iu, getCurrentLocale());
>+	}
>+
>+	// Get a property in the default locale
>+	public static String getIUProperty(IInstallableUnit iu, String propertyKey) {
>+		return getIUProperty(iu, propertyKey, getCurrentLocale());
>+	}
>+
>+	public static License getLicense(IInstallableUnit iu, Locale locale) {
>+		License license = iu.getLicense();
>+		String body = (license != null ? license.getBody() : null);
>+		if (body == null || body.length() <= 1 || body.charAt(0) != '%')
>+			return license;
>+		final String actualKey = body.substring(1); // Strip off the %
>+		body = getLocalizedIUProperty(iu, actualKey, locale);
>+		URL url = license.getURL();
>+		return new License((url != null ? url.toExternalForm() : null), body);
>+	}
>+
>+	public static Copyright getCopyright(IInstallableUnit iu, Locale locale) {
>+		Copyright copyright = iu.getCopyright();
>+		String body = (copyright != null ? copyright.getBody() : null);
>+		if (body == null || body.length() <= 1 || body.charAt(0) != '%')
>+			return copyright;
>+		final String actualKey = body.substring(1); // Strip off the %
>+		body = getLocalizedIUProperty(iu, actualKey, locale);
>+		URL url = copyright.getURL();
>+		return new Copyright((url != null ? url.toExternalForm() : null), body);
>+	}
>+
> 	public static String getIUProperty(IInstallableUnit iu, String propertyKey, Locale locale) {
> 		String value = iu.getProperty(propertyKey);
> 		if (value == null || value.length() <= 1 || value.charAt(0) != '%')
> 			return value;
> 		// else have a localizable property
> 		final String actualKey = value.substring(1); // Strip off the %
>+		return getLocalizedIUProperty(iu, actualKey, locale);
>+	}
>+
>+	private static String getLocalizedIUProperty(IInstallableUnit iu, String actualKey, Locale locale) {
>+		// Short circuit query if iu provides value for matching locale	
>+		String localizedKey = makeLocalizedKey(actualKey, locale.toString());
>+		String localizedValue = iu.getProperty(localizedKey);
>+		if (localizedValue != null)
>+			return localizedValue;
>+
> 		final List locales = buildLocaleVariants(locale);
> 		final IInstallableUnit theUnit = iu;
> 
>@@ -89,12 +137,15 @@
> 			}
> 		}
> 
>-		String defaultKey = makeLocalizedKey(actualKey, DEFAULT_LOCALE.toString());
>-		String defaultValue = iu.getProperty(defaultKey);
>-		if (defaultValue != null)
>-			return defaultValue;
>+		for (Iterator iter = locales.iterator(); iter.hasNext();) {
>+			String nextLocale = (String) iter.next();
>+			String localeKey = makeLocalizedKey(actualKey, nextLocale);
>+			String nextValue = iu.getProperty(localeKey);
>+			if (nextValue != null)
>+				return nextValue;
>+		}
> 
>-		return value;
>+		return actualKey;
> 	}
> 
> 	/**
>@@ -111,7 +162,7 @@
> 			nl = nl.substring(0, lastSeparator);
> 		}
> 		// Add the default locale (most general)
>-		result.add(DEFAULT_LOCALE);
>+		result.add(DEFAULT_LOCALE.toString());
> 		return result;
> 	}
> 
>@@ -119,4 +170,8 @@
> 		return localeImage + '.' + actualKey;
> 	}
> 
>+	private static Locale getCurrentLocale() {
>+		return Locale.getDefault();
>+	}
>+
> }
>Index: src/org/eclipse/equinox/internal/p2/ui/dialogs/ProfileModificationWizardPage.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.equinox/p2/bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/internal/p2/ui/dialogs/ProfileModificationWizardPage.java,v
>retrieving revision 1.25
>diff -u -r1.25 ProfileModificationWizardPage.java
>--- src/org/eclipse/equinox/internal/p2/ui/dialogs/ProfileModificationWizardPage.java	7 May 2008 15:18:20 -0000	1.25
>+++ src/org/eclipse/equinox/internal/p2/ui/dialogs/ProfileModificationWizardPage.java	9 May 2008 00:30:11 -0000
>@@ -25,6 +25,7 @@
> import org.eclipse.equinox.internal.provisional.p2.ui.ProvUI;
> import org.eclipse.equinox.internal.provisional.p2.ui.ProvisioningOperationRunner;
> import org.eclipse.equinox.internal.provisional.p2.ui.operations.ProfileModificationOperation;
>+import org.eclipse.equinox.internal.provisional.p2.ui.query.IUPropertyUtils;
> import org.eclipse.equinox.internal.provisional.p2.ui.viewers.*;
> import org.eclipse.jface.dialogs.Dialog;
> import org.eclipse.jface.dialogs.IMessageProvider;
>@@ -329,7 +330,8 @@
> 	}
> 
> 	protected String getIUDescription(IInstallableUnit iu) {
>-		String description = iu.getProperty(IInstallableUnit.PROP_DESCRIPTION);
>+		// Get the iu description in the default locale
>+		String description = IUPropertyUtils.getIUProperty(iu, IInstallableUnit.PROP_DESCRIPTION);
> 		if (description == null)
> 			description = ""; //$NON-NLS-1$
> 		return description;
>Index: src/org/eclipse/equinox/internal/p2/ui/viewers/IUDetailsLabelProvider.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.equinox/p2/bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/internal/p2/ui/viewers/IUDetailsLabelProvider.java,v
>retrieving revision 1.7
>diff -u -r1.7 IUDetailsLabelProvider.java
>--- src/org/eclipse/equinox/internal/p2/ui/viewers/IUDetailsLabelProvider.java	8 Apr 2008 19:58:10 -0000	1.7
>+++ src/org/eclipse/equinox/internal/p2/ui/viewers/IUDetailsLabelProvider.java	9 May 2008 00:30:11 -0000
>@@ -22,6 +22,7 @@
> import org.eclipse.equinox.internal.provisional.p2.ui.ProvUI;
> import org.eclipse.equinox.internal.provisional.p2.ui.ProvUIImages;
> import org.eclipse.equinox.internal.provisional.p2.ui.model.IUElement;
>+import org.eclipse.equinox.internal.provisional.p2.ui.query.IUPropertyUtils;
> import org.eclipse.equinox.internal.provisional.p2.ui.viewers.IUColumnConfig;
> import org.eclipse.jface.viewers.*;
> import org.eclipse.osgi.util.NLS;
>@@ -88,7 +89,8 @@
> 			case IUColumnConfig.COLUMN_ID :
> 				return iu.getId();
> 			case IUColumnConfig.COLUMN_NAME :
>-				String name = iu.getProperty(IInstallableUnit.PROP_NAME);
>+				// Get the iu name in the current locale
>+				String name = IUPropertyUtils.getIUProperty(iu, IInstallableUnit.PROP_NAME);
> 				if (name != null)
> 					return name;
> 				return BLANK;
>Index: src/org/eclipse/equinox/internal/provisional/p2/ui/dialogs/IULicensePropertyPage.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.equinox/p2/bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/internal/provisional/p2/ui/dialogs/IULicensePropertyPage.java,v
>retrieving revision 1.5
>diff -u -r1.5 IULicensePropertyPage.java
>--- src/org/eclipse/equinox/internal/provisional/p2/ui/dialogs/IULicensePropertyPage.java	29 Feb 2008 00:47:38 -0000	1.5
>+++ src/org/eclipse/equinox/internal/provisional/p2/ui/dialogs/IULicensePropertyPage.java	9 May 2008 00:30:11 -0000
>@@ -14,6 +14,7 @@
> import org.eclipse.equinox.internal.p2.ui.dialogs.IUPropertyPage;
> import org.eclipse.equinox.internal.provisional.p2.metadata.IInstallableUnit;
> import org.eclipse.equinox.internal.provisional.p2.metadata.License;
>+import org.eclipse.equinox.internal.provisional.p2.ui.query.IUPropertyUtils;
> import org.eclipse.osgi.util.NLS;
> import org.eclipse.swt.SWT;
> import org.eclipse.swt.events.SelectionAdapter;
>@@ -30,8 +31,8 @@
> public class IULicensePropertyPage extends IUPropertyPage {
> 
> 	protected Control createIUPage(Composite parent, IInstallableUnit iu) {
>-
>-		final License license = iu.getLicense();
>+		// Get the license in the default locale
>+		final License license = IUPropertyUtils.getLicense(iu);
> 		if (license != null && license.getBody().length() > 0) {
> 			Composite composite = new Composite(parent, SWT.NONE);
> 			GridLayout layout = new GridLayout();
>Index: src/org/eclipse/equinox/internal/provisional/p2/ui/dialogs/AvailableIUPatternFilter.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.equinox/p2/bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/internal/provisional/p2/ui/dialogs/AvailableIUPatternFilter.java,v
>retrieving revision 1.1
>diff -u -r1.1 AvailableIUPatternFilter.java
>--- src/org/eclipse/equinox/internal/provisional/p2/ui/dialogs/AvailableIUPatternFilter.java	9 Apr 2008 17:52:06 -0000	1.1
>+++ src/org/eclipse/equinox/internal/provisional/p2/ui/dialogs/AvailableIUPatternFilter.java	9 May 2008 00:30:11 -0000
>@@ -13,6 +13,7 @@
> import org.eclipse.equinox.internal.provisional.p2.metadata.IInstallableUnit;
> import org.eclipse.equinox.internal.provisional.p2.ui.model.CategoryElement;
> import org.eclipse.equinox.internal.provisional.p2.ui.model.IUElement;
>+import org.eclipse.equinox.internal.provisional.p2.ui.query.IUPropertyUtils;
> import org.eclipse.equinox.internal.provisional.p2.ui.viewers.IUColumnConfig;
> import org.eclipse.jface.viewers.Viewer;
> import org.eclipse.ui.dialogs.PatternFilter;
>@@ -89,7 +90,8 @@
> 		if (element instanceof IUElement) {
> 			IInstallableUnit iu = ((IUElement) element).getIU();
> 			if (checkName) {
>-				text = iu.getProperty(IInstallableUnit.PROP_NAME);
>+				// Get the iu name in the default locale
>+				text = IUPropertyUtils.getIUProperty(iu, IInstallableUnit.PROP_NAME);
> 				if (text != null && wordMatches(text))
> 					return true;
> 			}
>Index: src/org/eclipse/equinox/internal/provisional/p2/ui/dialogs/IUCopyrightPropertyPage.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.equinox/p2/bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/internal/provisional/p2/ui/dialogs/IUCopyrightPropertyPage.java,v
>retrieving revision 1.4
>diff -u -r1.4 IUCopyrightPropertyPage.java
>--- src/org/eclipse/equinox/internal/provisional/p2/ui/dialogs/IUCopyrightPropertyPage.java	14 Feb 2008 08:30:37 -0000	1.4
>+++ src/org/eclipse/equinox/internal/provisional/p2/ui/dialogs/IUCopyrightPropertyPage.java	9 May 2008 00:30:11 -0000
>@@ -14,6 +14,7 @@
> import org.eclipse.equinox.internal.p2.ui.dialogs.IUPropertyPage;
> import org.eclipse.equinox.internal.provisional.p2.metadata.Copyright;
> import org.eclipse.equinox.internal.provisional.p2.metadata.IInstallableUnit;
>+import org.eclipse.equinox.internal.provisional.p2.ui.query.IUPropertyUtils;
> import org.eclipse.osgi.util.NLS;
> import org.eclipse.swt.SWT;
> import org.eclipse.swt.events.SelectionAdapter;
>@@ -30,7 +31,8 @@
> public class IUCopyrightPropertyPage extends IUPropertyPage {
> 
> 	protected Control createIUPage(Composite parent, IInstallableUnit iu) {
>-		final Copyright copyright = iu.getCopyright();
>+		// Get the copyright in the current locale
>+		final Copyright copyright = IUPropertyUtils.getCopyright(iu);
> 		if (copyright != null && copyright.getBody().length() > 0) {
> 			Composite composite = new Composite(parent, SWT.NONE);
> 			GridLayout layout = new GridLayout();
>Index: src/org/eclipse/equinox/internal/provisional/p2/ui/dialogs/IUGeneralInfoPropertyPage.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.equinox/p2/bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/internal/provisional/p2/ui/dialogs/IUGeneralInfoPropertyPage.java,v
>retrieving revision 1.6
>diff -u -r1.6 IUGeneralInfoPropertyPage.java
>--- src/org/eclipse/equinox/internal/provisional/p2/ui/dialogs/IUGeneralInfoPropertyPage.java	1 Apr 2008 00:48:08 -0000	1.6
>+++ src/org/eclipse/equinox/internal/provisional/p2/ui/dialogs/IUGeneralInfoPropertyPage.java	9 May 2008 00:30:11 -0000
>@@ -12,7 +12,6 @@
> 
> import java.net.MalformedURLException;
> import java.net.URL;
>-import java.util.Locale;
> import org.eclipse.equinox.internal.p2.ui.ProvUIMessages;
> import org.eclipse.equinox.internal.p2.ui.dialogs.IUPropertyPage;
> import org.eclipse.equinox.internal.provisional.p2.metadata.IInstallableUnit;
>@@ -54,18 +53,18 @@
> 		layout.marginHeight = 0;
> 		composite.setLayout(layout);
> 		composite.setLayoutData(new GridData(GridData.FILL_HORIZONTAL));
>-		Locale currentLocale = Locale.getDefault();
>-		addField(composite, ProvUIMessages.IUGeneralInfoPropertyPage_NameLabel, IUPropertyUtils.getIUProperty(iu, IInstallableUnit.PROP_NAME, currentLocale));
>+		// Get general info in the default locale
>+		addField(composite, ProvUIMessages.IUGeneralInfoPropertyPage_NameLabel, IUPropertyUtils.getIUProperty(iu, IInstallableUnit.PROP_NAME));
> 		addField(composite, ProvUIMessages.IUGeneralInfoPropertyPage_IdentifierLabel, iu.getId());
> 		addField(composite, ProvUIMessages.IUGeneralInfoPropertyPage_VersionLabel, iu.getVersion().toString());
>-		addField(composite, ProvUIMessages.IUGeneralInfoPropertyPage_ProviderLabel, IUPropertyUtils.getIUProperty(iu, IInstallableUnit.PROP_PROVIDER, currentLocale));
>-		addField(composite, ProvUIMessages.IUGeneralInfoPropertyPage_ContactLabel, IUPropertyUtils.getIUProperty(iu, IInstallableUnit.PROP_CONTACT, currentLocale));
>+		addField(composite, ProvUIMessages.IUGeneralInfoPropertyPage_ProviderLabel, IUPropertyUtils.getIUProperty(iu, IInstallableUnit.PROP_PROVIDER));
>+		addField(composite, ProvUIMessages.IUGeneralInfoPropertyPage_ContactLabel, IUPropertyUtils.getIUProperty(iu, IInstallableUnit.PROP_CONTACT));
> 
> 	}
> 
> 	private void createDescriptionSection(Composite parent, IInstallableUnit iu) {
>-		Locale currentLocale = Locale.getDefault();
>-		String description = IUPropertyUtils.getIUProperty(iu, IInstallableUnit.PROP_DESCRIPTION, currentLocale);
>+		// Get the iu description in the default locale
>+		String description = IUPropertyUtils.getIUProperty(iu, IInstallableUnit.PROP_DESCRIPTION);
> 		if (description != null && description.length() > 0) {
> 			Group group = new Group(parent, SWT.NONE);
> 			group.setText(ProvUIMessages.IUGeneralInfoPropertyPage_DescriptionLabel);
>Index: src/org/eclipse/equinox/internal/p2/ui/PlanStatusHelper.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.equinox/p2/bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/internal/p2/ui/PlanStatusHelper.java,v
>retrieving revision 1.1
>diff -u -r1.1 PlanStatusHelper.java
>--- src/org/eclipse/equinox/internal/p2/ui/PlanStatusHelper.java	7 May 2008 15:18:20 -0000	1.1
>+++ src/org/eclipse/equinox/internal/p2/ui/PlanStatusHelper.java	9 May 2008 00:30:11 -0000
>@@ -17,6 +17,7 @@
> import org.eclipse.equinox.internal.provisional.p2.engine.Operand;
> import org.eclipse.equinox.internal.provisional.p2.metadata.IInstallableUnit;
> import org.eclipse.equinox.internal.provisional.p2.ui.IStatusCodes;
>+import org.eclipse.equinox.internal.provisional.p2.ui.query.IUPropertyUtils;
> import org.eclipse.osgi.util.NLS;
> 
> /**
>@@ -83,7 +84,8 @@
> 	private static String getIUString(IInstallableUnit iu) {
> 		if (iu == null)
> 			return ProvUIMessages.PlanStatusHelper_Items;
>-		String name = iu.getProperty(IInstallableUnit.PROP_NAME);
>+		// Get the iu name in the default locale
>+		String name = IUPropertyUtils.getIUProperty(iu, IInstallableUnit.PROP_NAME);
> 		if (name != null)
> 			return name;
> 		return iu.getId();
>Index: src/org/eclipse/equinox/internal/provisional/p2/ui/viewers/IUComparator.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.equinox/p2/bundles/org.eclipse.equinox.p2.ui/src/org/eclipse/equinox/internal/provisional/p2/ui/viewers/IUComparator.java,v
>retrieving revision 1.4
>diff -u -r1.4 IUComparator.java
>--- src/org/eclipse/equinox/internal/provisional/p2/ui/viewers/IUComparator.java	25 Feb 2008 18:35:34 -0000	1.4
>+++ src/org/eclipse/equinox/internal/provisional/p2/ui/viewers/IUComparator.java	9 May 2008 00:30:11 -0000
>@@ -12,6 +12,7 @@
> 
> import org.eclipse.equinox.internal.provisional.p2.metadata.IInstallableUnit;
> import org.eclipse.equinox.internal.provisional.p2.ui.ProvUI;
>+import org.eclipse.equinox.internal.provisional.p2.ui.query.IUPropertyUtils;
> import org.eclipse.jface.viewers.Viewer;
> import org.eclipse.jface.viewers.ViewerComparator;
> 
>@@ -33,10 +34,11 @@
> 
> 		String key1, key2;
> 		if (key == IU_NAME) {
>-			key1 = iu1.getProperty(IInstallableUnit.PROP_NAME);
>+			// Compare the iu names in the default locale
>+			key1 = IUPropertyUtils.getIUProperty(iu1, IInstallableUnit.PROP_NAME);
> 			if (key1 == null)
> 				key1 = ""; //$NON-NLS-1$
>-			key2 = iu2.getProperty(IInstallableUnit.PROP_NAME);
>+			key2 = IUPropertyUtils.getIUProperty(iu2, IInstallableUnit.PROP_NAME);
> 			if (key2 == null)
> 				key2 = ""; //$NON-NLS-1$
> 		} else {

Actions: View | Diff

Attachments on bug 222309: 93829 | 94301 | 99221 | 99406 | 100028 | 100281