Attachment 96715 Details for Bug 222750 – Proposed patch

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Proposed patch

org.eclipse.ui.workbench_HEAD.patch (text/plain), 2.01 KB, created by Marco Maccaferri

on 2008-04-19 15:44:26 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Marco Maccaferri

Created: 2008-04-19 15:44:26 EDT

Size: 2.01 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.ui.workbench
>Index: Eclipse UI/org/eclipse/ui/internal/PerspectiveHelper.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/PerspectiveHelper.java,v
>retrieving revision 1.46
>diff -u -r1.46 PerspectiveHelper.java
>--- Eclipse UI/org/eclipse/ui/internal/PerspectiveHelper.java	24 Mar 2008 19:21:57 -0000	1.46
>+++ Eclipse UI/org/eclipse/ui/internal/PerspectiveHelper.java	19 Apr 2008 10:14:12 -0000
>@@ -751,13 +751,21 @@
>                     	inTrim = perspective.getFastViewManager().getFastViews(folder.getID()).size() > 0;
>                     	
>                     if (childVisible == 0 && !inTrim) {
>-                        ILayoutContainer parentContainer = folder
>-                                .getContainer();
>-                        for (int i = 0; i < children.length; i++) {
>-                            folder.remove(children[i]);
>-                            parentContainer.add(children[i]);
>-                        }
>-                        hasChildren = false;
>+
>+                        // PR 1GDFVBY: ViewStack not disposed when page
>+                        // closed.
>+                        if (oldContainer instanceof ViewStack) {
>+							((ViewStack) oldContainer).dispose();
>+						}
>+
>+                        // replace the real container with a
>+                        // ContainerPlaceholder
>+                        ILayoutContainer parentContainer = folder.getContainer();
>+                        ContainerPlaceholder placeholder = new ContainerPlaceholder(
>+                        		folder.getID());
>+                        placeholder.setRealContainer(oldContainer);
>+                        parentContainer.replace(folder, placeholder);
>+
>                     } else if (childVisible == 1) {
>                         LayoutTree layout = mainLayout.getLayoutTree();
>                         layout = layout.find(folder);

Actions: View | Diff

Attachments on bug 222750: 92570 | 96715 | 97259