Attachment 91997 Details for Bug 219911 – Patch

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Patch

patch219911.txt (text/plain), 3.81 KB, created by Frank Becker

on 2008-03-09 17:39:55 EDT

(hide)

Description:

Filename:

MIME Type:

Creator: Frank Becker

Created: 2008-03-09 17:39:55 EDT

Size: 3.81 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.mylyn.bugzilla.ui
>Index: src/org/eclipse/mylyn/internal/bugzilla/ui/editor/BugzillaTaskEditor.java
>===================================================================
>RCS file: /cvsroot/tools/org.eclipse.mylyn/org.eclipse.mylyn.bugzilla.ui/src/org/eclipse/mylyn/internal/bugzilla/ui/editor/BugzillaTaskEditor.java,v
>retrieving revision 1.93
>diff -u -r1.93 BugzillaTaskEditor.java
>--- src/org/eclipse/mylyn/internal/bugzilla/ui/editor/BugzillaTaskEditor.java	14 Feb 2008 02:00:41 -0000	1.93
>+++ src/org/eclipse/mylyn/internal/bugzilla/ui/editor/BugzillaTaskEditor.java	9 Mar 2008 21:30:37 -0000
>@@ -73,6 +73,8 @@
>  * @author Jeff Pound (Attachment work)
>  */
> public class BugzillaTaskEditor extends AbstractRepositoryTaskEditor {
>+	
>+	private Button defaultAssignee;
> 
> 	private static final String LABEL_TIME_TRACKING = "Bugzilla Time Tracking";
> 
>@@ -651,7 +653,7 @@
> 				taskData.setAttributeValue(BugzillaReportElement.SET_DEFAULT_ASSIGNEE.getKeyString(), "0");
> 				attribute = taskData.getAttribute(BugzillaReportElement.SET_DEFAULT_ASSIGNEE.getKeyString());
> 			}
>-			addButtonField(peopleComposite, attribute, SWT.CHECK);
>+			defaultAssignee = addButtonField(peopleComposite, attribute, SWT.CHECK);
> 		}
> 	}
> 
>@@ -666,6 +668,35 @@
> 				attribute.setValue(BugzillaUiPlugin.formatTextToLineWrap(attribute.getValue(), true));
> 			}
> 		}
>+
>+		if (attribute.getId().equals(BugzillaReportElement.PRODUCT.getKeyString()) || attribute.getId().equals(BugzillaReportElement.COMPONENT.getKeyString())) {
>+			String bugzillaVersion;
>+			try {
>+				bugzillaVersion = BugzillaCorePlugin.getRepositoryConfiguration(repository, false).getInstallVersion();
>+			} catch (CoreException e1) {
>+				// ignore
>+				bugzillaVersion = "2.18";
>+			}
>+			if (bugzillaVersion.compareTo("3.1") < 0) {
>+				for (int i = 0; i < radios.length; i++) {
>+					RepositoryOperation o = taskData.getOperation(radios[i].getText());
>+					if (o.getKnobName().equals(BUGZILLA_OPERATION.reassignbycomponent.toString())) {
>+						radios[i].setSelection(true); 
>+						taskData.setSelectedOperation(o);
>+						markDirty(true);
>+					} else {
>+						radios[i].setSelection(false);
>+					}
>+				}
>+			} else {
>+				RepositoryTaskAttribute defaultAssignee_attribute = taskData.getAttribute(BugzillaReportElement.SET_DEFAULT_ASSIGNEE.getKeyString());
>+				if (defaultAssignee_attribute != null) {
>+					taskData.setAttributeValue(BugzillaReportElement.SET_DEFAULT_ASSIGNEE.getKeyString(), "1");
>+					defaultAssignee.setSelection(true);
>+					super.attributeChanged(defaultAssignee_attribute);
>+				}
>+			}
>+		}
> 		return super.attributeChanged(attribute);
> 	}
> 
>#P org.eclipse.mylyn.tasks.ui
>Index: src/org/eclipse/mylyn/tasks/ui/editors/AbstractRepositoryTaskEditor.java
>===================================================================
>RCS file: /cvsroot/tools/org.eclipse.mylyn/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/tasks/ui/editors/AbstractRepositoryTaskEditor.java,v
>retrieving revision 1.280
>diff -u -r1.280 AbstractRepositoryTaskEditor.java
>--- src/org/eclipse/mylyn/tasks/ui/editors/AbstractRepositoryTaskEditor.java	1 Mar 2008 21:38:51 -0000	1.280
>+++ src/org/eclipse/mylyn/tasks/ui/editors/AbstractRepositoryTaskEditor.java	9 Mar 2008 21:30:40 -0000
>@@ -1071,8 +1071,10 @@
> 					public void widgetSelected(SelectionEvent event) {
> 						if (attributeCombo.getSelectionIndex() > -1) {
> 							String sel = attributeCombo.getItem(attributeCombo.getSelectionIndex());
>-							attribute.setValue(sel);
>-							attributeChanged(attribute);
>+							if (!attribute.getValue().equals(sel)) {
>+								attribute.setValue(sel);
>+								attributeChanged(attribute);
>+							}
> 							attributeCombo.clearSelection();
> 						}
> 					}
>@@ -3149,7 +3151,7 @@
> 		return outlinePage;
> 	}
> 
>-	private Button[] radios;
>+	protected Button[] radios;
> 
> 	private Control[] radioOptions;
>

Actions: View | Diff

Attachments on bug 219911: 91997 | 91998