Attachment 91870 Details for Bug 201412 – Close process input/output named pipes

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Close process input/output named pipes

namedPipeListener_patch.txt (text/plain), 2.77 KB, created by Stanislav Polevic

on 2008-03-07 08:37:03 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Stanislav Polevic

Created: 2008-03-07 08:37:03 EST

Size: 2.77 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.tptp.platform.agentcontroller
>Index: src-native-new/src/agents/tptpProcessController/TPTPProcessController.cpp
>===================================================================
>RCS file: /cvsroot/tptp/platform/org.eclipse.tptp.platform.agentcontroller/src-native-new/src/agents/tptpProcessController/TPTPProcessController.cpp,v
>retrieving revision 1.62.4.2
>diff -u -r1.62.4.2 TPTPProcessController.cpp
>--- src-native-new/src/agents/tptpProcessController/TPTPProcessController.cpp	27 Nov 2006 19:10:55 -0000	1.62.4.2
>+++ src-native-new/src/agents/tptpProcessController/TPTPProcessController.cpp	7 Mar 2008 13:27:54 -0000
>@@ -1007,9 +1007,9 @@
> 		return;
> 	}
> 
>-	if (console->in) CLOSE_TPTP_HANDLE(console->in);
>-	if (console->out) CLOSE_TPTP_HANDLE(console->out);
>-	if (console->err) CLOSE_TPTP_HANDLE(console->err);
>+	if (console->in) cleanPipeUp(&console->in);
>+	if (console->out) cleanPipeUp(&console->out);
>+	if (console->err) cleanPipeUp(&console->err);
> 	return;
> }
> 
>Index: src-native-new/src/transport/namedPipeTL/NamedPipeListener.c
>===================================================================
>RCS file: /cvsroot/tptp/platform/org.eclipse.tptp.platform.agentcontroller/src-native-new/src/transport/namedPipeTL/NamedPipeListener.c,v
>retrieving revision 1.42.4.2
>diff -u -r1.42.4.2 NamedPipeListener.c
>--- src-native-new/src/transport/namedPipeTL/NamedPipeListener.c	27 Nov 2006 19:10:54 -0000	1.42.4.2
>+++ src-native-new/src/transport/namedPipeTL/NamedPipeListener.c	7 Mar 2008 13:27:54 -0000
>@@ -358,10 +358,13 @@
> 				else if (rc == TPTP_PIPE_HAS_ENDED)
> 				{
> 					/* this is expected and normal */
>+					TPTP_LOG_DEBUG_MSG(pThreadData->pRequestBlk->pServerData, "Console: End of pipe recieved - exiting");
>+					pThreadData->threadStatus = TPTP_IDLE_THREAD;
> 				}
> 				else
> 				{
> 					TPTP_LOG_DEBUG_MSG2(pThreadData->pRequestBlk->pServerData, "Console: Error reading pipe(%s) rc(%d).", uuid, rc) ;
>+					pThreadData->threadStatus = TPTP_IDLE_THREAD;
> 				}
> 
> 				if (rc > 0)
>@@ -384,7 +387,18 @@
> 		}
> 	}
> 
>-    tptp_initializeSemaphore(& pRequestDataBlock->hasProcessIdSemaphore);
>+	TPTP_LOG_DEBUG_MSG(pThreadData->pRequestBlk->pServerData, "Console: Closing named pipes") ;
>+    
>+	rc = disconnectFromNamedPipe(consoleHandle);
>+	TPTP_LOG_DEBUG_MSG2 (pThreadData->pRequestBlk->pServerData, "Disconnect from named pipe %d, error %d", rc, GetLastError());
>+	cleanPipeUp(&consoleHandle);
>+
>+	disconnectFromNamedPipe(pRequestDataBlock->consoleInputPipe);
>+	cleanPipeUp(&pRequestDataBlock->consoleInputPipe);
>+
>+	tptp_deleteSemaphore(&pRequestDataBlock->hasProcessIdSemaphore);
>+
>+	TPTP_LOG_DEBUG_MSG(pThreadData->pRequestBlk->pServerData, "Stdout/stderr listening thread exited");
> 
> 	free(pThreadData) ;
>

Actions: View | Diff

Attachments on bug 201412: 90772 | 90923 | 91870 | 95510 | 95518