Attachment 91469 Details for Bug 211101 – Patch for checkbox as expansion control for "auto tracking" section

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Patch for checkbox as expansion control for "auto tracking" section

clipboard.txt (text/plain), 4.14 KB, created by Helen Bershadskaya

on 2008-03-03 21:45:41 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Helen Bershadskaya

Created: 2008-03-03 21:45:41 EST

Size: 4.14 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.mylyn.xplanner.ui
>Index: src/org/eclipse/mylyn/xplanner/ui/editor/XPlannerTaskEditor.java
>===================================================================
>RCS file: /cvsroot/tools/org.eclipse.mylyn/sandbox/org.eclipse.mylyn.xplanner.ui/src/org/eclipse/mylyn/xplanner/ui/editor/XPlannerTaskEditor.java,v
>retrieving revision 1.8
>diff -u -r1.8 XPlannerTaskEditor.java
>--- src/org/eclipse/mylyn/xplanner/ui/editor/XPlannerTaskEditor.java	1 Mar 2008 21:39:10 -0000	1.8
>+++ src/org/eclipse/mylyn/xplanner/ui/editor/XPlannerTaskEditor.java	4 Mar 2008 02:40:26 -0000
>@@ -31,8 +31,10 @@
> import org.eclipse.ui.IEditorSite;
> import org.eclipse.ui.PlatformUI;
> import org.eclipse.ui.forms.editor.FormEditor;
>+import org.eclipse.ui.forms.widgets.ExpandableComposite;
> import org.eclipse.ui.forms.widgets.FormToolkit;
> import org.eclipse.ui.forms.widgets.ImageHyperlink;
>+import org.eclipse.ui.forms.widgets.Section;
> 
> /**
>  * @author Ravi Kumar
>@@ -57,6 +59,8 @@
> 
> 	private boolean addToCurrentTime;
> 
>+	private Section timeTrackingSection;
>+
> 	public XPlannerTaskEditor(FormEditor editor) {
> 		super(editor);
> 	}
>@@ -191,6 +195,7 @@
> 		boolean useTimeTrackingPreference = XPlannerMylynUIPlugin.getBooleanPreference(XPlannerMylynUIPlugin.USE_AUTO_TIME_TRACKING_PREFERENCE_NAME);
> 		useTimeTrackingButton.setSelection(useTimeTrackingPreference);
> 		setUseAutoTimeTracking(useTimeTrackingPreference);
>+		updateTimeTrackingSection();
> 
> 		// rounding
> 		boolean roundToHalfHourPreference = XPlannerMylynUIPlugin.getBooleanPreference(XPlannerMylynUIPlugin.ROUND_AUTO_TIME_TRACKING_TO_HALF_HOUR_PREFERENCE_NAME);
>@@ -204,6 +209,10 @@
> 		setAddToCurrentTime(addToCurrentTimePreference);
> 	}
> 
>+	private void updateTimeTrackingSection() {
>+		timeTrackingSection.setExpanded(useTimeTrackingButton.getSelection());
>+	}
>+
> 	private void savePreferenceSettings() {
> 		// auto tracking
> 		XPlannerMylynUIPlugin.setBooleanPreference(XPlannerMylynUIPlugin.USE_AUTO_TIME_TRACKING_PREFERENCE_NAME,
>@@ -220,16 +229,38 @@
> 
> 	private void createTimeTrackingPanel(Composite parent) {
> 		FormToolkit toolkit = new FormToolkit(getSite().getShell().getDisplay());
>-		Composite timeTrackingComposite = toolkit.createComposite(parent, SWT.NONE);
>+		timeTrackingSection = toolkit.createSection(parent, ExpandableComposite.LEFT_TEXT_CLIENT_ALIGNMENT
>+				| ExpandableComposite.TWISTIE | ExpandableComposite.CLIENT_INDENT);
>+		timeTrackingSection.setLayout(new GridLayout());
>+		GridDataFactory.fillDefaults().span(4, 1).applyTo(timeTrackingSection);
>+		timeTrackingSection.setText("");
> 
>-		GridDataFactory.fillDefaults().span(4, 1).applyTo(timeTrackingComposite);
>-		timeTrackingComposite.setLayout(new GridLayout(1, false));
>-
>-		useTimeTrackingButton = toolkit.createButton(timeTrackingComposite,
>+		useTimeTrackingButton = toolkit.createButton(timeTrackingSection,
> 				"Update actual task time from Mylyn's time tracker", SWT.CHECK);
>-		GridDataFactory.fillDefaults().span(1, 1).grab(true, false).applyTo(useTimeTrackingButton);
>+		GridDataFactory.fillDefaults().span(1, 1).grab(true, false).align(SWT.LEFT, SWT.CENTER).applyTo(
>+				useTimeTrackingButton);
>+		useTimeTrackingButton.addSelectionListener(new SelectionListener() {
>+			public void widgetDefaultSelected(SelectionEvent e) {
>+			}
>+
>+			public void widgetSelected(SelectionEvent e) {
>+				if (e.getSource().equals(useTimeTrackingButton)) {
>+					updateTimeTrackingSection();
>+				}
>+			}
>+
>+		});
>+
> 		useTimeTrackingButton.addSelectionListener(this);
> 
>+		timeTrackingSection.setTextClient(useTimeTrackingButton);
>+
>+		Composite timeTrackingComposite = toolkit.createComposite(timeTrackingSection, SWT.NONE);
>+		timeTrackingSection.setClient(timeTrackingComposite);
>+
>+		GridDataFactory.fillDefaults().span(4, 1).applyTo(timeTrackingComposite);
>+		timeTrackingComposite.setLayout(new GridLayout(1, false));
>+
> 		roundToHalfHourButton = toolkit.createButton(timeTrackingComposite, "Round time to half hour", SWT.CHECK);
> 		GridDataFactory.fillDefaults().indent(new Point(15, 5)).applyTo(roundToHalfHourButton);
> 		roundToHalfHourButton.addSelectionListener(this);

Actions: View | Diff

Attachments on bug 211101: 84443 | 84444 | 84445 | 84446 | 84449 | 87931 | 87932 | 87934 | 91469 | 91470