Attachment 91372 Details for Bug 202626 – ConfigUpgrade patch

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] ConfigUpgrade patch

202626a.txt (text/plain), 2.76 KB, created by Joel Cayne

on 2008-03-03 10:20:06 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Joel Cayne

Created: 2008-03-03 10:20:06 EST

Size: 2.76 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.tptp.platform.agentcontroller
>Index: src-config/org/eclipse/tptp/platform/agentcontroller/config/ConfigUpgrade.java
>===================================================================
>RCS file: /cvsroot/tptp/platform/org.eclipse.tptp.platform.agentcontroller/src-config/org/eclipse/tptp/platform/agentcontroller/config/ConfigUpgrade.java,v
>retrieving revision 1.2
>diff -u -r1.2 ConfigUpgrade.java
>--- src-config/org/eclipse/tptp/platform/agentcontroller/config/ConfigUpgrade.java	1 Mar 2008 23:57:25 -0000	1.2
>+++ src-config/org/eclipse/tptp/platform/agentcontroller/config/ConfigUpgrade.java	3 Mar 2008 15:18:09 -0000
>@@ -32,12 +32,13 @@
> 
> /**
>  * Sample usage: <br>
>- * ConfigUpgrade upgrade = ConfigUpgrade.getInstance("<AC HOME>\\config\\serviceconfig.xml"); <br>
>- * upgrade.parseDocument();
>+ * ConfigUpgrade upgrade = ConfigUpgrade.getInstance(); <br>
>+ * upgrade.parseDocument("<AC HOME>\\config\\serviceconfig.xml");
>  * 
>  * @author Joel Cayne
>- * @version February 29, 2008
>+ * @version March 3, 2008
>  * @since February 29, 2008
>+ * @provisional
>  * 
>  */
> public class ConfigUpgrade {
>@@ -50,21 +51,24 @@
> 	
> 	/**
> 	 * The method called to acquire a reference of the singleton ConfigUpgrade.
>-	 * @param filename The path to the serviceconfig.xml to retrieve an existing configuration from.
> 	 * @return An instance of ConfigUpgrade.
> 	 */
>-	public static ConfigUpgrade getInstance(String filename) {
>+	public static ConfigUpgrade getInstance() {
> 		if(instance == null) {
>-			instance = new ConfigUpgrade(filename); 
>+			instance = new ConfigUpgrade();
> 		}
> 		return instance;
> 	}
> 
>+	private ConfigUpgrade() {
>+	} 
>+
> 	/**
>-	 * Provides for upgrading an existing Agent Controller installation.
>+	 * Provides for upgrading an existing Agent Controller installation. Parses the serviceconfig.xml and obtains the user provided values.
> 	 * @param filename The path to the serviceconfig.xml to retrieve an existing configuration from.
>+	 * @return The properties hash with the user entered values.
> 	 */
>-	private ConfigUpgrade(String filename) {
>+	public Properties parseDocument(String filename) {
> 		try {
> 			doc = DocumentBuilderFactory.newInstance().newDocumentBuilder().parse(new File(filename));
> 			configFile = new ConfigFile(filename);
>@@ -76,13 +80,7 @@
> 		} catch (ParserConfigurationException e) {
> 			Logger.err(e.getMessage());
> 		}
>-	}
>-
>-	/**
>-	 * Parses the serviceconfig.xml and obtains the user provided values.
>-	 * @return The properties hash with the user entered values.
>-	 */
>-	public Properties parseDocument() {
>+		
> 		properties.put(Constants.JAVA_PATH, configFile.getValue(Constants.JAVA_PATH));
> 		addElement(SecurityEnabled.TAG);
> 		addElement(UserDefinition.TAG);

Actions: View | Diff

Attachments on bug 202626: 90359 | 90748 | 91249 | 91372