Attachment 90372 Details for Bug 219770 – Patch for review

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Patch for review

219770SchemaBrowsing.patch (text/plain), 3.79 KB, created by Curtis Windatt

on 2008-02-21 12:08:57 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Curtis Windatt

Created: 2008-02-21 12:08:57 EST

Size: 3.79 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.pde.ui
>Index: src/org/eclipse/pde/internal/ui/editor/PDESourcePage.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/PDESourcePage.java,v
>retrieving revision 1.80
>diff -u -r1.80 PDESourcePage.java
>--- src/org/eclipse/pde/internal/ui/editor/PDESourcePage.java	22 Jan 2008 19:51:23 -0000	1.80
>+++ src/org/eclipse/pde/internal/ui/editor/PDESourcePage.java	21 Feb 2008 17:05:54 -0000
>@@ -207,7 +207,7 @@
> 	}
> 
> 	protected ISortableContentOutlinePage createOutlinePage() {
>-		SourceOutlinePage sourceOutlinePage = new SourceOutlinePage((IEditingModel) getInputContext().getModel(), createOutlineLabelProvider(), createOutlineContentProvider(), createDefaultOutlineComparator(), createOutlineComparator());
>+		SourceOutlinePage sourceOutlinePage = new SourceOutlinePage(fEditor, (IEditingModel) getInputContext().getModel(), createOutlineLabelProvider(), createOutlineContentProvider(), createDefaultOutlineComparator(), createOutlineComparator());
> 		fOutlinePage = sourceOutlinePage;
> 		fOutlineSelectionChangedListener = new ISelectionChangedListener() {
> 			public void selectionChanged(SelectionChangedEvent event) {
>@@ -630,7 +630,7 @@
> 	 * @param node
> 	 * @param offset
> 	 * @param searchChildren
>-	 * @see org.eclipse.pde.internal.ui.editor.PDESourcePage.findNode(Object[], int, boolean)
>+	 * @see org.eclipse.pde.internal.ui.editor.PDESourcePage#findNode(Object[], int, boolean)
> 	 */
> 	protected IDocumentRange findNode(IDocumentElementNode node, int offset, boolean searchChildren) {
> 		return findNode(new Object[] {node}, offset, searchChildren);
>Index: src/org/eclipse/pde/internal/ui/editor/SourceOutlinePage.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.pde.ui/src/org/eclipse/pde/internal/ui/editor/SourceOutlinePage.java,v
>retrieving revision 1.21
>diff -u -r1.21 SourceOutlinePage.java
>--- src/org/eclipse/pde/internal/ui/editor/SourceOutlinePage.java	16 Jan 2008 17:07:52 -0000	1.21
>+++ src/org/eclipse/pde/internal/ui/editor/SourceOutlinePage.java	21 Feb 2008 17:05:54 -0000
>@@ -1,5 +1,5 @@
> /*******************************************************************************
>- * Copyright (c) 2000, 2007 IBM Corporation and others.
>+ * Copyright (c) 2000, 2008 IBM Corporation and others.
>  * All rights reserved. This program and the accompanying materials
>  * are made available under the terms of the Eclipse Public License v1.0
>  * which accompanies this distribution, and is available at
>@@ -41,7 +41,16 @@
> 	private ArrayList fListenerList;
> 
> 	public SourceOutlinePage(IEditingModel model, IBaseLabelProvider lProvider, IContentProvider cProvider, ViewerComparator defaultComparator, ViewerComparator comparator) {
>-		super();
>+		fModel = model;
>+		fLabelProvider = lProvider;
>+		fContentProvider = cProvider;
>+		fDefaultComparator = defaultComparator;
>+		fViewerComparator = comparator;
>+		fListenerList = new ArrayList();
>+	}
>+
>+	public SourceOutlinePage(PDEFormEditor editor, IEditingModel model, IBaseLabelProvider lProvider, IContentProvider cProvider, ViewerComparator defaultComparator, ViewerComparator comparator) {
>+		super(editor);
> 		fModel = model;
> 		fLabelProvider = lProvider;
> 		fContentProvider = cProvider;
>@@ -113,7 +122,7 @@
> 	}
> 
> 	/**
>-	 * Used for restoral after temporary removal.  Uses listeners cached.
>+	 * Used for restoration after temporary removal.  Uses listeners cached.
> 	 */
> 	public void addAllSelectionChangedListeners() {
> 		// Re-add the tree listener added by our parent for our parent:
>@@ -127,9 +136,6 @@
> 		}
> 	}
> 
>-	/**
>-	 * @return
>-	 */
> 	private boolean isViewerDefined() {
> 		if (viewer == null) {
> 			return false;

Actions: View | Diff

Attachments on bug 219770: 90372 | 90387