Attachment 90320 Details for Bug 73979 – patch

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] patch

patch-73979.txt (text/plain), 1.56 KB, created by Martin Aeschlimann

on 2008-02-21 05:05:10 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Aeschlimann

Created: 2008-02-21 05:05:10 EST

Size: 1.56 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.ui.workbench
>Index: Eclipse UI/org/eclipse/ui/internal/decorators/DecoratorManager.java
>===================================================================
>RCS file: /cvsroot/eclipse/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/decorators/DecoratorManager.java,v
>retrieving revision 1.59
>diff -u -r1.59 DecoratorManager.java
>--- Eclipse UI/org/eclipse/ui/internal/decorators/DecoratorManager.java	8 May 2006 20:55:51 -0000	1.59
>+++ Eclipse UI/org/eclipse/ui/internal/decorators/DecoratorManager.java	21 Feb 2008 09:52:53 -0000
>@@ -876,10 +876,10 @@
>                 force, originalText, context); 
> 
>         //If all that is there is deferred ones then defer decoration.
>-        //For the sake of efficiency we do not test for enablement at this
>+        //For the sake of efficiency we do not test for element enablement at this
>         //point and just abandon deferment if there are any to run right
>         //away
>-        return getFullDefinitions().length > 0;
>+        return hasEnabledFullDefinitions();
>     }
> 
>     /* (non-Javadoc)
>@@ -918,6 +918,15 @@
> 		}
> 		return fullDefinitions;
> 	}
>+	
>+	private boolean hasEnabledFullDefinitions() {
>+		FullDecoratorDefinition[] definitions= getFullDefinitions();
>+		for (int i= 0; i < definitions.length; i++) {
>+			if (definitions[i].isEnabled())
>+				return true;
>+		}
>+		return false;
>+	}
> 
>     private IExtensionPoint getExtensionPointFilter() {
>         return Platform.getExtensionRegistry().getExtensionPoint(EXTENSIONPOINT_UNIQUE_ID);

Actions: View | Diff

Attachments on bug 73979: 90320 | 90356