Attachment 88199 Details for Bug 159566 – Proposed Patch to fix NPE

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

[patch] Proposed Patch to fix NPE

BUG159566_200801291632.patch (text/plain), 1.14 KB, created by Nick Sandonato

on 2008-01-29 16:32:52 EST

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Sandonato

Created: 2008-01-29 16:32:52 EST

Size: 1.14 KB

patch

obsolete

>### Eclipse Workspace Patch 1.0
>#P org.eclipse.wst.xml.core
>Index: src/org/eclipse/wst/xml/core/internal/provisional/format/ElementNodeFormatter.java
>===================================================================
>RCS file: /cvsroot/webtools/sourceediting/plugins/org.eclipse.wst.xml.core/src/org/eclipse/wst/xml/core/internal/provisional/format/ElementNodeFormatter.java,v
>retrieving revision 1.9
>diff -u -r1.9 ElementNodeFormatter.java
>--- src/org/eclipse/wst/xml/core/internal/provisional/format/ElementNodeFormatter.java	29 Mar 2007 01:41:56 -0000	1.9
>+++ src/org/eclipse/wst/xml/core/internal/provisional/format/ElementNodeFormatter.java	29 Jan 2008 21:31:43 -0000
>@@ -392,7 +392,10 @@
> 
> 							// xml:space="preserve" means preserve space,
> 							// everything else means back to default.
>-							if (defaultValue.compareTo(PRESERVE) == 0)
>+							
>+							// https://bugs.eclipse.org/bugs/show_bug.cgi?id=159566
>+							// defaultValue could potentially be NULL
>+							if(PRESERVE.equals(defaultValue))
> 								formatContraints.setInPreserveSpaceElement(true);
> 							else
> 								formatContraints.setInPreserveSpaceElement(false);

Actions: View | Diff

Attachments on bug 159566: 51320 | 51321 | 88199